Re: [PATCH 00/29] constify scsi pci_device_id.
On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote: > However, having a bazillion identical commit messages is also really > annoying. So for automated changes like this, I'd rather just have a > single patch. Thought so ;-) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 00/29] constify scsi pci_device_id.
Johannes, > Ultimately it's up to Martin and James but I don't see a hughe benefit > in having it all in a separate patch. Generally speaking, I prefer driver maintainers to be able to sign off on changes to their code. So I tend to lean towards a per-driver grouping. However, having a bazillion identical commit messages is also really annoying. So for automated changes like this, I'd rather just have a single patch. It needs to have a really good and comprehensive commit messages that justifies the (sub) tree-wide change, though... -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/29] constify scsi pci_device_id.
On Mon, Jul 31, 2017 at 02:23:11PM +0530, Arvind Yadav wrote: > Yes, We can add all of them in single patch. But other maintainer wants > single single patch. thats why I have send 29 patch. :( Ultimately it's up to Martin and James but I don't see a hughe benefit in having it all in a separate patch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 00/29] constify scsi pci_device_id.
On Monday 31 July 2017 01:26 PM, Johannes Thumshirn wrote: On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote: pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Can't this go all in one patch instead of replicating the same patch 29 times? Yes, We can add all of them in single patch. But other maintainer wants single single patch. thats why I have send 29 patch. :( Thanks, Johannes ~arvind
Re: [PATCH 00/29] constify scsi pci_device_id.
On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. Can't this go all in one patch instead of replicating the same patch 29 times? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
