Re: [PATCH 01/24] block: disable elevator for reserved tags

2019-06-04 Thread Hannes Reinecke
On 6/4/19 10:14 AM, Christoph Hellwig wrote:
> On Wed, May 29, 2019 at 03:28:38PM +0200, Hannes Reinecke wrote:
>> Reserved requests are internal to the driver and we wouldn't know
>> if and how they should be merged.
>> So disable the elevator for reserved tags.
> 
> Internal request better be REQ_OP_DRV* pass through requests,
> for which we never merge anyway.  So this patch doesn't look like
> it actually is needed.
> 
Okay, will be dropping it for the next iteration.

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries & Storage
h...@suse.com  +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)


Re: [PATCH 01/24] block: disable elevator for reserved tags

2019-06-04 Thread Christoph Hellwig
On Wed, May 29, 2019 at 03:28:38PM +0200, Hannes Reinecke wrote:
> Reserved requests are internal to the driver and we wouldn't know
> if and how they should be merged.
> So disable the elevator for reserved tags.

Internal request better be REQ_OP_DRV* pass through requests,
for which we never merge anyway.  So this patch doesn't look like
it actually is needed.