Re: Please help me to review the patch about supporting SATA PM in LIBSAS
On Thu, Apr 17, 2014 at 9:03 AM, Dan Williams dan.j.willi...@intel.com wrote: On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu yxlr...@gmail.com wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. Until now, i have tested the identified, hot-plug and IO function and result is ok except one mvsas timeout issue. i'll continue to debug mvsas issue, but i don't know whether the libsas code of the patch is ok. So, please help me to review the patch if you feel free. thanks! the patch is as below: Can you help me with a bit more description on the design of the patch? Details like why you decided to implement pieces the way you did, and comments on the difficulties / trade-offs you ran into would really be helpful for reviewing. Not just for me, but for anyone else on the mailing list who might be able to offer some review cycles if they had a small amount of background on the libsas/libata details. ...also, please resend as an attachment so that the whitespace remains in tact. Thanks. -- Dan -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please help me to review the patch about supporting SATA PM in LIBSAS
On Thu, 2014-04-17 at 11:07 +0800, xiangliang yu wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. By PM you mean Port Multipilier not Power Management ... we can be easily confused by the acronym, so I'd spell it out. It also looks like the patch does a bit more: it adds more fine grained SATA error handling, so in final form it probably should be three patches: the EH changes, the PMP additions and the mvsas updates to take advantage of it. Until now, i have tested the identified, hot-plug and IO function and result is ok except one mvsas timeout issue. i'll continue to debug mvsas issue, but i don't know whether the libsas code of the patch is ok. So, please help me to review the patch if you feel free. thanks! the patch is as below: Your mail system (this time gmail I think) managed to destroy the patch by reducing all the tabs to a single space, so while it might be OK, I can't be sure I'm reading it correctly. You also have a few generic spelling mistakes like falied instead of failed. As part of the error handler rewrite, you disconnect ata_std_error_handler() can we just remove that function now? James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please help me to review the patch about supporting SATA PM in LIBSAS
On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu yxlr...@gmail.com wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. Until now, i have tested the identified, hot-plug and IO function and result is ok except one mvsas timeout issue. i'll continue to debug mvsas issue, but i don't know whether the libsas code of the patch is ok. So, please help me to review the patch if you feel free. thanks! the patch is as below: Can you help me with a bit more description on the design of the patch? Details like why you decided to implement pieces the way you did, and comments on the difficulties / trade-offs you ran into would really be helpful for reviewing. Not just for me, but for anyone else on the mailing list who might be able to offer some review cycles if they had a small amount of background on the libsas/libata details. -- Dan -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
