subject:"\[PATCH v2 4\/5\] fbdev\: Include in drivers"

Re: [PATCH v2 4/5] fbdev: Include in drivers

2023-04-28 Thread Thomas Zimmermann


Hi Sam

Am 28.04.23 um 15:07 schrieb Sam Ravnborg:

On Fri, Apr 28, 2023 at 11:27:10AM +0200, Thomas Zimmermann wrote:

Fbdev's main header file, , includes  to get
declarations of I/O helper functions. From these declaratons, it later
defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or
fb_memset().

The framebuffer I/O helpers pre-date Linux' current I/O code and will
be replaced by regular I/O helpers. Prepare this change by adding an
include statement for  to all source files that use the
framebuffer I/O helpers. They will still get declarations of the I/O
functions even after  has been cleaned up.

When fb.h uses a symbol from io.h, then it shall include that
file so it is self contained.
So it is wrong to push the io.h include to the users of
fb_{read,write,xxx}. Maybe fb.h only uses macros as is the case here,
but that is no excuse nt to include io.h.

Drop these changes.


No problem. That was done with an eye on removing the fb_() macros 
entirely. But the discussion around patch 5 now goes in a different 
direction anyway.


Best regards
Thomas




Driver source
files that already include  convert to .

This is a nice cleanup - we should keep that.

Sam


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


OpenPGP_signature
Description: OpenPGP digital signature
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v2 4/5] fbdev: Include in drivers

2023-04-28 Thread Sam Ravnborg

On Fri, Apr 28, 2023 at 11:27:10AM +0200, Thomas Zimmermann wrote:
> Fbdev's main header file, , includes  to get
> declarations of I/O helper functions. From these declaratons, it later
> defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or
> fb_memset().
> 
> The framebuffer I/O helpers pre-date Linux' current I/O code and will
> be replaced by regular I/O helpers. Prepare this change by adding an
> include statement for  to all source files that use the
> framebuffer I/O helpers. They will still get declarations of the I/O
> functions even after  has been cleaned up.
When fb.h uses a symbol from io.h, then it shall include that
file so it is self contained.
So it is wrong to push the io.h include to the users of
fb_{read,write,xxx}. Maybe fb.h only uses macros as is the case here,
but that is no excuse nt to include io.h.

Drop these changes.

> Driver source
> files that already include  convert to .
This is a nice cleanup - we should keep that.

Sam

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH v2 4/5] fbdev: Include in drivers

2023-04-28 Thread Thomas Zimmermann

Fbdev's main header file, , includes  to get
declarations of I/O helper functions. From these declaratons, it later
defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or
fb_memset().

The framebuffer I/O helpers pre-date Linux' current I/O code and will
be replaced by regular I/O helpers. Prepare this change by adding an
include statement for  to all source files that use the
framebuffer I/O helpers. They will still get declarations of the I/O
functions even after  has been cleaned up. Driver source
files that already include  convert to .

Signed-off-by: Thomas Zimmermann 
---
 drivers/video/fbdev/arkfb.c | 1 +
 drivers/video/fbdev/aty/mach64_cursor.c | 3 +--
 drivers/video/fbdev/chipsfb.c   | 1 +
 drivers/video/fbdev/cirrusfb.c  | 1 +
 drivers/video/fbdev/core/cfbcopyarea.c  | 2 +-
 drivers/video/fbdev/core/cfbfillrect.c  | 2 ++
 drivers/video/fbdev/core/cfbimgblt.c| 2 ++
 drivers/video/fbdev/core/fbmem.c| 1 +
 drivers/video/fbdev/core/svgalib.c  | 2 +-
 drivers/video/fbdev/hgafb.c | 2 +-
 drivers/video/fbdev/hitfb.c | 2 +-
 drivers/video/fbdev/kyro/fbdev.c| 2 +-
 drivers/video/fbdev/matrox/matroxfb_accel.c | 2 ++
 drivers/video/fbdev/matrox/matroxfb_base.h  | 2 +-
 drivers/video/fbdev/pm2fb.c | 1 +
 drivers/video/fbdev/pm3fb.c | 1 +
 drivers/video/fbdev/pvr2fb.c| 1 +
 drivers/video/fbdev/s3fb.c  | 1 +
 drivers/video/fbdev/sstfb.c | 2 +-
 drivers/video/fbdev/tdfxfb.c| 2 +-
 drivers/video/fbdev/tridentfb.c | 1 +
 drivers/video/fbdev/vga16fb.c   | 2 +-
 drivers/video/fbdev/vt8623fb.c  | 1 +
 23 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index 60a96fdb5dd8..c254ab6fbb7d 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include  /* Why should fb driver call console functions? 
because console_lock() */
 #include 
diff --git a/drivers/video/fbdev/aty/mach64_cursor.c 
b/drivers/video/fbdev/aty/mach64_cursor.c
index 4ad0331a8c57..c1347c37a146 100644
--- a/drivers/video/fbdev/aty/mach64_cursor.c
+++ b/drivers/video/fbdev/aty/mach64_cursor.c
@@ -5,11 +5,10 @@
 
 #include 
 #include 
+#include 
 #include 
 #include "../core/fb_draw.h"
 
-#include 
-
 #ifdef __sparc__
 #include 
 #endif
diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
index 7799d52a651f..9cb719afe033 100644
--- a/drivers/video/fbdev/chipsfb.c
+++ b/drivers/video/fbdev/chipsfb.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
index ba45e2147c52..89366a78b010 100644
--- a/drivers/video/fbdev/cirrusfb.c
+++ b/drivers/video/fbdev/cirrusfb.c
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #ifdef CONFIG_ZORRO
 #include 
diff --git a/drivers/video/fbdev/core/cfbcopyarea.c 
b/drivers/video/fbdev/core/cfbcopyarea.c
index 6d4bfeecee35..fc3a99a50266 100644
--- a/drivers/video/fbdev/core/cfbcopyarea.c
+++ b/drivers/video/fbdev/core/cfbcopyarea.c
@@ -26,8 +26,8 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 #include "fb_draw.h"
 
 #if BITS_PER_LONG == 32
diff --git a/drivers/video/fbdev/core/cfbfillrect.c 
b/drivers/video/fbdev/core/cfbfillrect.c
index ba9f58b2a5e8..15fd4927a031 100644
--- a/drivers/video/fbdev/core/cfbfillrect.c
+++ b/drivers/video/fbdev/core/cfbfillrect.c
@@ -13,6 +13,8 @@
  *  the native cpu endians. I also need to deal with MSB position in the word.
  *
  */
+
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/video/fbdev/core/cfbimgblt.c 
b/drivers/video/fbdev/core/cfbimgblt.c
index 9ebda4e0dc7a..e8c957f51fd4 100644
--- a/drivers/video/fbdev/core/cfbimgblt.c
+++ b/drivers/video/fbdev/core/cfbimgblt.c
@@ -29,6 +29,8 @@
  *  Also need to add code to deal with cards endians that are different than
  *  the native cpu endians. I also need to deal with MSB position in the word.
  */
+
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 3fd95a79e4c3..2047bffe4a6c 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/video/fbdev/core/svgalib.c 
b/drivers/video/fbdev/core/svgalib.c
index 9e01322fabe3..c4731b95a36d 100644
--- a/drivers/video/fbdev/core/svgalib.c
+++ b/drivers/video/fbdev/core/svgalib.c
@@ -15,8 +15,8 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 
 
 /* Write a CRT register value spread across multiple registers */
diff --git a/drivers/video/fbdev/hgafb.c

Re: [PATCH v2 4/5] fbdev: Include in drivers

Re: [PATCH v2 4/5] fbdev: Include in drivers

[PATCH v2 4/5] fbdev: Include in drivers

3 matches

Site Navigation

Mail list logo

Footer information