Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Tue, Nov 08, 2016 at 11:51:29AM +0100, Jean-Francois Moine wrote: > On Mon, 7 Nov 2016 21:05:05 +0100 > Maxime Ripardwrote: > > > Hi, > > > > On Sun, Nov 06, 2016 at 07:02:48PM +0100, Jean-Francois Moine wrote: > > > On Sun, 23 Oct 2016 09:33:16 +0800 > > > Chen-Yu Tsai wrote: > > > > > > > On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moine > > > > wrote: > > > > > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > > > > > > > > > Signed-off-by: Jean-Francois Moine > > > > > --- > > > > > Note: This driver is closed to the sun4i-i2s except that: > > > > > - it handles the H3 > > > > > > > > If it's close to sun4i-i2s, you should probably rework that one to > > > > support > > > > the newer SoCs. > > > > > > I started to add the H3 into the sun4i-i2s, but I am blocked with > > > regmap. > > > Many H3 registers are common with the A10, but some of them have more > > > or less fields, the fields may be at different offsets. And, finally, > > > some registers are completely different. > > > This would not raise any problem, except with regmap which is really > > > painful. > > > > That's weird, because regmap's regmap_field should make that much > > easier. > > #define field_relaxed(addr, mask, val) \ > writel_relaxed((readl_relaxed(addr) & mask) | val, addr) I'm not sure what you mean here. > > > As I may understood, regmap is used to simplify suspend/resume, but, is > > > it useful to save the I2S register on suspend? > > > Practically, I am streaming some tune on my device. I suspend it for > > > any reason. The next morning, I resume it. Are you sure I want to > > > continue to hear the end of the tune? > > > > > > I better think that streaming should be simply stopped on suspend. > > > > You're mistaken. The code in there is for *runtime* suspend, ie when > > the device is no longer used, so that case shouldn't even happen at > > all. > > > > (And real suspend isn't supported anyway) > > Is it time to remove this useless code? Which useless code? > > > Then, there is no need to save the playing registers, and, here I am, > > > there is no need to use regmap. > > > > > > May I go this way? > > > > No, please don't. regmap is also providing very useful features, such > > as access to all the registers through debugfs, or tracing. What > > exactly feels painful to you? > > When the I/O registers are in memory (that's the case), you may access > them (read and write) thru /dev/mem. For all the registers if you want to dump all of them. It needs scripting, it needs root access, and it needs some tool (either devmem or a custom one) to dump the values. And this is if you have the right kernel configuration options (devmem enabled, with the protection against mapped devices disabled). It just works with debugfs. > Also, is a register access trace really needed in this driver? Yes. > The pain is to define the regmap_config (which registers can be > read/write/volatile and which can be the values the u-boot let us in > the registers at startup time), and the lot of code which is run instead > of simple load/store machine instructions. This is only needed if you want to use caching, and caching is optional. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Mon, 7 Nov 2016 21:05:05 +0100 Maxime Ripardwrote: > Hi, > > On Sun, Nov 06, 2016 at 07:02:48PM +0100, Jean-Francois Moine wrote: > > On Sun, 23 Oct 2016 09:33:16 +0800 > > Chen-Yu Tsai wrote: > > > > > On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moine > > > wrote: > > > > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > > > > > > > Signed-off-by: Jean-Francois Moine > > > > --- > > > > Note: This driver is closed to the sun4i-i2s except that: > > > > - it handles the H3 > > > > > > If it's close to sun4i-i2s, you should probably rework that one to support > > > the newer SoCs. > > > > I started to add the H3 into the sun4i-i2s, but I am blocked with > > regmap. > > Many H3 registers are common with the A10, but some of them have more > > or less fields, the fields may be at different offsets. And, finally, > > some registers are completely different. > > This would not raise any problem, except with regmap which is really > > painful. > > That's weird, because regmap's regmap_field should make that much > easier. #define field_relaxed(addr, mask, val) \ writel_relaxed((readl_relaxed(addr) & mask) | val, addr) > > As I may understood, regmap is used to simplify suspend/resume, but, is > > it useful to save the I2S register on suspend? > > Practically, I am streaming some tune on my device. I suspend it for > > any reason. The next morning, I resume it. Are you sure I want to > > continue to hear the end of the tune? > > > > I better think that streaming should be simply stopped on suspend. > > You're mistaken. The code in there is for *runtime* suspend, ie when > the device is no longer used, so that case shouldn't even happen at > all. > > (And real suspend isn't supported anyway) Is it time to remove this useless code? > > Then, there is no need to save the playing registers, and, here I am, > > there is no need to use regmap. > > > > May I go this way? > > No, please don't. regmap is also providing very useful features, such > as access to all the registers through debugfs, or tracing. What > exactly feels painful to you? When the I/O registers are in memory (that's the case), you may access them (read and write) thru /dev/mem. Also, is a register access trace really needed in this driver? The pain is to define the regmap_config (which registers can be read/write/volatile and which can be the values the u-boot let us in the registers at startup time), and the lot of code which is run instead of simple load/store machine instructions. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
Hi, On Sun, Nov 06, 2016 at 07:02:48PM +0100, Jean-Francois Moine wrote: > On Sun, 23 Oct 2016 09:33:16 +0800 > Chen-Yu Tsaiwrote: > > > On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moine > > wrote: > > > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > > > > > Signed-off-by: Jean-Francois Moine > > > --- > > > Note: This driver is closed to the sun4i-i2s except that: > > > - it handles the H3 > > > > If it's close to sun4i-i2s, you should probably rework that one to support > > the newer SoCs. > > I started to add the H3 into the sun4i-i2s, but I am blocked with > regmap. > Many H3 registers are common with the A10, but some of them have more > or less fields, the fields may be at different offsets. And, finally, > some registers are completely different. > This would not raise any problem, except with regmap which is really > painful. That's weird, because regmap's regmap_field should make that much easier. > As I may understood, regmap is used to simplify suspend/resume, but, is > it useful to save the I2S register on suspend? > Practically, I am streaming some tune on my device. I suspend it for > any reason. The next morning, I resume it. Are you sure I want to > continue to hear the end of the tune? > > I better think that streaming should be simply stopped on suspend. You're mistaken. The code in there is for *runtime* suspend, ie when the device is no longer used, so that case shouldn't even happen at all. (And real suspend isn't supported anyway) > Then, there is no need to save the playing registers, and, here I am, > there is no need to use regmap. > > May I go this way? No, please don't. regmap is also providing very useful features, such as access to all the registers through debugfs, or tracing. What exactly feels painful to you? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Sun, 23 Oct 2016 09:33:16 +0800 Chen-Yu Tsaiwrote: > On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moine wrote: > > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > > > Signed-off-by: Jean-Francois Moine > > --- > > Note: This driver is closed to the sun4i-i2s except that: > > - it handles the H3 > > If it's close to sun4i-i2s, you should probably rework that one to support > the newer SoCs. I started to add the H3 into the sun4i-i2s, but I am blocked with regmap. Many H3 registers are common with the A10, but some of them have more or less fields, the fields may be at different offsets. And, finally, some registers are completely different. This would not raise any problem, except with regmap which is really painful. As I may understood, regmap is used to simplify suspend/resume, but, is it useful to save the I2S register on suspend? Practically, I am streaming some tune on my device. I suspend it for any reason. The next morning, I resume it. Are you sure I want to continue to hear the end of the tune? I better think that streaming should be simply stopped on suspend. Then, there is no need to save the playing registers, and, here I am, there is no need to use regmap. May I go this way? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [alsa-devel] [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Thu, Oct 27, 2016 at 05:13:25PM +0200, Jean-Francois Moine wrote: > On Mon, 24 Oct 2016 14:34:49 +0200 > Maxime Ripardwrote: > > > Hi, > > > > On Sun, Oct 23, 2016 at 09:45:03AM +0200, Jean-Francois Moine wrote: > > > On Sun, 23 Oct 2016 09:33:16 +0800 > > > Chen-Yu Tsai wrote: > > > > > > > > Note: This driver is closed to the sun4i-i2s except that: > > > > > - it handles the H3 > > > > > > > > If it's close to sun4i-i2s, you should probably rework that one to > > > > support > > > > the newer SoCs. > > > > > > > > > - it creates the sound card (with sun4i-i2s, the sound card is created > > > > > by the CODECs) > > > > > > > > I think this is wrong. I2S is only the DAI. You typically have a > > > > separate > > > > platform driver for the whole card, or just use simple-card. > > > > > > An other device is not needed. The layout is simple: > > > I2S_controller (CPU DAI) <-> HDMI_CODEC (CODEC DAI) > > > The HDMI CODEC is supported by the HDMI video driver (only one device), > > > so, it cannot be the card device. > > > ASoC does not use the CPU DAI device (I2S_controller), so, it is > > > natural to use it to handle the card. > > > > Still, duplicating the driver is not the solution. I agree with > > Chen-Yu that we want to leverage the driver that is already there. > > Hi Maxime and Chen-Yu, > > After looking at the sun4i-i2s, I found 2 solutions for re-using its > code in the DE2 HDMI context: > > 1) either to split the sun4i-i2s driver into common I/O functions and >slave CPU DAI, > > 2) or to move the sun4i-i2s into a master CPU DAI. > > ( > some explanation about 'master' and 'slave': the master is the > component the device of which is also the sound card. > As the sound card uses the 'drvdata' of the device, this drvdata pointer > cannot be used by the master. > In the actual implementations: > - sun4i-i2s > master: card dev = codec dev, drvdata -> card > slave: i2s dev (CPU DAI), drvdata -> i2s data > - sun8i-i2s > master: card dev = i2s dev (CPU DAI), drvdata -> card > slave: codec dev (hdmi), drvdata -> codec data (audio/video) > ) > > In the case 1, there is no functional change, just a source split. > The sun8i-i2s will then use the common I/O functions. > > In the case 2, the CODECs using the sun4i-i2s would have to move to > slave CODEC DAI, i.e. the card is created by the sun4i-i2s code. > In the 4.9, there is only one codec (sun4i-codec), so, the change > is just to move the card creation and the use of drvdata in both > codes. I think you're mistaken. sun4i-codec has nothing to do with the I2S driver. It's a driver for the (poorly named) Allwinner's Audio Codec which features it's own DAI and Codec directly into the SoC. The DAI being different from the I2S one. However, we want to use any codec driver with the i2s driver, including those in sound/soc/codecs, and we already have drivers for them. So I'm not sure either solution is a good one. Why not just make the HDMI part a codec itself, and use the i2s driver as the CPU DAI, like any other codec? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [alsa-devel] [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Mon, 24 Oct 2016 14:34:49 +0200 Maxime Ripardwrote: > Hi, > > On Sun, Oct 23, 2016 at 09:45:03AM +0200, Jean-Francois Moine wrote: > > On Sun, 23 Oct 2016 09:33:16 +0800 > > Chen-Yu Tsai wrote: > > > > > > Note: This driver is closed to the sun4i-i2s except that: > > > > - it handles the H3 > > > > > > If it's close to sun4i-i2s, you should probably rework that one to support > > > the newer SoCs. > > > > > > > - it creates the sound card (with sun4i-i2s, the sound card is created > > > > by the CODECs) > > > > > > I think this is wrong. I2S is only the DAI. You typically have a separate > > > platform driver for the whole card, or just use simple-card. > > > > An other device is not needed. The layout is simple: > > I2S_controller (CPU DAI) <-> HDMI_CODEC (CODEC DAI) > > The HDMI CODEC is supported by the HDMI video driver (only one device), > > so, it cannot be the card device. > > ASoC does not use the CPU DAI device (I2S_controller), so, it is > > natural to use it to handle the card. > > Still, duplicating the driver is not the solution. I agree with > Chen-Yu that we want to leverage the driver that is already there. Hi Maxime and Chen-Yu, After looking at the sun4i-i2s, I found 2 solutions for re-using its code in the DE2 HDMI context: 1) either to split the sun4i-i2s driver into common I/O functions and slave CPU DAI, 2) or to move the sun4i-i2s into a master CPU DAI. ( some explanation about 'master' and 'slave': the master is the component the device of which is also the sound card. As the sound card uses the 'drvdata' of the device, this drvdata pointer cannot be used by the master. In the actual implementations: - sun4i-i2s master: card dev = codec dev, drvdata -> card slave: i2s dev (CPU DAI), drvdata -> i2s data - sun8i-i2s master: card dev = i2s dev (CPU DAI), drvdata -> card slave: codec dev (hdmi), drvdata -> codec data (audio/video) ) In the case 1, there is no functional change, just a source split. The sun8i-i2s will then use the common I/O functions. In the case 2, the CODECs using the sun4i-i2s would have to move to slave CODEC DAI, i.e. the card is created by the sun4i-i2s code. In the 4.9, there is only one codec (sun4i-codec), so, the change is just to move the card creation and the use of drvdata in both codes. In either cases, I could not check if this changes raise some regression on the sun4i SoCs side. Then, I'd be glad to know: - which solution suits you? - are you ready to do and test the needed changes at the sun4i side? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
Hi, On Sun, Oct 23, 2016 at 09:45:03AM +0200, Jean-Francois Moine wrote: > On Sun, 23 Oct 2016 09:33:16 +0800 > Chen-Yu Tsaiwrote: > > > > Note: This driver is closed to the sun4i-i2s except that: > > > - it handles the H3 > > > > If it's close to sun4i-i2s, you should probably rework that one to support > > the newer SoCs. > > > > > - it creates the sound card (with sun4i-i2s, the sound card is created > > > by the CODECs) > > > > I think this is wrong. I2S is only the DAI. You typically have a separate > > platform driver for the whole card, or just use simple-card. > > An other device is not needed. The layout is simple: > I2S_controller (CPU DAI) <-> HDMI_CODEC (CODEC DAI) > The HDMI CODEC is supported by the HDMI video driver (only one device), > so, it cannot be the card device. > ASoC does not use the CPU DAI device (I2S_controller), so, it is > natural to use it to handle the card. Still, duplicating the driver is not the solution. I agree with Chen-Yu that we want to leverage the driver that is already there. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
On Sun, 23 Oct 2016 09:33:16 +0800 Chen-Yu Tsaiwrote: > > Note: This driver is closed to the sun4i-i2s except that: > > - it handles the H3 > > If it's close to sun4i-i2s, you should probably rework that one to support > the newer SoCs. > > > - it creates the sound card (with sun4i-i2s, the sound card is created > > by the CODECs) > > I think this is wrong. I2S is only the DAI. You typically have a separate > platform driver for the whole card, or just use simple-card. An other device is not needed. The layout is simple: I2S_controller (CPU DAI) <-> HDMI_CODEC (CODEC DAI) The HDMI CODEC is supported by the HDMI video driver (only one device), so, it cannot be the card device. ASoC does not use the CPU DAI device (I2S_controller), so, it is natural to use it to handle the card. Otherwise, the simple-card asks for a node definition in the DT and this node is a pure Linux software entity. On the other side, the simple-graph-card from Kuninori is not useful for this simple case. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
Hi, On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moinewrote: > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > Signed-off-by: Jean-Francois Moine > --- > Note: This driver is closed to the sun4i-i2s except that: > - it handles the H3 If it's close to sun4i-i2s, you should probably rework that one to support the newer SoCs. > - it creates the sound card (with sun4i-i2s, the sound card is created > by the CODECs) I think this is wrong. I2S is only the DAI. You typically have a separate platform driver for the whole card, or just use simple-card. > --- > .../devicetree/bindings/sound/sun4i-i2s.txt| 38 +- > sound/soc/sunxi/Kconfig| 8 + > sound/soc/sunxi/Makefile | 3 + > sound/soc/sunxi/sun8i-i2s.c| 700 > + > 4 files changed, 744 insertions(+), 5 deletions(-) > create mode 100644 sound/soc/sunxi/sun8i-i2s.c > > diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > index 7b526ec..2fb0a7a 100644 > --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > @@ -1,4 +1,4 @@ > -* Allwinner A10 I2S controller > +* Allwinner A10/A38T/H3 I2S controller > > The I2S bus (Inter-IC sound bus) is a serial link for digital > audio data transfer between devices in the system. > @@ -6,20 +6,30 @@ audio data transfer between devices in the system. > Required properties: > > - compatible: should be one of the followings > - - "allwinner,sun4i-a10-i2s" > + - "allwinner,sun4i-a10-i2s" > + "allwinner,sun8i-a83t-i2s" > + "allwinner,sun8i-h3-i2s" > - reg: physical base address of the controller and length of memory mapped >region. > -- interrupts: should contain the I2S interrupt. > - dmas: DMA specifiers for tx and rx dma. See the DMA client binding, > Documentation/devicetree/bindings/dma/dma.txt > -- dma-names: should include "tx" and "rx". > +- dma-names: must include "tx" and/or "rx". > - clocks: a list of phandle + clock-specifer pairs, one for each entry in > clock-names. > - clock-names: should contain followings: > - "apb" : clock for the I2S bus interface > - "mod" : module clock for the I2S controller > - #sound-dai-cells : Must be equal to 0 > > -Example: > +Optional properties: > + > +- interrupts: I2S interrupt > +- resets: phandle to the reset of the device > + > +Required nodes: > + > + - port: link to the associated CODEC (DAC, HDMI...) Note here you are changing an existing binding, adding a required node. If it were truely different, you probably should've started a new binding. Regards ChenYu > + > +Example 1: > > i2s0: i2s@01c22400 { > #sound-dai-cells = <0>; > @@ -32,3 +42,21 @@ i2s0: i2s@01c22400 { >< SUN4I_DMA_NORMAL 3>; > dma-names = "rx", "tx"; > }; > + > +Example 2: > + > +i2s2: i2s@1c22800 { > + compatible = "allwinner,sun8i-a83t-i2s"; > + reg = <0x01c22800 0x60>; > + clocks = < CLK_BUS_I2S2>, < CLK_I2S2>; > + clock-names = "apb", "mod"; > + resets = < RST_I2S2>; > + dmas = < 27>; > + dma-names = "tx"; > + status = "disabled"; > + port { > + i2s2_hdmi: endpoint { > + remote-endpoint = <_i2s2>; > + }; > + }; > +}; -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[linux-sunxi] [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver
This patch adds I2S support to sun8i SoCs as the A83T and H3. Signed-off-by: Jean-Francois Moine--- Note: This driver is closed to the sun4i-i2s except that: - it handles the H3 - it creates the sound card (with sun4i-i2s, the sound card is created by the CODECs) --- .../devicetree/bindings/sound/sun4i-i2s.txt| 38 +- sound/soc/sunxi/Kconfig| 8 + sound/soc/sunxi/Makefile | 3 + sound/soc/sunxi/sun8i-i2s.c| 700 + 4 files changed, 744 insertions(+), 5 deletions(-) create mode 100644 sound/soc/sunxi/sun8i-i2s.c diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt index 7b526ec..2fb0a7a 100644 --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt @@ -1,4 +1,4 @@ -* Allwinner A10 I2S controller +* Allwinner A10/A38T/H3 I2S controller The I2S bus (Inter-IC sound bus) is a serial link for digital audio data transfer between devices in the system. @@ -6,20 +6,30 @@ audio data transfer between devices in the system. Required properties: - compatible: should be one of the followings - - "allwinner,sun4i-a10-i2s" + - "allwinner,sun4i-a10-i2s" + "allwinner,sun8i-a83t-i2s" + "allwinner,sun8i-h3-i2s" - reg: physical base address of the controller and length of memory mapped region. -- interrupts: should contain the I2S interrupt. - dmas: DMA specifiers for tx and rx dma. See the DMA client binding, Documentation/devicetree/bindings/dma/dma.txt -- dma-names: should include "tx" and "rx". +- dma-names: must include "tx" and/or "rx". - clocks: a list of phandle + clock-specifer pairs, one for each entry in clock-names. - clock-names: should contain followings: - "apb" : clock for the I2S bus interface - "mod" : module clock for the I2S controller - #sound-dai-cells : Must be equal to 0 -Example: +Optional properties: + +- interrupts: I2S interrupt +- resets: phandle to the reset of the device + +Required nodes: + + - port: link to the associated CODEC (DAC, HDMI...) + +Example 1: i2s0: i2s@01c22400 { #sound-dai-cells = <0>; @@ -32,3 +42,21 @@ i2s0: i2s@01c22400 { < SUN4I_DMA_NORMAL 3>; dma-names = "rx", "tx"; }; + +Example 2: + +i2s2: i2s@1c22800 { + compatible = "allwinner,sun8i-a83t-i2s"; + reg = <0x01c22800 0x60>; + clocks = < CLK_BUS_I2S2>, < CLK_I2S2>; + clock-names = "apb", "mod"; + resets = < RST_I2S2>; + dmas = < 27>; + dma-names = "tx"; + status = "disabled"; + port { + i2s2_hdmi: endpoint { + remote-endpoint = <_i2s2>; + }; + }; +}; diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig index dd23682..d89b2da 100644 --- a/sound/soc/sunxi/Kconfig +++ b/sound/soc/sunxi/Kconfig @@ -26,4 +26,12 @@ config SND_SUN4I_SPDIF help Say Y or M to add support for the S/PDIF audio block in the Allwinner A10 and affiliated SoCs. + +config SND_SUN8I_I2S + tristate "Allwinner sun8i I2S Support" + depends on OF + select SND_SOC_GENERIC_DMAENGINE_PCM + help + Say Y or M if you want to add support for SoC audio on + Allwinner sun8i boards. endmenu diff --git a/sound/soc/sunxi/Makefile b/sound/soc/sunxi/Makefile index 604c7b84..bcb871b 100644 --- a/sound/soc/sunxi/Makefile +++ b/sound/soc/sunxi/Makefile @@ -1,3 +1,6 @@ obj-$(CONFIG_SND_SUN4I_CODEC) += sun4i-codec.o obj-$(CONFIG_SND_SUN4I_I2S) += sun4i-i2s.o obj-$(CONFIG_SND_SUN4I_SPDIF) += sun4i-spdif.o + +snd-soc-sun8i-i2s-objs := sun8i-i2s.o +obj-$(CONFIG_SND_SUN8I_I2S) += snd-soc-sun8i-i2s.o diff --git a/sound/soc/sunxi/sun8i-i2s.c b/sound/soc/sunxi/sun8i-i2s.c new file mode 100644 index 000..ba15d62 --- /dev/null +++ b/sound/soc/sunxi/sun8i-i2s.c @@ -0,0 +1,700 @@ +/* + * Allwinner sun8i I2S sound card + * + * Copyright (C) 2016 Jean-Francois Moine + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* --- hardware --- */ + +#define I2S_CTL0x00 + /* common */ + #define I2S_CTL_SDO3EN BIT(11) + #define I2S_CTL_SDO2EN BIT(10) + #define I2S_CTL_SDO1EN BIT(9) + #define I2S_CTL_SDO0EN BIT(8) + #define I2S_CTL_TXENBIT(2) + #define I2S_CTL_RXENBIT(1) + #define I2S_CTL_GEN BIT(0) + /* a83t */ + #define I2S_CTL_A83T_MS BIT(5) + #define