[linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
Hi, i am just doing something with this board. For my understand, support for the AP6212 BT modules is not implemented in the DT. I am missing the 32k clock output. Maybe, support for rfkill is missing as well. May I ask you, help me adding this? Maik Am Mittwoch, 1. November 2017 10:39:09 UTC+1 schrieb Icenowy Zheng: > > Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form > factor and GPIO holes similar to Raspberry Pi Zero. > > It features: > - Allwinner H2+ SoC > - Single-chip (16-bit) 512MiB DDR3 DRAM > - Ampak AP6212 Wi-Fi/Bluetooth module > - MicroSD slot > - Two MicroUSB Type-B ports (one can only be used to power the board and > the other features OTG functionality) > - Two keys, a reset and a GPIO-connected key. > - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+. > - CSI connector to connect the camera sensor provided by Sinovoip. > > Signed-off-by: Icenowy Zheng > > --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 156 > + > 2 files changed, 157 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 3a5b79fd8198..803dbdf03916 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -930,6 +930,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > sun8i-a83t-bananapi-m3.dtb \ > sun8i-a83t-cubietruck-plus.dtb \ > sun8i-a83t-tbs-a711.dtb \ > +sun8i-h2-plus-bananapi-m2-zero.dtb \ > sun8i-h2-plus-orangepi-zero.dtb \ > sun8i-h3-bananapi-m2-plus.dtb \ > sun8i-h3-beelink-x2.dtb \ > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > new file mode 100644 > index ..414258da4308 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > @@ -0,0 +1,156 @@ > +/* > + * Copyright (C) 2017 Icenowy Zheng > > + * > + * Based on sun8i-h3-bananapi-m2-plus.dts, which is: > + * Copyright (C) 2016 Chen-Yu Tsai > > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun8i-h3.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > +model = "Banana Pi BPI-M2-Zero"; > +compatible = "sinovoip,bpi-m2-zero", "allwinner,sun8i-h2-plus"; > + > +aliases { > +serial0 = > +serial1 = > +}; > + > +chosen { > +stdout-path = "serial0:115200n8"; > +}; > + > +leds { > +compatible = "gpio-leds"; > +pinctrl-names = "default"; > + > +pwr_led { > +label = "bananapi-m2-zero:red:pwr"; > +gpios =
[linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
lol , very helpfull ! Em quarta-feira, 1 de novembro de 2017 07:39:09 UTC-2, Icenowy Zheng escreveu: > > Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form > factor and GPIO holes similar to Raspberry Pi Zero. > > It features: > - Allwinner H2+ SoC > - Single-chip (16-bit) 512MiB DDR3 DRAM > - Ampak AP6212 Wi-Fi/Bluetooth module > - MicroSD slot > - Two MicroUSB Type-B ports (one can only be used to power the board and > the other features OTG functionality) > - Two keys, a reset and a GPIO-connected key. > - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+. > - CSI connector to connect the camera sensor provided by Sinovoip. > > Signed-off-by: Icenowy Zheng> --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 156 > + > 2 files changed, 157 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 3a5b79fd8198..803dbdf03916 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -930,6 +930,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > sun8i-a83t-bananapi-m3.dtb \ > sun8i-a83t-cubietruck-plus.dtb \ > sun8i-a83t-tbs-a711.dtb \ > +sun8i-h2-plus-bananapi-m2-zero.dtb \ > sun8i-h2-plus-orangepi-zero.dtb \ > sun8i-h3-bananapi-m2-plus.dtb \ > sun8i-h3-beelink-x2.dtb \ > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > new file mode 100644 > index ..414258da4308 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > @@ -0,0 +1,156 @@ > +/* > + * Copyright (C) 2017 Icenowy Zheng > + * > + * Based on sun8i-h3-bananapi-m2-plus.dts, which is: > + * Copyright (C) 2016 Chen-Yu Tsai > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun8i-h3.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > +model = "Banana Pi BPI-M2-Zero"; > +compatible = "sinovoip,bpi-m2-zero", "allwinner,sun8i-h2-plus"; > + > +aliases { > +serial0 = > +serial1 = > +}; > + > +chosen { > +stdout-path = "serial0:115200n8"; > +}; > + > +leds { > +compatible = "gpio-leds"; > +pinctrl-names = "default"; > + > +pwr_led { > +label = "bananapi-m2-zero:red:pwr"; > +gpios = <_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 > */ > +default-state = "on"; > +}; > +}; > + > +gpio_keys { > +
Re: [linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
Hi, On Fri, Nov 03, 2017 at 07:53:17AM +0800, Icenowy Zheng wrote: > 在 2017-11-02 23:50,Maxime Ripard 写道: > > On Thu, Nov 02, 2017 at 05:07:30PM +0800, Icenowy Zheng wrote: > > > > > + { > > > > > + pinctrl-names = "default"; > > > > > + pinctrl-0 = <_pins_a>; > > > > > + vmmc-supply = <_vcc3v3>; > > > > > + bus-width = <4>; > > > > > + /* > > > > > + * In different revisions the board have different card detect > > > > > + * configuration. > > > > > + */ > > > > > > > > Which ones? > > > > > > In the sample batch (1.2V fixed voltage) the card detect is normal > > > (PF6 low as inserted), however in the final batch (1.1V/1.3V > > > switchable) it's inverted at PF6 (high as inserted). > > > > Then just use the final version's. > > > > > > > + { > > > > > + usb0_id_det-gpios = <_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > > > > > + /* USB OTG VBUS is directly connected to 5V without any > > > > > regulators > > > > > */ > > > > > > > > So it cannot operate in OTG, but it's host only? > > > > > > It can operate in OTG -- you can power the board via the OTG port, > > > as the VBUS is not gated from 5V at all, so 5V power at VBUS will > > > power up the board. Yes, it's a bit unsafe, but the board designer > > > did it. > > > > What will provide the 5v in the first place then if a USB device is > > connected to the micro-USB connector? > > There're two micro-USB connectors, one is power-only and another is > OTG. The Vbus of these two connectors are connected together, so > the external USB device will be powered just by the power input > from the power-only USB port. Can you put that in the comment? Thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
On Thu, Nov 02, 2017 at 05:07:30PM +0800, Icenowy Zheng wrote: > > > + { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <_pins_a>; > > > + vmmc-supply = <_vcc3v3>; > > > + bus-width = <4>; > > > + /* > > > + * In different revisions the board have different card detect > > > + * configuration. > > > + */ > > > > Which ones? > > In the sample batch (1.2V fixed voltage) the card detect is normal > (PF6 low as inserted), however in the final batch (1.1V/1.3V > switchable) it's inverted at PF6 (high as inserted). Then just use the final version's. > > > + { > > > + usb0_id_det-gpios = <_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > > > + /* USB OTG VBUS is directly connected to 5V without any regulators > > > */ > > > > So it cannot operate in OTG, but it's host only? > > It can operate in OTG -- you can power the board via the OTG port, > as the VBUS is not gated from 5V at all, so 5V power at VBUS will > power up the board. Yes, it's a bit unsafe, but the board designer > did it. What will provide the 5v in the first place then if a USB device is connected to the micro-USB connector? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
在 2017-11-02 17:02,Maxime Ripard 写道: Hi, On Wed, Nov 01, 2017 at 05:38:14PM +0800, Icenowy Zheng wrote: Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form factor and GPIO holes similar to Raspberry Pi Zero. It features: - Allwinner H2+ SoC - Single-chip (16-bit) 512MiB DDR3 DRAM - Ampak AP6212 Wi-Fi/Bluetooth module - MicroSD slot - Two MicroUSB Type-B ports (one can only be used to power the board and the other features OTG functionality) - Two keys, a reset and a GPIO-connected key. - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+. - CSI connector to connect the camera sensor provided by Sinovoip. Signed-off-by: Icenowy Zheng--- arch/arm/boot/dts/Makefile | 1 + .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 156 + 2 files changed, 157 insertions(+) create mode 100644 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 3a5b79fd8198..803dbdf03916 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -930,6 +930,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ sun8i-a83t-bananapi-m3.dtb \ sun8i-a83t-cubietruck-plus.dtb \ sun8i-a83t-tbs-a711.dtb \ + sun8i-h2-plus-bananapi-m2-zero.dtb \ sun8i-h2-plus-orangepi-zero.dtb \ sun8i-h3-bananapi-m2-plus.dtb \ sun8i-h3-beelink-x2.dtb \ diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts new file mode 100644 index ..414258da4308 --- /dev/null +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts @@ -0,0 +1,156 @@ +/* + * Copyright (C) 2017 Icenowy Zheng + * + * Based on sun8i-h3-bananapi-m2-plus.dts, which is: + * Copyright (C) 2016 Chen-Yu Tsai + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; +#include "sun8i-h3.dtsi" +#include "sunxi-common-regulators.dtsi" + +#include +#include + +/ { + model = "Banana Pi BPI-M2-Zero"; + compatible = "sinovoip,bpi-m2-zero", "allwinner,sun8i-h2-plus"; + + aliases { + serial0 = + serial1 = + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; This property is useless + + pwr_led { + label = "bananapi-m2-zero:red:pwr"; + gpios = <_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */ + default-state = "on"; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + pinctrl-names = "default"; Same thing here. + + sw4 { That node should be called power. + label = "power"; + linux,code = ; + gpios = <_pio 0 3 GPIO_ACTIVE_LOW>; + }; + }; + +
[linux-sunxi] Re: [PATCH] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board
Hi, On Wed, Nov 01, 2017 at 05:38:14PM +0800, Icenowy Zheng wrote: > Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form > factor and GPIO holes similar to Raspberry Pi Zero. > > It features: > - Allwinner H2+ SoC > - Single-chip (16-bit) 512MiB DDR3 DRAM > - Ampak AP6212 Wi-Fi/Bluetooth module > - MicroSD slot > - Two MicroUSB Type-B ports (one can only be used to power the board and > the other features OTG functionality) > - Two keys, a reset and a GPIO-connected key. > - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+. > - CSI connector to connect the camera sensor provided by Sinovoip. > > Signed-off-by: Icenowy Zheng> --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 156 > + > 2 files changed, 157 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 3a5b79fd8198..803dbdf03916 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -930,6 +930,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > sun8i-a83t-bananapi-m3.dtb \ > sun8i-a83t-cubietruck-plus.dtb \ > sun8i-a83t-tbs-a711.dtb \ > + sun8i-h2-plus-bananapi-m2-zero.dtb \ > sun8i-h2-plus-orangepi-zero.dtb \ > sun8i-h3-bananapi-m2-plus.dtb \ > sun8i-h3-beelink-x2.dtb \ > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > new file mode 100644 > index ..414258da4308 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts > @@ -0,0 +1,156 @@ > +/* > + * Copyright (C) 2017 Icenowy Zheng > + * > + * Based on sun8i-h3-bananapi-m2-plus.dts, which is: > + * Copyright (C) 2016 Chen-Yu Tsai > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun8i-h3.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > + model = "Banana Pi BPI-M2-Zero"; > + compatible = "sinovoip,bpi-m2-zero", "allwinner,sun8i-h2-plus"; > + > + aliases { > + serial0 = > + serial1 = > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; This property is useless > + > + pwr_led { > + label = "bananapi-m2-zero:red:pwr"; > + gpios = <_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */ > + default-state = "on"; > + }; > + }; > + > + gpio_keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; Same thing here. > + > + sw4 { That node should be called power. > + label = "power"; > +