Re: [linux-sunxi] Re: [PATCH 20/21] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

[Icenowy Zheng]

2017年2月17日 16:55于 Corentin Labbe 写道：
>
> On Thu, Feb 16, 2017 at 08:08:27PM +0100, Maxime Ripard wrote: 
> > Hi, 
> > 
> > On Thu, Feb 16, 2017 at 01:48:58PM +0100, Corentin Labbe wrote: 
> > > From: LABBE Corentin  
> > > 
> > > Enable the dwmac-sun8i driver in the sunxi default configuration 
> > > 
> > > Signed-off-by: Corentin Labbe  
> > > --- 
> > >  arch/arm/configs/sunxi_defconfig | 1 + 
> > >  1 file changed, 1 insertion(+) 
> > > 
> > > diff --git a/arch/arm/configs/sunxi_defconfig 
> > > b/arch/arm/configs/sunxi_defconfig 
> > > index da92c25..33bde86 100644 
> > > --- a/arch/arm/configs/sunxi_defconfig 
> > > +++ b/arch/arm/configs/sunxi_defconfig 
> > > @@ -40,6 +40,7 @@ CONFIG_ATA=y 
> > >  CONFIG_AHCI_SUNXI=y 
> > >  CONFIG_NETDEVICES=y 
> > >  CONFIG_SUN4I_EMAC=y 
> > > +CONFIG_DWMAC_SUN8I=m 
> > 
> > I think I'd prefer to have it compiled statically, just like the other 
> > net drivers, and drivers in general. 
> > 
> > Thanks! 
> > Maxime 
> > 
>
> In previous sun8i-emac, someone request that CONFIG must be set as module 
> because kernel went too big. 
> But I do not care to set it statically. 

This is sunxi_defconfig, not multi_v7_config.

I remember the complain is for multi_v7_config.

For multi_v7_config it's proper to make it =m.

>
> Regards 
> Corentin Labbe 
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group. 
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com. 
> For more options, visit https://groups.google.com/d/optout. 

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] Re: [PATCH 20/21] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

[Corentin Labbe]

On Thu, Feb 16, 2017 at 08:08:27PM +0100, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Feb 16, 2017 at 01:48:58PM +0100, Corentin Labbe wrote:
> > From: LABBE Corentin 
> > 
> > Enable the dwmac-sun8i driver in the sunxi default configuration
> > 
> > Signed-off-by: Corentin Labbe 
> > ---
> >  arch/arm/configs/sunxi_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/configs/sunxi_defconfig 
> > b/arch/arm/configs/sunxi_defconfig
> > index da92c25..33bde86 100644
> > --- a/arch/arm/configs/sunxi_defconfig
> > +++ b/arch/arm/configs/sunxi_defconfig
> > @@ -40,6 +40,7 @@ CONFIG_ATA=y
> >  CONFIG_AHCI_SUNXI=y
> >  CONFIG_NETDEVICES=y
> >  CONFIG_SUN4I_EMAC=y
> > +CONFIG_DWMAC_SUN8I=m
> 
> I think I'd prefer to have it compiled statically, just like the other
> net drivers, and drivers in general.
> 
> Thanks!
> Maxime
> 

In previous sun8i-emac, someone request that CONFIG must be set as module 
because kernel went too big.
But I do not care to set it statically.

Regards
Corentin Labbe

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] Re: [PATCH 20/21] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

[Maxime Ripard]

Hi,

On Thu, Feb 16, 2017 at 01:48:58PM +0100, Corentin Labbe wrote:
> From: LABBE Corentin 
> 
> Enable the dwmac-sun8i driver in the sunxi default configuration
> 
> Signed-off-by: Corentin Labbe 
> ---
>  arch/arm/configs/sunxi_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/sunxi_defconfig 
> b/arch/arm/configs/sunxi_defconfig
> index da92c25..33bde86 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -40,6 +40,7 @@ CONFIG_ATA=y
>  CONFIG_AHCI_SUNXI=y
>  CONFIG_NETDEVICES=y
>  CONFIG_SUN4I_EMAC=y
> +CONFIG_DWMAC_SUN8I=m

I think I'd prefer to have it compiled statically, just like the other
net drivers, and drivers in general.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature