Re: [PATCH] tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir()

[Mukesh Ojha]

On 10/20/2023 7:22 PM, Dan Carpenter wrote:

The eventfs_create_dir() function returns error pointers, it never returns
NULL.  Update the check to reflect that.

Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Signed-off-by: Dan Carpenter 


LGTM, Thanks.

Reviewed-by: Mukesh Ojha 

-Mukesh


---
  kernel/trace/trace_events.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index db46d2116500..f9e3e24d8796 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2354,7 +2354,7 @@ event_subsystem_dir(struct trace_array *tr, const char 
*name,
nr_entries = ARRAY_SIZE(system_entries);
  
  	ei = eventfs_create_dir(name, parent, system_entries, nr_entries, dir);

-   if (!ei) {
+   if (IS_ERR(ei)) {
pr_warn("Failed to create system directory %s\n", name);
__put_system(system);
goto out_free;

[PATCH] tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir()

[Dan Carpenter]

The eventfs_create_dir() function returns error pointers, it never returns
NULL.  Update the check to reflect that.

Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Signed-off-by: Dan Carpenter 
---
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index db46d2116500..f9e3e24d8796 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2354,7 +2354,7 @@ event_subsystem_dir(struct trace_array *tr, const char 
*name,
nr_entries = ARRAY_SIZE(system_entries);
 
ei = eventfs_create_dir(name, parent, system_entries, nr_entries, dir);
-   if (!ei) {
+   if (IS_ERR(ei)) {
pr_warn("Failed to create system directory %s\n", name);
__put_system(system);
goto out_free;
-- 
2.42.0