Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296

[Greg KH]

On Sun, Nov 19, 2017 at 08:40:28PM +0100, ssjoh...@mac.com wrote:
> From: ssjoholm 
> 
> Signed-off-by: ssjoholm 

This goes at the bottom of the changelog text.

And we need a real name, I doubt you use this to sign legal documents.

> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M 
> and NB-IoT. Tested hardware is BG96 mounted on Quectel development board 
> (EVB). The USB id is added to option.c to allow DIAG,GPS,AT and modem 
> communication with the BG96.

Please also line-wrap your text at 72 columns, like your editor is
asking you to :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

[Bjørn Mork]

On November 20, 2017 5:19:21 AM GMT+01:00, ssjoh...@mac.com wrote:
>From: ssjoholm 
>
>Signed-off-by: ssjoholm 
>
>Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both
>CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel
>development board (EVB).
>The USB id is added to qmi_wwan.c to allow QMI communication with the
>BG96.
>---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>index 720a3a248070..c750cf7c042b 100644
>--- a/drivers/net/usb/qmi_wwan.c
>+++ b/drivers/net/usb/qmi_wwan.c
>@@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
>   {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)},/* SIMCom 7230E */
>   {QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0 
>Mini PCIe */
>   {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
>+  {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},/* Quectel BG96 */
> 
>   /* 4. Gobi 1000 devices */
>   {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},/* Acer Gobi Modem Device */

Patch looks fine. But you need to use your full name in the tags. 
See the part about identity;
https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

And the SOB and other tags go after the rest of the commit message. Your SOB 
should always be the last line. 



Bjørn 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] USB: option: add Quectel BG96 2c7c:0296

[ssjoholm]

From: ssjoholm 

Signed-off-by: ssjoholm 

Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and 
NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The 
USB id is added to option.c to allow DIAG,GPS,AT and modem communication with 
the BG96.
---
 drivers/usb/serial/option.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index aaa7d901a06d..3b3513874cfd 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb);
 /* These Quectel products use Quectel's vendor ID */
 #define QUECTEL_PRODUCT_EC21   0x0121
 #define QUECTEL_PRODUCT_EC25   0x0125
+#define QUECTEL_PRODUCT_BG96   0x0296
 
 #define CMOTECH_VENDOR_ID  0x16d8
 #define CMOTECH_PRODUCT_6001   0x6001
@@ -1182,6 +1183,8 @@ static const struct usb_device_id option_ids[] = {
  .driver_info = (kernel_ulong_t)_intf4_blacklist },
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
  .driver_info = (kernel_ulong_t)_intf4_blacklist },
+   { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
+ .driver_info = (kernel_ulong_t)_intf4_blacklist },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
-- 
2.11.0 (Apple Git-81)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

[ssjoholm]

From: ssjoholm 

Signed-off-by: ssjoholm 

Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and 
NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB).
The USB id is added to qmi_wwan.c to allow QMI communication with the BG96.
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 720a3a248070..c750cf7c042b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1239,6 +1239,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x1e0e, 0x9001, 5)},/* SIMCom 7230E */
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0125, 4)}, /* Quectel EC25, EC20 R2.0  
Mini PCIe */
{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
+   {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},/* Quectel BG96 */
 
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},/* Acer Gobi Modem Device */
-- 
2.11.0 (Apple Git-81)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296

[Sebastian Sjoholm]

Hi All,

Sorry about the patch below, it is not valid, seems that I need to improve my 
GIT competence. 

Please ignore this, and let me try again.

Thank You.

Regards,
Sebastian

> On Nov 19, 2017, at 18:28 , ssjoholm  wrote:
> 
> Signed-off-by: ssjoholm 
> 
> Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M 
> and NB-IoT. Tested hardware is BG96 mounted on Quectel development board 
> (EVB).
> 
> The USB id is added to option.c to allow DIAG,GPS,AT and modem communication 
> with the BG96.
> ---
> drivers/usb/serial/option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index f757e0d2eaf4..3b3513874cfd 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1183,8 +1183,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = (kernel_ulong_t)_intf4_blacklist },
>   { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
> .driver_info = (kernel_ulong_t)_intf4_blacklist },
> -{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
> -  .driver_info = (kernel_ulong_t)_intf4_blacklist },
> + { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
> +   .driver_info = (kernel_ulong_t)_intf4_blacklist },
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
>   { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
> -- 
> 2.11.0 (Apple Git-81)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html