Re: [PATCH] USB: cp210x: add ID for RUGGEDCOM USB Serial Console
On Mon, Jan 26, 2015 at 01:40:34PM +0100, Johan Hovold wrote:
> On Wed, Jan 21, 2015 at 03:24:27PM -0500, Lennart Sorensen wrote:
> > Added the USB serial console device ID for Siemens Ruggedcom devices
> > which have a USB port for their serial console.
> >
> > Signed-off-by: Len Sorensen
> > ---
> > drivers/usb/serial/cp210x.c |1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> > index f4c56fc..f34e6ba 100644
> > --- a/drivers/usb/serial/cp210x.c
> > +++ b/drivers/usb/serial/cp210x.c
> > @@ -55,6 +55,7 @@ static const struct usb_device_id id_table[] = {
> > { USB_DEVICE(0x0745, 0x1000) }, /* CipherLab USB CCD Barcode Scanner
> > 1000 */
> > { USB_DEVICE(0x0846, 0x1100) }, /* NetGear Managed Switch M4100 series,
> > M5300 series, M7100 series */
> > { USB_DEVICE(0x08e6, 0x5501) }, /* Gemalto Prox-PU/CU contactless
> > smartcard reader */
> > + { USB_DEVICE(0x0908, 0x01FF) }, /* RUGGEDCOM USB Serial Console */
> > { USB_DEVICE(0x08FD, 0x000A) }, /* Digianswer A/S , ZigBee/802.15.4 MAC
> > Device */
>
> Please try to keep the entries sorted by VID/PID. I fixed it up here and
> applied.
Oh crap, I thought I did. How ever did I mess that up? Sorry about that.
--
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] USB: cp210x: add ID for RUGGEDCOM USB Serial Console
Added the USB serial console device ID for Siemens Ruggedcom devices
which have a USB port for their serial console.
Signed-off-by: Len Sorensen
---
drivers/usb/serial/cp210x.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f4c56fc..f34e6ba 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -55,6 +55,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x0745, 0x1000) }, /* CipherLab USB CCD Barcode Scanner
1000 */
{ USB_DEVICE(0x0846, 0x1100) }, /* NetGear Managed Switch M4100 series,
M5300 series, M7100 series */
{ USB_DEVICE(0x08e6, 0x5501) }, /* Gemalto Prox-PU/CU contactless
smartcard reader */
+ { USB_DEVICE(0x0908, 0x01FF) }, /* RUGGEDCOM USB Serial Console */
{ USB_DEVICE(0x08FD, 0x000A) }, /* Digianswer A/S , ZigBee/802.15.4 MAC
Device */
{ USB_DEVICE(0x0BED, 0x1100) }, /* MEI (TM) Cashflow-SC Bill/Voucher
Acceptor */
{ USB_DEVICE(0x0BED, 0x1101) }, /* MEI series 2000 Combo Acceptor */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] USB: sierra: memory-leak fixes for v3.7
On Wed, Oct 24, 2012 at 07:24:15PM +0200, Johan Hovold wrote:
> This is an updated series of fixes rebased on the interface-data memory leak
> discovered by Lennart.
>
> One of the reasons that I missed it was that the interface data was allocated
> in probe rather than attach, which in itself is a bug as the memory would not
> get released if usb-serial probe failes before attach returns successfully.
> The
> third patch fixes this.
>
> I also split out the fix for the port-data memory leak in the error path of
> attach that was part of my previous patch. This way the first three patches
> can
> be backported to most (all?) stable trees, whereas the last patch applies to
> v3.6 (which contains the (in)famous 0998d063100 ("device-core: Ensure drvdata
> = NULL when no driver is bound" commit).
>
> I included Lennart's patch with an updated commit message for completeness.
>
> Lennart, if you care to test this series before it is applied that would be
> much appreciated.
I backported 1, 2 and 3 for the 3.0.23 kernel I am running, and so far it
looks to be working. I think our USB HCD driver may have a leak still,
but someone else is investigating that right now. At least the sierra
driver appears to have stopped leaking.
--
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fix memory leak in sierra_release() (this time with signed-off-by)
On Wed, Oct 24, 2012 at 04:56:44PM +0200, Johan Hovold wrote: > Good catch! I missed this one when I fixed a bunch of other memory > leaks in the sierra with recent kernels: > > http://marc.info/?l=linux-usb&m=135100550421848&w=2 > > I'll rebase my patch on top of this one as your patch should be > backported to all stable kernels, whereas mine is only required for > v3.6 and later. Oh that looks useful. I was trying to track down if there were more leaks in the driver. I just fixed the one that was most obvious to me. -- Len Sorensen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Fix memory leak in sierra_release() (this time with signed-off-by)
I found a memory leak in sierra_release() (well sierra_probe() I guess) that looses 8 bytes each time the driver releases a device. Signed-off-by: Len Sorensen diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 01d882c..76ef95b 100644 --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c @@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial) continue; kfree(portdata); } + kfree(serial->private); } #ifdef CONFIG_PM -- Len Sorensen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
