Re: [PATCH v4 0/6] power: add power sequence library
El 2016-08-02 05:30, Peter Chen escribió: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement generic power sequence on library. The host driver can allocate power sequence instance, and calls pwrseq APIs accordingly. In future, if there are special power sequence requirements, the special power sequence library can be created. This patch set is tested on i.mx6 sabresx evk using a dts change, I use two hot-plug devices to simulate this use case, the related binding change is updated at patch [1/6], The udoo board changes were tested using my last power sequence patch set.[3] Except for hard-wired MMC and USB devices, I find the USB ULPI PHY also need to power on itself before it can be found by ULPI bus. [1] http://www.spinics.net/lists/linux-usb/msg142755.html [2] http://www.spinics.net/lists/linux-usb/msg143106.html [3] http://www.spinics.net/lists/linux-usb/msg142815.html Changes for v4: - Create the patch on next-20160722 - Fix the of_node is not NULL after chipidea driver is unbinded [Patch 5/6] - Using more friendly wait method for reset gpio [Patch 2/6] - Support multiple input clocks [Patch 2/6] - Add Rob Herring's ack for DT changes - Add Joshua Clayton's Tested-by Changes for v3: - Delete "power-sequence" property at binding-doc, and change related code at both library and user code. - Change binding-doc example node name with Rob's comments - of_get_named_gpio_flags only gets the gpio, but without setting gpio flags, add additional code request gpio with proper gpio flags - Add Philipp Zabel's Ack and MAINTAINER's entry Changes for v2: - Delete "pwrseq" prefix and clock-names for properties at dt binding - Should use structure not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequence library binding-doc: usb: usb-device: add optional properties for power sequence usb: core: add power sequence handling for USB devices usb: chipidea: let chipidea core device of_node equal's glue layer device of_node ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Hi Peter, I tried the last version on my udoo board but I got these compile errors: [21330s] ERROR: "pwrseq_get" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_free" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_put" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_off" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_on" [drivers/usb/core/usbcore.ko] undefined! Will you do another version? Thanks! -- Oscar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: common: otg-fsm: add license to usb-otg-fsm
El 2016-06-14 08:26, Peter Chen escribió:
On Mon, Jun 13, 2016 at 06:56:30PM +0200, Oscar wrote:
Fix warning about tainted kernel because usb-otg-fsm has no license.
WARNING: with this patch usb-otg-fsm module can be loaded
but then the kernel will hang. Tested with a udoo quad board.
Signed-off-by: Oscar Curero <os...@naiandei.net>
---
drivers/usb/common/usb-otg-fsm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/common/usb-otg-fsm.c
b/drivers/usb/common/usb-otg-fsm.c
index 9059b7d..2f537bb 100644
--- a/drivers/usb/common/usb-otg-fsm.c
+++ b/drivers/usb/common/usb-otg-fsm.c
@@ -21,6 +21,7 @@
* 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#include
#include
#include
#include
@@ -450,3 +451,4 @@ int otg_statemachine(struct otg_fsm *fsm)
return fsm->state_changed;
}
EXPORT_SYMBOL_GPL(otg_statemachine);
+MODULE_LICENSE("GPL");
--
I don't know why I can't apply your patch, does it make on
an very old version?
I apply it manually, thanks.
Hi Peter,
Thanks for applying my first patch to linux! :)
As I said on the commit message, although I can load ci_hdrc_imx just
fine, it doesn't work because as soon as it's loaded, the kernel hangs
without any error or message at all.
This happens on my udoo quad board (imx6q). Of course, if I blacklist
the ci_hdrc_imx module (appending modprobe.blacklist=ci_hdrc_imx as boot
parm) I can login the system, but no usb devices are found. Alexander
Graf from Suse said that this sounds like a clock problem.
Let me know how can I help you to resolve the problem.
Cheers,
--
Oscar
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: common: otg-fsm: add license to usb-otg-fsm
Fix warning about tainted kernel because usb-otg-fsm has no license.
WARNING: with this patch usb-otg-fsm module can be loaded
but then the kernel will hang. Tested with a udoo quad board.
Signed-off-by: Oscar Curero <os...@naiandei.net>
---
drivers/usb/common/usb-otg-fsm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/common/usb-otg-fsm.c
b/drivers/usb/common/usb-otg-fsm.c
index 9059b7d..2f537bb 100644
--- a/drivers/usb/common/usb-otg-fsm.c
+++ b/drivers/usb/common/usb-otg-fsm.c
@@ -21,6 +21,7 @@
* 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#include
#include
#include
#include
@@ -450,3 +451,4 @@ int otg_statemachine(struct otg_fsm *fsm)
return fsm->state_changed;
}
EXPORT_SYMBOL_GPL(otg_statemachine);
+MODULE_LICENSE("GPL");
--
2.8.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
usb: common: otg-fsm: add license to usb-otg-fsm
usb: common: otg-fsm: add license to usb-otg-fsm.
Fix warning about tainted kernel because usb-otg-fsm has no license.
WARNING: with this patch usb-otg-fsm module can be loaded
but then the kernel hangs. Tested with a udoo quad board.
Signed-off-by: Oscar Curero <os...@naiandei.net>
---
--- a/drivers/usb/common/usb-otg-fsm.c.orig 2016-06-12
12:02:09.269814317 +0200
+++ b/drivers/usb/common/usb-otg-fsm.c 2016-06-12 12:01:54.473000410
+0200
@@ -21,6 +21,7 @@
* 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#include
#include
#include
#include
@@ -452,3 +453,4 @@ int otg_statemachine(struct otg_fsm *fsm
return state_changed;
}
EXPORT_SYMBOL_GPL(otg_statemachine);
+MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
