Re: [PATCH] USB: OHCI: Allow runtime PM without system sleep

[Greg KH]

On Mon, Aug 26, 2013 at 03:01:40PM -0400, Alan Stern wrote:
 Since ohci-hcd supports runtime PM, the .pm field in its pci_driver
 structure should be protected by CONFIG_PM rather than
 CONFIG_PM_SLEEP.
 
 Without this change, OHCI controllers won't do runtime suspend if
 system suspend or hibernation isn't enabled.
 
 Signed-off-by: Alan Stern st...@rowland.harvard.edu
 cc: sta...@vger.kernel.org
 
 ---
 
 Greg:
 
 I marked this for -stable because it fixes a bug.  But the bug is a 
 benign one (under some configs, OHCI controllers won't go to low power 
 at times when they could) and nobody has complained about it.  You can 
 decide whether or not this is really suitable for the stable kernels.

Thanks, this seems like it would be good for stable kernels, so I left
it in.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] USB: OHCI: Allow runtime PM without system sleep

[Alan Stern]

Since ohci-hcd supports runtime PM, the .pm field in its pci_driver
structure should be protected by CONFIG_PM rather than
CONFIG_PM_SLEEP.

Without this change, OHCI controllers won't do runtime suspend if
system suspend or hibernation isn't enabled.

Signed-off-by: Alan Stern st...@rowland.harvard.edu
cc: sta...@vger.kernel.org

---

Greg:

I marked this for -stable because it fixes a bug.  But the bug is a 
benign one (under some configs, OHCI controllers won't go to low power 
at times when they could) and nobody has complained about it.  You can 
decide whether or not this is really suitable for the stable kernels.


[as1703]


 drivers/usb/host/ohci-pci.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: usb-3.11/drivers/usb/host/ohci-pci.c
===
--- usb-3.11.orig/drivers/usb/host/ohci-pci.c
+++ usb-3.11/drivers/usb/host/ohci-pci.c
@@ -289,7 +289,7 @@ static struct pci_driver ohci_pci_driver
.remove =   usb_hcd_pci_remove,
.shutdown = usb_hcd_pci_shutdown,
 
-#ifdef CONFIG_PM_SLEEP
+#ifdef CONFIG_PM
.driver =   {
.pm =   usb_hcd_pci_pm_ops
},

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html