Re: [PATCH] asix: do not free array priv->mdio->irq
From: Colin King Date: Thu, 3 Mar 2016 13:27:56 + > From: Colin Ian King > > Used to be allocated and required freeing, but now > priv->mdio->irq is now a fixed sized array and should no longer be > free'd. > > Issue detected using static analysis with CoverityScan > > Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") > Signed-off-by: Colin Ian King Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] asix: do not free array priv->mdio->irq
On Thu, Mar 03, 2016 at 01:27:56PM +, Colin King wrote: > From: Colin Ian King > > Used to be allocated and required freeing, but now > priv->mdio->irq is now a fixed sized array and should no longer be > free'd. > > Issue detected using static analysis with CoverityScan > > Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Thanks Andrew > --- > drivers/net/usb/ax88172a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c > index 224e7d8..cf77f2d 100644 > --- a/drivers/net/usb/ax88172a.c > +++ b/drivers/net/usb/ax88172a.c > @@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev) > > netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id); > mdiobus_unregister(priv->mdio); > - kfree(priv->mdio->irq); > mdiobus_free(priv->mdio); > } > > -- > 2.7.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] asix: do not free array priv->mdio->irq
From: Colin Ian King Used to be allocated and required freeing, but now priv->mdio->irq is now a fixed sized array and should no longer be free'd. Issue detected using static analysis with CoverityScan Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") Signed-off-by: Colin Ian King --- drivers/net/usb/ax88172a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c index 224e7d8..cf77f2d 100644 --- a/drivers/net/usb/ax88172a.c +++ b/drivers/net/usb/ax88172a.c @@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev) netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id); mdiobus_unregister(priv->mdio); - kfree(priv->mdio->irq); mdiobus_free(priv->mdio); } -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html