RE: [PATCH] staging: pl2303: adding TD620 Device ID

2017-09-20 Thread Schoon, Michael 
Thanks for the feedback.  I'll review and resubmit.

-Original Message-
From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
Sent: Wednesday, September 20, 2017 2:47 AM
To: Schoon, Michael <michael.sch...@hp.com>
Cc: jo...@kernel.org; linux-usb@vger.kernel.org; Greg Kroah-Hartman 
<gre...@linuxfoundation.org>
Subject: Re: [PATCH] staging: pl2303: adding TD620 Device ID

On Wed, Sep 20, 2017 at 08:15:38AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 19, 2017 at 09:41:48PM +, Schoon, Michael wrote:
> > Signed-off-by: Michael Schoon <michael.sch...@hp.com>
> 
> No changelog at all?  I know I can't take patches like that, hopefully 
> Johan has the same rule :)

Indeed, I do.

Please also fix up the Subject; this driver does not live in staging so that 
should be "USB: serial: pl2303:" instead.

Also try to keep any new id-defines you add sorted by PID.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: pl2303: adding TD620 Device ID

2017-09-20 Thread Johan Hovold 
On Wed, Sep 20, 2017 at 08:15:38AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 19, 2017 at 09:41:48PM +, Schoon, Michael wrote:
> > Signed-off-by: Michael Schoon 
> 
> No changelog at all?  I know I can't take patches like that, hopefully
> Johan has the same rule :)

Indeed, I do.

Please also fix up the Subject; this driver does not live in staging so
that should be "USB: serial: pl2303:" instead.

Also try to keep any new id-defines you add sorted by PID.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: pl2303: adding TD620 Device ID

2017-09-20 Thread gre...@linuxfoundation.org 
On Tue, Sep 19, 2017 at 09:41:48PM +, Schoon, Michael wrote:
> Signed-off-by: Michael Schoon 

No changelog at all?  I know I can't take patches like that, hopefully
Johan has the same rule :)

> ---
>  drivers/usb/serial/pl2303.c | 1 +
>  drivers/usb/serial/pl2303.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index a585b47..eab0e55 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -94,6 +94,7 @@ static const struct usb_device_id id_table[] = {
>  { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
>  { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
>  { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
> +   { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
>  { USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
>  { USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
>  { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },

Your patch has had the tabs turned into spaces, making this impossible
to apply.  Try testing it out first by emailing it to yourself.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] staging: pl2303: adding TD620 Device ID

2017-09-19 Thread Schoon, Michael 
Signed-off-by: Michael Schoon 
---
 drivers/usb/serial/pl2303.c | 1 +
 drivers/usb/serial/pl2303.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index a585b47..eab0e55 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -94,6 +94,7 @@ static const struct usb_device_id id_table[] = {
 { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
 { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
 { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
+   { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
 { USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
 { USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
 { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index 3b5a15d..ca0bfba 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -126,6 +126,7 @@
 #define HP_LCM220_PRODUCT_ID    0x3139
 #define HP_LCM960_PRODUCT_ID    0x3239
 #define HP_LD220_PRODUCT_ID 0x3524
+#define HP_TD620_PRODUCT_ID    0x0956
 
 /* Cressi Edy (diving computer) PC interface */
 #define CRESSI_VENDOR_ID    0x04b8
-- 
2.7.4

 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html