[PATCH] staging: usbip: Fix build on Debian ppc
From: Tobias Polzer tobias.pol...@fau.de One missing include was added. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de --- drivers/staging/usbip/userspace/src/usbip_network.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/usbip/userspace/src/usbip_network.c b/drivers/staging/usbip/userspace/src/usbip_network.c index f5955c2..799a68f 100644 --- a/drivers/staging/usbip/userspace/src/usbip_network.c +++ b/drivers/staging/usbip/userspace/src/usbip_network.c @@ -31,6 +31,10 @@ #include gnutls/gnutls.h #endif +#ifdef HAVE_LIBWRAP +#include tcpd.h +#endif + #include usbip_common.h #include usbip_network.h -- 1.8.4 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: usbip: Fix build on Debian ppc
On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote:
When testing usbip under powerpc, it (unexpectedly) worked, but only after
removing the following lines from vhch_hcd.c:
1004 /* will be removed */
1005 if (pdev-dev.dma_mask) {
1006 dev_info(pdev-dev, vhci_hcd DMA not supported\n);
1007 return -EINVAL;
1008 }
We encountered no problems without those lines. Is it safe to remove this
check?
Hehe. No.
Also which vhch_hcd.c are you talking about? find -name vhch_hcd.c
doesn't show anything.
What the error message?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: usbip: Fix build on Debian ppc
On September 19, 2013 at 3:40 PM Dominik Paulus domi...@d-paulus.de wrote:
On Thu, Sep 19, 2013 at 12:12:44PM +0300, Dan Carpenter wrote:
On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote:
When testing usbip under powerpc, it (unexpectedly) worked, but only after
removing the following lines from vhch_hcd.c:
1004 /* will be removed */
1005 if (pdev-dev.dma_mask) {
1006 dev_info(pdev-dev, vhci_hcd DMA not supported\n);
1007 return -EINVAL;
1008 }
We encountered no problems without those lines. Is it safe to remove this
check?
Hehe. No.
Also which vhch_hcd.c are you talking about? find -name vhch_hcd.c
doesn't show anything.
Sorry for the typo, we meant vhci_hcd.c in
drivers/staging/usbip/vhci_hcd.c.
What the error message?
When modprobing vhci_hcd.ko, vhci_hcd_probe() fails and returns -EINVAL,
resulting in this error message:
[ 592.623292] vhci_hcd vhci_hcd: vhci_hcd DMA not supported
[ 592.624031] vhci_hcd: probe of vhci_hcd failed with error -22
This leads to the virtual host controller device (vhci) not being
created, so usbip cannot work.
It works after removing the codeblock mentioned above.
We did some research and discovered that dma_mask is only set on PowerPC
at the moment (in arch/powerpc/kernel/setup-common.c,
arch_setup_pdev_archdata()).
All of our testing was done in QEMU emulating Debian on POWER7.
I have already submitted a patch to remove mentioned code block.
patch link : https://lkml.org/lkml/2013/9/10/26
regards,
--navin-patidar
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: usbip: Fix build on Debian ppc
Ah, ok. I had no idea what you were talking about before. I thought you were talking about build errors in a file that didn't exist... (Because the subject says build and there was a typo in the file name). Navin, says you can remove it. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
