Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On 10/03/2015 at 16:23:53 -0500, Felipe Balbi wrote : > > Yeah, let's drop it for now but I have the feeling that this will > > break (I actually broke it when switching at91 to multiplatform). > > aha, that changes it. So you already have something which makes this > break ? Are you planning on sending that upstream any time soon ? > It has been sent but not merge and I need to send another version. > We could very well use that same series to merge this patch. Only when > it's needed ;-) > Like said, this is not an issue for now, I fixed it by simply having all the AT91 platform selecting COMMON_CLK_AT91. I just have the feeling that this is not quite future proof. So this is not urgent at all and I'll try to remember to resend when needed. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On Tue, Mar 10, 2015 at 10:41:09PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 16:23:53 -0500, Felipe Balbi wrote : > > > Yeah, let's drop it for now but I have the feeling that this will > > > break (I actually broke it when switching at91 to multiplatform). > > > > aha, that changes it. So you already have something which makes this > > break ? Are you planning on sending that upstream any time soon ? > > > > It has been sent but not merge and I need to send another version. > > > We could very well use that same series to merge this patch. Only when > > it's needed ;-) > > > > Like said, this is not an issue for now, I fixed it by simply having all > the AT91 platform selecting COMMON_CLK_AT91. I just have the feeling > that this is not quite future proof. > So this is not urgent at all and I'll try to remember to resend when > needed. fair enough :-) cheers -- balbi signature.asc Description: Digital signature
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > > config USB_ATMEL_USBA > > > > > tristate "Atmel USBA" > > > > > - depends on AVR32 || ARCH_AT91 > > > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > > > > > > I guess you should add parenthesis to make it clearer ? > > > > > > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > > > > > > > And I wonder why you need that. I though this option was selected by all > > > > at91 platforms ? > > > > > > > > > > That is currently the case but maybe, one day, one of the AT91 platform > > > will not use the same clock driver. > > > > then, maybe, one day, you send this patch. > > Yeah, let's drop it for now but I have the feeling that this will > break (I actually broke it when switching at91 to multiplatform). aha, that changes it. So you already have something which makes this break ? Are you planning on sending that upstream any time soon ? We could very well use that same series to merge this patch. Only when it's needed ;-) cheers -- balbi signature.asc Description: Digital signature
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > config USB_ATMEL_USBA > > > > tristate "Atmel USBA" > > > > - depends on AVR32 || ARCH_AT91 > > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > > > > I guess you should add parenthesis to make it clearer ? > > > > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > > > > > And I wonder why you need that. I though this option was selected by all > > > at91 platforms ? > > > > > > > That is currently the case but maybe, one day, one of the AT91 platform > > will not use the same clock driver. > > then, maybe, one day, you send this patch. Yeah, let's drop it for now but I have the feeling that this will break (I actually broke it when switching at91 to multiplatform). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > config USB_ATMEL_USBA > > > tristate "Atmel USBA" > > > - depends on AVR32 || ARCH_AT91 > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > > I guess you should add parenthesis to make it clearer ? > > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > > > And I wonder why you need that. I though this option was selected by all > > at91 platforms ? > > > > That is currently the case but maybe, one day, one of the AT91 platform > will not use the same clock driver. then, maybe, one day, you send this patch. -- balbi signature.asc Description: Digital signature
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > config USB_ATMEL_USBA > > tristate "Atmel USBA" > > - depends on AVR32 || ARCH_AT91 > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > I guess you should add parenthesis to make it clearer ? > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > And I wonder why you need that. I though this option was selected by all > at91 platforms ? > That is currently the case but maybe, one day, one of the AT91 platform will not use the same clock driver. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
Hi Alexandre, On Tue, 3 Mar 2015 08:42:47 +0100 Alexandre Belloni wrote: > Since the addition of the errata handling for at91sam9rl and at91sam9g45, the > atmel_usba_udc depends on the pmc driver being present. Explicitly set that > dependency. > > Signed-off-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig > index 9a3a6b00391a..b04206fdba11 100644 > --- a/drivers/usb/gadget/udc/Kconfig > +++ b/drivers/usb/gadget/udc/Kconfig > @@ -55,7 +55,7 @@ config USB_LPC32XX > > config USB_ATMEL_USBA > tristate "Atmel USBA" > - depends on AVR32 || ARCH_AT91 > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 I guess you should add parenthesis to make it clearer ? depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) And I wonder why you need that. I though this option was selected by all at91 platforms ? Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
Since the addition of the errata handling for at91sam9rl and at91sam9g45, the atmel_usba_udc depends on the pmc driver being present. Explicitly set that dependency. Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 9a3a6b00391a..b04206fdba11 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -55,7 +55,7 @@ config USB_LPC32XX config USB_ATMEL_USBA tristate "Atmel USBA" - depends on AVR32 || ARCH_AT91 + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 help USBA is the integrated high-speed USB Device controller on the AT32AP700x, some AT91SAM9 and AT91CAP9 processors from Atmel. -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
