Re: [PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-15 Thread santosh shilimkar 

Felipe,

On 7/15/2015 2:56 PM, Murali Karicheri wrote:

On 07/02/2015 06:34 PM, Felipe Balbi wrote:

commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface
property") introduced a possible NULL pointer
dereference because dwc->hsphy_interface can be
NULL.

In order to fix it, all we have to do is guard
strncmp() against a NULL argument.

Fixes: 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property")
Tested-by: Murali Karicheri 
Signed-off-by: Felipe Balbi 
---
  drivers/usb/dwc3/core.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 5c110d8e293b..ff5773c66b84 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -446,10 +446,12 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
  /* Select the HS PHY interface */
  switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
  case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
-if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
+if (dwc->hsphy_interface &&
+!strncmp(dwc->hsphy_interface, "utmi", 4)) {
  reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
  break;
-} else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
+} else if (dwc->hsphy_interface &&
+!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
  reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
  dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
  } else {


Dear Maintainer,

This is patch is urgently required to be applied to master for v4.2 for
fixing a crash seen on keystone based boards (K2HK, K2L and K2E EVMs).
Please merge it asap.


I assume you are you sending this one for rc's ?
Feel free to use my ack if you need one.
Acked-by: Santosh Shilimkar 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-15 Thread Murali Karicheri 

On 07/02/2015 06:34 PM, Felipe Balbi wrote:

commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface
property") introduced a possible NULL pointer
dereference because dwc->hsphy_interface can be
NULL.

In order to fix it, all we have to do is guard
strncmp() against a NULL argument.

Fixes: 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property")
Tested-by: Murali Karicheri 
Signed-off-by: Felipe Balbi 
---
  drivers/usb/dwc3/core.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 5c110d8e293b..ff5773c66b84 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -446,10 +446,12 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
/* Select the HS PHY interface */
switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
-   if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
+   if (dwc->hsphy_interface &&
+   !strncmp(dwc->hsphy_interface, "utmi", 4)) {
reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
break;
-   } else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
+   } else if (dwc->hsphy_interface &&
+   !strncmp(dwc->hsphy_interface, "ulpi", 4)) {
reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
} else {


Dear Maintainer,

This is patch is urgently required to be applied to master for v4.2 for 
fixing a crash seen on keystone based boards (K2HK, K2L and K2E EVMs). 
Please merge it asap.


--
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-02 Thread Felipe Balbi 
commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface
property") introduced a possible NULL pointer
dereference because dwc->hsphy_interface can be
NULL.

In order to fix it, all we have to do is guard
strncmp() against a NULL argument.

Fixes: 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property")
Tested-by: Murali Karicheri 
Signed-off-by: Felipe Balbi 
---
 drivers/usb/dwc3/core.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 5c110d8e293b..ff5773c66b84 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -446,10 +446,12 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
/* Select the HS PHY interface */
switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
-   if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
+   if (dwc->hsphy_interface &&
+   !strncmp(dwc->hsphy_interface, "utmi", 4)) {
reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
break;
-   } else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
+   } else if (dwc->hsphy_interface &&
+   !strncmp(dwc->hsphy_interface, "ulpi", 4)) {
reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
} else {
-- 
2.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html