[PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()
After commit 4814030ce11f08350b7, (usb: initialize hcd->state roothubs) the core now sets hcd->state = HC_STATE_RUNNING in usb_add_hcd() before the driver's start() method is called. So, we can safely remove this line from dummy_start() since it is now superfluous. Signed-off-by: Pantelis Koukousoulas --- drivers/usb/gadget/dummy_hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index ffd5af0..3a2e649 100644 --- a/drivers/usb/gadget/dummy_hcd.c +++ b/drivers/usb/gadget/dummy_hcd.c @@ -2345,7 +2345,6 @@ static int dummy_start(struct usb_hcd *hcd) INIT_LIST_HEAD(&dum_hcd->urbp_list); hcd->power_budget = POWER_BUDGET; - hcd->state = HC_STATE_RUNNING; hcd->uses_new_polling = 1; #ifdef CONFIG_USB_OTG -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()
Hello. On 06/05/2014 10:55 PM, Pantelis Koukousoulas wrote: After commit 4814030ce11f08350b7, the core now sets Please also specify that commit's summary line in parens. Is this in order to be able to grep it more easily? I 'm asking because It's actually the only way to uniquely identify the commit as the SHA1 IDs can coincide for the different commits. that summary (Initialize hcd->state roothubs) doesn't seem to add much to the rationale otherwise. It's anyway a lot more info about the commit's nature than just a bare SHA1 ID. Unfortunately with switching from gitweb to cgit you can't jump to a commit clicking on its SHA1 ID anymore when browsing a git repo... Cheers, Pantelis WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()
On Thu, Jun 5, 2014 at 9:13 PM, Sergei Shtylyov wrote: >> After commit 4814030ce11f08350b7, the core now sets > >Please also specify that commit's summary line in parens. Is this in order to be able to grep it more easily? I 'm asking because that summary (Initialize hcd->state roothubs) doesn't seem to add much to the rationale otherwise. I have no problem to do this of course, just asking for future reference. Cheers, Pantelis -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()
Hello. On 06/05/2014 07:44 PM, Pantelis Koukousoulas wrote: After commit 4814030ce11f08350b7, the core now sets Please also specify that commit's summary line in parens. hcd->state = HC_STATE_RUNNING in usb_add_hcd() before the driver's start() method is called. So, we can safely remove this line from dummy_start() since it is now superfluous. Signed-off-by: Pantelis Koukousoulas WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: gadget: dummy_hcd: remove superfluous setting HC_STATE_RUNNING in dummy_start()
After commit 4814030ce11f08350b7, the core now sets hcd->state = HC_STATE_RUNNING in usb_add_hcd() before the driver's start() method is called. So, we can safely remove this line from dummy_start() since it is now superfluous. Signed-off-by: Pantelis Koukousoulas --- drivers/usb/gadget/dummy_hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index ffd5af0..3a2e649 100644 --- a/drivers/usb/gadget/dummy_hcd.c +++ b/drivers/usb/gadget/dummy_hcd.c @@ -2345,7 +2345,6 @@ static int dummy_start(struct usb_hcd *hcd) INIT_LIST_HEAD(&dum_hcd->urbp_list); hcd->power_budget = POWER_BUDGET; - hcd->state = HC_STATE_RUNNING; hcd->uses_new_polling = 1; #ifdef CONFIG_USB_OTG -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
