Re: [PATCH] usb: gadget: remove redundant self assignment
On 04/17/2017 05:12 AM, Stefan Agner wrote: The assignment ret = ret is redundant and can be removed. Signed-off-by: Stefan Agner--- A very similar patch has been applied already last year, but there is a second such assignment... -- Stefan drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index d685d82dcf48..b57bd53812fe 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out; ret = ep->ops->disable(ep); - if (ret) { - ret = ret; + if (ret) goto out; - } ep->enabled = false; Reviewed-by: Krzysztof Opasiak -- Krzysztof Opasiak Samsung R Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: gadget: remove redundant self assignment
On Sun, Apr 16, 2017 at 08:12:50PM -0700, Stefan Agner wrote: > The assignment ret = ret is redundant and can be removed. > > Signed-off-by: Stefan Agner> --- > A very similar patch has been applied already last year, but there is > a second such assignment... > > -- > Stefan > > drivers/usb/gadget/udc/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index d685d82dcf48..b57bd53812fe 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) > goto out; > > ret = ep->ops->disable(ep); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = false; > Reviewed-by: Peter Chen -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: gadget: remove redundant self assignment
The assignment ret = ret is redundant and can be removed. Signed-off-by: Stefan Agner--- A very similar patch has been applied already last year, but there is a second such assignment... -- Stefan drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index d685d82dcf48..b57bd53812fe 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out; ret = ep->ops->disable(ep); - if (ret) { - ret = ret; + if (ret) goto out; - } ep->enabled = false; -- 2.12.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: gadget: remove redundant self assignment
On Mon, Jul 25, 2016 at 10:57:36PM +0100, Colin King wrote: > From: Colin Ian King> > The assignment ret = ret is redundant and can be removed. > > Signed-off-by: Colin Ian King > --- > drivers/usb/gadget/udc/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index ff8685e..48cf1a3 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep) > goto out; > > ret = ep->ops->enable(ep, ep->desc); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = true; > Reviewed-by: Peter Chen -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: gadget: remove redundant self assignment
From: Colin Ian KingThe assignment ret = ret is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index ff8685e..48cf1a3 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep) goto out; ret = ep->ops->enable(ep, ep->desc); - if (ret) { - ret = ret; + if (ret) goto out; - } ep->enabled = true; -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html