Re: [PATCH] usb: gadget: udc: bdc: Use dma_pool_zalloc

2018-03-06 Thread Souptick Joarder
Any comment for this patch.

On Wed, Feb 14, 2018 at 11:59 PM, Souptick Joarder  wrote:
> Use dma_pool_zalloc instead of dma_pool_alloc + memset
>
> Signed-off-by: Souptick Joarder 
> ---
>  drivers/usb/gadget/udc/bdc/bdc_ep.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c 
> b/drivers/usb/gadget/udc/bdc/bdc_ep.c
> index f40d4c1..03149b9d 100644
> --- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
> +++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
> @@ -151,7 +151,7 @@ static int ep_bd_list_alloc(struct bdc_ep *ep)
> if (!bd_table)
> goto fail;
>
> -   bd_table->start_bd = dma_pool_alloc(bdc->bd_table_pool,
> +   bd_table->start_bd = dma_pool_zalloc(bdc->bd_table_pool,
> GFP_ATOMIC,
> &dma);
> if (!bd_table->start_bd) {
> @@ -167,7 +167,6 @@ static int ep_bd_list_alloc(struct bdc_ep *ep)
> (unsigned long long)bd_table->dma, prev_table);
>
> ep->bd_list.bd_table_array[index] = bd_table;
> -   memset(bd_table->start_bd, 0, bd_p_tab * sizeof(struct 
> bdc_bd));
> if (prev_table)
> chain_table(prev_table, bd_table, bd_p_tab);
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] usb: gadget: udc: bdc: Use dma_pool_zalloc

2018-02-14 Thread Souptick Joarder
Use dma_pool_zalloc instead of dma_pool_alloc + memset

Signed-off-by: Souptick Joarder 
---
 drivers/usb/gadget/udc/bdc/bdc_ep.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c 
b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index f40d4c1..03149b9d 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -151,7 +151,7 @@ static int ep_bd_list_alloc(struct bdc_ep *ep)
if (!bd_table)
goto fail;

-   bd_table->start_bd = dma_pool_alloc(bdc->bd_table_pool,
+   bd_table->start_bd = dma_pool_zalloc(bdc->bd_table_pool,
GFP_ATOMIC,
&dma);
if (!bd_table->start_bd) {
@@ -167,7 +167,6 @@ static int ep_bd_list_alloc(struct bdc_ep *ep)
(unsigned long long)bd_table->dma, prev_table);

ep->bd_list.bd_table_array[index] = bd_table;
-   memset(bd_table->start_bd, 0, bd_p_tab * sizeof(struct bdc_bd));
if (prev_table)
chain_table(prev_table, bd_table, bd_p_tab);

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html