Re: [PATCH] usb: host: fix incorrect updating of offset

[Alan Stern]

On Tue, 7 Nov 2017, Colin King wrote:

> From: Colin Ian King 
> 
> The variable temp is incorrectly being updated, instead it should
> be offset otherwise the loop just reads the same capability value
> and loops forever.  Thanks to Alan Stern for pointing out the
> correct fix to my original fix.  Fix also cleans up clang warning:
> 
> drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
> is never read
> 
> Fixes: d49d43174400 ("USB: misc ehci updates")
> Signed-off-by: Colin Ian King 
> ---
>  drivers/usb/host/ehci-dbg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
> index 7fb21d01b3d0..3bd0b2273171 100644
> --- a/drivers/usb/host/ehci-dbg.c
> +++ b/drivers/usb/host/ehci-dbg.c
> @@ -838,7 +838,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer 
> *buf)
>   default:/* unknown */
>   break;
>   }
> - temp = (cap >> 8) & 0xff;
> + offset = (cap >> 8) & 0xff;
>   }
>   }
>  #endif

Acked-by: Alan Stern 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: host: fix incorrect updating of offset

[Colin King]

From: Colin Ian King 

The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever.  Thanks to Alan Stern for pointing out the
correct fix to my original fix.  Fix also cleans up clang warning:

drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
is never read

Fixes: d49d43174400 ("USB: misc ehci updates")
Signed-off-by: Colin Ian King 
---
 drivers/usb/host/ehci-dbg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 7fb21d01b3d0..3bd0b2273171 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -838,7 +838,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer 
*buf)
default:/* unknown */
break;
}
-   temp = (cap >> 8) & 0xff;
+   offset = (cap >> 8) & 0xff;
}
}
 #endif
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html