Re: [PATCH] usb: host: replace symbolic permission with octal

[gre...@linuxfoundation.org]

On Wed, Nov 30, 2016 at 01:49:02PM +, Amit Kumar Kushwaha wrote:
> This patch handles warning message for preferring octal
> permissions over Symbolic permission for module parameter

That makes no sense at all.  What warning message?  Build time?  Run
time?

Please do cleanup patches on drivers/staging/ until you know how to do
them, don't start on the "core" kernel, as you will just annoy
maintainers (hint, you cc:ed too many people...)

good luck!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: host: replace symbolic permission with octal

[Amit Kumar Kushwaha]

This patch handles warning message for preferring octal
permissions over Symbolic permission for module parameter

Signed-off-by: Amit Kushwaha 
---
 drivers/usb/host/xhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1a4ca02..a953d47 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -40,11 +40,11 @@
 
 /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
 static int link_quirk;
-module_param(link_quirk, int, S_IRUGO | S_IWUSR);
+module_param(link_quirk, int, 0644);
 MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB");
 
 static unsigned int quirks;
-module_param(quirks, uint, S_IRUGO);
+module_param(quirks, uint, 0444);
 MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
 
 /* TODO: copied from ehci-hcd.c - can this be refactored? */
-- 
2.10.2.windows.1