Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper
On Thu, Oct 05, 2017 at 01:12:01PM +0300, Mathias Nyman wrote: > On 05.10.2017 12:19, Simon Horman wrote: > >On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > >>Use the of_device_get_match_data() helper instead of open coding. > >> > >>Signed-off-by: Geert Uytterhoeven> > > >Reviewed-by: Simon Horman > > > > > > Thanks, I already applied and sent forward before this new reviewed-by tag Thanks, sorry for not noticing that. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper
Hi, > From: Geert Uytterhoeven, Sent: Wednesday, October 4, 2017 9:25 PM > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert UytterhoevenThank you for the patch! Reviewed-by: Yoshihiro Shimoda But, it seems too late about this Reviewed-by though... https://marc.info/?l=linux-usb=150719811907415=2 Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper
On 05.10.2017 12:19, Simon Horman wrote: On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: Use the of_device_get_match_data() helper instead of open coding. Signed-off-by: Geert UytterhoevenReviewed-by: Simon Horman Thanks, I already applied and sent forward before this new reviewed-by tag -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper
On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert UytterhoevenReviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper
Use the of_device_get_match_data() helper instead of open coding. Signed-off-by: Geert Uytterhoeven--- drivers/usb/host/xhci-plat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 163bafde709f79bf..a1b42348e0c8c6c8 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -152,7 +153,7 @@ MODULE_DEVICE_TABLE(of, usb_xhci_of_match); static int xhci_plat_probe(struct platform_device *pdev) { - const struct of_device_id *match; + const struct xhci_plat_priv *priv_match; const struct hc_driver *driver; struct device *sysdev; struct xhci_hcd *xhci; @@ -238,9 +239,8 @@ static int xhci_plat_probe(struct platform_device *pdev) } xhci = hcd_to_xhci(hcd); - match = of_match_node(usb_xhci_of_match, pdev->dev.of_node); - if (match) { - const struct xhci_plat_priv *priv_match = match->data; + priv_match = of_device_get_match_data(>dev); + if (priv_match) { struct xhci_plat_priv *priv = hcd_to_xhci_priv(hcd); /* Just copy data for now */ -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html