Re: [PATCH] usb: hub: no error logs in case of enomem

[gre...@linuxfoundation.org]

On Wed, Nov 30, 2016 at 02:32:07PM +, Atul Raj wrote:
> All kmalloc-based functions print enough information on failures.
> 
> Signed-off-by: Atul Raj 
> ---
>  drivers/usb/core/hub.c | 1 -
>  1 file changed, 1 deletion(-)

I told you to wait, relax, and work on drivers/staging/ instead.

Sorry, I'm not going to take this as obviously you are not following
directions very well and are now wasting other people's time for no good
reason.

best of luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: hub: no error logs in case of enomem

[Atul Raj]

All kmalloc-based functions print enough information on failures.

Signed-off-by: Atul Raj 
---
 drivers/usb/core/hub.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index cbb1467..82059f26 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -817,7 +817,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
 */
clear = kmalloc(sizeof *clear, GFP_ATOMIC);
if (clear == NULL) {
-   dev_err(>dev, "can't save CLEAR_TT_BUFFER state\n");
/* FIXME recover somehow ... RESET_TT? */
return -ENOMEM;
}
--
2.10.2.windows.1