Re: [PATCH] usb: ohci: nxp: clean up included header files

[Alan Stern]

On Tue, 8 Dec 2015, Vladimir Zapolskiy wrote:

> Remove mach/irq.h from the list of included headers, there is no
> compilation dependency on this include file, the change is needed
> to prevent a compilation failure, when mach/irq.h is removed.
> 
> Additionally remove other unneeded includes.
> 
> Signed-off-by: Vladimir Zapolskiy 
> ---
>  drivers/usb/host/ohci-nxp.c | 7 ---
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index cfa9427..ebacf97 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -22,7 +22,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -32,13 +31,7 @@
>  
>  #include "ohci.h"
>  
> -
>  #include 
> -#include 
> -#include 
> -
> -#include 
> -#include 
>  
>  #define USB_CONFIG_BASE  0x3102
>  #define PWRMAN_BASE  0x40004000

If this still builds correctly, it's okay with me.  I have no way to 
test it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: ohci: nxp: clean up included header files

[Vladimir Zapolskiy]

On 08.12.2015 17:30, Alan Stern wrote:
> On Tue, 8 Dec 2015, Vladimir Zapolskiy wrote:
> 
>> Remove mach/irq.h from the list of included headers, there is no
>> compilation dependency on this include file, the change is needed
>> to prevent a compilation failure, when mach/irq.h is removed.
>>
>> Additionally remove other unneeded includes.
>>
>> Signed-off-by: Vladimir Zapolskiy 
>> ---
>>  drivers/usb/host/ohci-nxp.c | 7 ---
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
>> index cfa9427..ebacf97 100644
>> --- a/drivers/usb/host/ohci-nxp.c
>> +++ b/drivers/usb/host/ohci-nxp.c
>> @@ -22,7 +22,6 @@
>>  #include 
>>  #include 
>>  #include 
>> -#include 
>>  #include 
>>  #include 
>>  #include 
>> @@ -32,13 +31,7 @@
>>  
>>  #include "ohci.h"
>>  
>> -
>>  #include 
>> -#include 
>> -#include 
>> -
>> -#include 
>> -#include 
>>  
>>  #define USB_CONFIG_BASE 0x3102
>>  #define PWRMAN_BASE 0x40004000
> 
> If this still builds correctly, it's okay with me.  I have no way to 
> test it.

Thanks for review.

If you have an ARMv5 toolchain, then you can test building with
lpc32xx_defconfig:

make ARCH=arm CROSS_COMPILE=${CCPREFIX} lpc32xx_defconfig
make ARCH=arm CROSS_COMPILE=${CCPREFIX} drivers/usb/host/ohci-nxp.o

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: ohci: nxp: clean up included header files

[Vladimir Zapolskiy]

Remove mach/irq.h from the list of included headers, there is no
compilation dependency on this include file, the change is needed
to prevent a compilation failure, when mach/irq.h is removed.

Additionally remove other unneeded includes.

Signed-off-by: Vladimir Zapolskiy 
---
 drivers/usb/host/ohci-nxp.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index cfa9427..ebacf97 100644
--- a/drivers/usb/host/ohci-nxp.c
+++ b/drivers/usb/host/ohci-nxp.c
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -32,13 +31,7 @@
 
 #include "ohci.h"
 
-
 #include 
-#include 
-#include 
-
-#include 
-#include 
 
 #define USB_CONFIG_BASE0x3102
 #define PWRMAN_BASE0x40004000
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html