Re: [PATCH] usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driveer

2015-12-06 Thread Simon Horman
On Fri, Dec 04, 2015 at 05:04:25PM +0100, Geert Uytterhoeven wrote:
> As of commit 3d7608e4c169af03 ("ARM: shmobile: bockw: remove legacy
> board file and config"), the Renesas R-Car (Gen1) USB PHY driver is no
> longer used.
> In theory it could still be used on R-Car Gen1 SoCs, but that would
> require adding DT support to the driver. Instead, a new driver using the
> generic PHY framework should be written, as was done for R-Car Gen2.
> 
> Remove the driver for good.
> 
> Signed-off-by: Geert Uytterhoeven 

There is a typo in the subject, but that aside:

Acked-by: Simon Horman 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driveer

2015-12-04 Thread Geert Uytterhoeven
As of commit 3d7608e4c169af03 ("ARM: shmobile: bockw: remove legacy
board file and config"), the Renesas R-Car (Gen1) USB PHY driver is no
longer used.
In theory it could still be used on R-Car Gen1 SoCs, but that would
require adding DT support to the driver. Instead, a new driver using the
generic PHY framework should be written, as was done for R-Car Gen2.

Remove the driver for good.

Signed-off-by: Geert Uytterhoeven 
---
 drivers/usb/phy/Kconfig|  13 --
 drivers/usb/phy/Makefile   |   1 -
 drivers/usb/phy/phy-rcar-usb.c | 247 -
 include/linux/platform_data/usb-rcar-phy.h |  28 
 4 files changed, 289 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-rcar-usb.c
 delete mode 100644 include/linux/platform_data/usb-rcar-phy.h

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 22e8ecb6bfbd2822..155694c1a5366215 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -186,19 +186,6 @@ config USB_MXS_PHY
 
  MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.
 
-config USB_RCAR_PHY
-   tristate "Renesas R-Car USB PHY support"
-   depends on USB || USB_GADGET
-   depends on ARCH_R8A7778 || ARCH_R8A7779 || COMPILE_TEST
-   select USB_PHY
-   help
- Say Y here to add support for the Renesas R-Car USB common PHY driver.
- This chip is typically used as USB PHY for USB host, gadget.
- This driver supports R8A7778 and R8A7779.
-
- To compile this driver as a module, choose M here: the
- module will be called phy-rcar-usb.
-
 config USB_ULPI
bool "Generic ULPI Transceiver Driver"
depends on ARM || ARM64
diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
index 19c0dccbb1161b11..b433e5d89be4bdda 100644
--- a/drivers/usb/phy/Makefile
+++ b/drivers/usb/phy/Makefile
@@ -23,7 +23,6 @@ obj-$(CONFIG_USB_MSM_OTG) += phy-msm-usb.o
 obj-$(CONFIG_USB_QCOM_8X16_PHY)+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)   += phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)  += phy-mxs-usb.o
-obj-$(CONFIG_USB_RCAR_PHY) += phy-rcar-usb.o
 obj-$(CONFIG_USB_ULPI) += phy-ulpi.o
 obj-$(CONFIG_USB_ULPI_VIEWPORT)+= phy-ulpi-viewport.o
 obj-$(CONFIG_KEYSTONE_USB_PHY) += phy-keystone.o
diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rcar-usb.c
deleted file mode 100644
index 1e09b83778853829..
--- a/drivers/usb/phy/phy-rcar-usb.c
+++ /dev/null
@@ -1,247 +0,0 @@
-/*
- * Renesas R-Car USB phy driver
- *
- * Copyright (C) 2012-2013 Renesas Solutions Corp.
- * Kuninori Morimoto 
- * Copyright (C) 2013 Cogent Embedded, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-/* REGS block */
-#define USBPCTRL0  0x00
-#define USBPCTRL1  0x04
-#define USBST  0x08
-#define USBEH0 0x0C
-#define USBOH0 0x1C
-#define USBCTL00x58
-
-/* High-speed signal quality characteristic control registers (R8A7778 only) */
-#define HSQCTL10x24
-#define HSQCTL20x28
-
-/* USBPCTRL0 */
-#define OVC2   (1 << 10) /* (R8A7779 only) */
-   /* Switches the OVC input pin for port 2: */
-   /* 1: USB_OVC2, 0: OVC2 */
-#define OVC1_VBUS1 (1 << 9) /* Switches the OVC input pin for port 1: */
-   /* 1: USB_OVC1, 0: OVC1/VBUS1   */
-   /* Function mode: set to 0  */
-#define OVC0   (1 << 8) /* Switches the OVC input pin for port 0: */
-   /* 1: USB_OVC0 pin, 0: OVC0 */
-#define OVC2_ACT   (1 << 6) /* (R8A7779 only)  */
-   /* Host mode: OVC2 polarity:*/
-   /* 1: active-high, 0: active-low*/
-#define PENC   (1 << 4) /* Function mode: output level of PENC1 pin: */
-   /* 1: high, 0: low  */
-#define OVC0_ACT   (1 << 3) /* Host mode: OVC0 polarity:   */
-   /* 1: active-high, 0: active-low*/
-#define OVC1_ACT   (1 << 1) /* Host mode: OVC1 polarity:   */
-   /* 1: active-high, 0: active-low*/
-   /* Function mode: be sure to set to 1   */
-#define PORT1  (1 << 0) /* Selects port 1 mode:*/
-   /* 1: function, 0: host