Re: [PATCH] usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

[Heikki Krogerus]

On Wed, Oct 11, 2017 at 10:09:57AM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> Calls to regmap_read may fail with an -EINVAL return without setting
> usbc_irq1 and usbc_irq2.  The error handling clean up expects these
> to have been set (or zero on a failure) and currently may try to
> clear the wrong IRQs if the uninitalized garbage values in usbc_irq1
> or usbc_irq2 are non-zero.  The simplest fix is to ensure these
> variables are initialized to zero.
> 
> Detected by CoverityScan, CID#1457737 ("Uninitialized scalar variable")
> 
> Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support")
> Signed-off-by: Colin Ian King 

Acked-by: Heikki Krogerus 


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

[Colin King]

From: Colin Ian King 

Calls to regmap_read may fail with an -EINVAL return without setting
usbc_irq1 and usbc_irq2.  The error handling clean up expects these
to have been set (or zero on a failure) and currently may try to
clear the wrong IRQs if the uninitalized garbage values in usbc_irq1
or usbc_irq2 are non-zero.  The simplest fix is to ensure these
variables are initialized to zero.

Detected by CoverityScan, CID#1457737 ("Uninitialized scalar variable")

Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support")
Signed-off-by: Colin Ian King 
---
 drivers/usb/typec/typec_wcove.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/typec_wcove.c b/drivers/usb/typec/typec_wcove.c
index a47a93ad34b7..4ce30a967962 100644
--- a/drivers/usb/typec/typec_wcove.c
+++ b/drivers/usb/typec/typec_wcove.c
@@ -441,8 +441,8 @@ static int wcove_read_rx_buffer(struct wcove_typec *wcove, 
void *msg)
 static irqreturn_t wcove_typec_irq(int irq, void *data)
 {
struct wcove_typec *wcove = data;
-   unsigned int usbc_irq1;
-   unsigned int usbc_irq2;
+   unsigned int usbc_irq1 = 0;
+   unsigned int usbc_irq2 = 0;
unsigned int cc1ctrl;
int ret;
 
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html