Re: [PATCH 0/5] USB: ftdi_sio: wMaxPacketSize patches
On Thu, Jun 05, 2014 at 06:04:32PM +0200, Johan Hovold wrote:
> On Thu, Jun 05, 2014 at 08:30:42AM -0700, Greg KH wrote:
> > On Thu, Jun 05, 2014 at 04:05:51PM +0200, Johan Hovold wrote:
> > > Some FTDI devices have broken endpoint descriptors that needs to be
> > > fixed up during probe. Mike Remski discovered that the current
> > > implementation is broken as it crashes the kernel if an interface
> > > without endpoints is probed.
> > >
> > > These patches fix this bug, while cleaning up the max-packet-size
> > > handling and removing a redundant probe quirk that fixes up mtxorb
> > > devices.
> >
> > Looks good, but did you forget to cc: me as well so that I know to pick
> > these up? Or are you going to send a pull request later on with them?
>
> Yes, that was my intention. None of these are really critical and could
> wait for v3.17-rc1, although I'll probably send you the first for
> v3.16-rc2.
>
> As we discussed briefly off-list, I intend to maintain a usb-next and
> usb-linus branch in my USB-serial tree on kernel.org, while posting my
> own patches to linux-usb for review before applying them (I can still CC
> you as well of course).
>
> Perhaps I should start using a "usb-serial:" prefix to make it easier to
> discern what I intend to apply myself from any non-USB-serial patches I
> might be sending you? Or the diff-stat would be sufficient
> ("drivers/usb/serial/*") for that?
No need, I'll just know now that if I see you send patches out, and
don't cc: me, I'll assume you will later be sending them to me through a
git tree or somewhere else. Same as I currently do for Peter and
Felipe, no problem.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] USB: ftdi_sio: wMaxPacketSize patches
On Thu, Jun 05, 2014 at 08:30:42AM -0700, Greg KH wrote:
> On Thu, Jun 05, 2014 at 04:05:51PM +0200, Johan Hovold wrote:
> > Some FTDI devices have broken endpoint descriptors that needs to be
> > fixed up during probe. Mike Remski discovered that the current
> > implementation is broken as it crashes the kernel if an interface
> > without endpoints is probed.
> >
> > These patches fix this bug, while cleaning up the max-packet-size
> > handling and removing a redundant probe quirk that fixes up mtxorb
> > devices.
>
> Looks good, but did you forget to cc: me as well so that I know to pick
> these up? Or are you going to send a pull request later on with them?
Yes, that was my intention. None of these are really critical and could
wait for v3.17-rc1, although I'll probably send you the first for
v3.16-rc2.
As we discussed briefly off-list, I intend to maintain a usb-next and
usb-linus branch in my USB-serial tree on kernel.org, while posting my
own patches to linux-usb for review before applying them (I can still CC
you as well of course).
Perhaps I should start using a "usb-serial:" prefix to make it easier to
discern what I intend to apply myself from any non-USB-serial patches I
might be sending you? Or the diff-stat would be sufficient
("drivers/usb/serial/*") for that?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] USB: ftdi_sio: wMaxPacketSize patches
On Thu, Jun 05, 2014 at 04:05:51PM +0200, Johan Hovold wrote: > Some FTDI devices have broken endpoint descriptors that needs to be > fixed up during probe. Mike Remski discovered that the current > implementation is broken as it crashes the kernel if an interface > without endpoints is probed. > > These patches fix this bug, while cleaning up the max-packet-size > handling and removing a redundant probe quirk that fixes up mtxorb > devices. Looks good, but did you forget to cc: me as well so that I know to pick these up? Or are you going to send a pull request later on with them? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] USB: ftdi_sio: wMaxPacketSize patches
Some FTDI devices have broken endpoint descriptors that needs to be fixed up during probe. Mike Remski discovered that the current implementation is broken as it crashes the kernel if an interface without endpoints is probed. These patches fix this bug, while cleaning up the max-packet-size handling and removing a redundant probe quirk that fixes up mtxorb devices. Johan Johan Hovold (5): USB: ftdi_sio: fix null deref at port probe USB: ftdi_sio: make port probe less verbose USB: ftdi_sio: fix max-packet-size warning USB: ftdi_sio: clean up ftdi_set_max_packet_size() USB: ftdi_sio: remove redundant mtxorb quirk drivers/usb/serial/ftdi_sio.c | 87 ++- 1 file changed, 27 insertions(+), 60 deletions(-) -- 1.8.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
