Re: [PATCH 00/11] usbnet: usbnet: handle link change
From: Ming Lei Date: Thu, 11 Apr 2013 22:40:29 +0800 > This patch set introduces usbnet_link_change() API and applies > it on all usbnet drivers, then handle the link change centrally > to stop bulk transfer when link becomes off and restart bulk > transfer when link becomes on. > > With the change, ~10% performance boost on bulk transfer > of another device on the same bus can be obtained when link > is off. Also, stopping bulk transfer when link becomes off > may disable asynchonous schedule of host controller, power > might be saved probabally. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] usbnet: usbnet: handle link change
On Thu, Apr 11, 2013 at 11:18 PM, Jussi Kivilinna wrote: > On 11.04.2013 17:40, Ming Lei wrote: >> Hi, >> >> This patch set introduces usbnet_link_change() API and applies >> it on all usbnet drivers, then handle the link change centrally >> to stop bulk transfer when link becomes off and restart bulk >> transfer when link becomes on. > > Should 'rndis_wlan' be changed to use this too? If link detection of 'rndis_wlan' doesn't depend on bulk transfer, it can benefit from the change. Otherwise, it needn't the change, but the patch won't have side-effect on 'rndis_wlan'. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] usbnet: usbnet: handle link change
On 11.04.2013 17:40, Ming Lei wrote: > Hi, > > This patch set introduces usbnet_link_change() API and applies > it on all usbnet drivers, then handle the link change centrally > to stop bulk transfer when link becomes off and restart bulk > transfer when link becomes on. Should 'rndis_wlan' be changed to use this too? -Jussi > > With the change, ~10% performance boost on bulk transfer > of another device on the same bus can be obtained when link > is off. Also, stopping bulk transfer when link becomes off > may disable asynchonous schedule of host controller, power > might be saved probabally. > > drivers/net/usb/asix_devices.c |6 +- > drivers/net/usb/ax88179_178a.c | 12 --- > drivers/net/usb/cdc_ether.c|5 + > drivers/net/usb/cdc_ncm.c |9 +++- > drivers/net/usb/dm9601.c |7 +-- > drivers/net/usb/mcs7830.c |6 +- > drivers/net/usb/sierra_net.c |3 +-- > drivers/net/usb/usbnet.c | 45 > +++- > include/linux/usb/usbnet.h |2 ++ > 9 files changed, 58 insertions(+), 37 deletions(-) > > > Thanks, > -- > Ming Lei > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/11] usbnet: usbnet: handle link change
Hi, This patch set introduces usbnet_link_change() API and applies it on all usbnet drivers, then handle the link change centrally to stop bulk transfer when link becomes off and restart bulk transfer when link becomes on. With the change, ~10% performance boost on bulk transfer of another device on the same bus can be obtained when link is off. Also, stopping bulk transfer when link becomes off may disable asynchonous schedule of host controller, power might be saved probabally. drivers/net/usb/asix_devices.c |6 +- drivers/net/usb/ax88179_178a.c | 12 --- drivers/net/usb/cdc_ether.c|5 + drivers/net/usb/cdc_ncm.c |9 +++- drivers/net/usb/dm9601.c |7 +-- drivers/net/usb/mcs7830.c |6 +- drivers/net/usb/sierra_net.c |3 +-- drivers/net/usb/usbnet.c | 45 +++- include/linux/usb/usbnet.h |2 ++ 9 files changed, 58 insertions(+), 37 deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
