Re: [PATCH 08/18] usb: dwc2: Rename dwc2_core_reset()

[Doug Anderson]

John,

On Wed, Dec 2, 2015 at 11:13 AM, John Youn  wrote:
> Renamed dwc2_core_reset() to dwc2_core_reset_and_force_mode(). This
> describes what it is doing more accurately. This is in preparation of
> introducing a plain dwc2_core_reset() function that only performs the
> reset and doesn't force the mode.
>
> Signed-off-by: John Youn 
> ---
>  drivers/usb/dwc2/core.c | 8 
>  drivers/usb/dwc2/core.h | 2 +-
>  drivers/usb/dwc2/platform.c | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

Agree that this does a rename and said rename seems sane to me.  Works
across many reboots on a farm of rk3288-based devices on a 3.14
kernel.

Reviewed-by: Douglas Anderson 
Tested-by: Douglas Anderson 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/18] usb: dwc2: Rename dwc2_core_reset()

[John Youn]

Renamed dwc2_core_reset() to dwc2_core_reset_and_force_mode(). This
describes what it is doing more accurately. This is in preparation of
introducing a plain dwc2_core_reset() function that only performs the
reset and doesn't force the mode.

Signed-off-by: John Youn 
---
 drivers/usb/dwc2/core.c | 8 
 drivers/usb/dwc2/core.h | 2 +-
 drivers/usb/dwc2/platform.c | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 2d2b538..24f9e80 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -481,7 +481,7 @@ static void dwc2_init_fs_ls_pclk_sel(struct dwc2_hsotg 
*hsotg)
  * Do core a soft reset of the core.  Be careful with this because it
  * resets all the internal state machines of the core.
  */
-int dwc2_core_reset(struct dwc2_hsotg *hsotg)
+int dwc2_core_reset_and_force_mode(struct dwc2_hsotg *hsotg)
 {
u32 greset;
int count = 0;
@@ -561,7 +561,7 @@ static int dwc2_fs_phy_init(struct dwc2_hsotg *hsotg, bool 
select_phy)
dwc2_writel(usbcfg, hsotg->regs + GUSBCFG);
 
/* Reset after a PHY select */
-   retval = dwc2_core_reset(hsotg);
+   retval = dwc2_core_reset_and_force_mode(hsotg);
 
if (retval) {
dev_err(hsotg->dev,
@@ -640,7 +640,7 @@ static int dwc2_hs_phy_init(struct dwc2_hsotg *hsotg, bool 
select_phy)
dwc2_writel(usbcfg, hsotg->regs + GUSBCFG);
 
/* Reset after setting the PHY parameters */
-   retval = dwc2_core_reset(hsotg);
+   retval = dwc2_core_reset_and_force_mode(hsotg);
if (retval) {
dev_err(hsotg->dev,
"%s: Reset failed, aborting", __func__);
@@ -805,7 +805,7 @@ int dwc2_core_init(struct dwc2_hsotg *hsotg, bool 
initial_setup)
 * needed to in order to properly detect various parameters).
 */
if (!initial_setup) {
-   retval = dwc2_core_reset(hsotg);
+   retval = dwc2_core_reset_and_force_mode(hsotg);
if (retval) {
dev_err(hsotg->dev, "%s(): Reset failed, aborting\n",
__func__);
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 28d0288..0b4c036 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -889,7 +889,7 @@ enum dwc2_halt_status {
  * The following functions support initialization of the core driver component
  * and the DWC_otg controller
  */
-extern int dwc2_core_reset(struct dwc2_hsotg *hsotg);
+extern int dwc2_core_reset_and_force_mode(struct dwc2_hsotg *hsotg);
 extern void dwc2_core_host_init(struct dwc2_hsotg *hsotg);
 extern int dwc2_enter_hibernation(struct dwc2_hsotg *hsotg);
 extern int dwc2_exit_hibernation(struct dwc2_hsotg *hsotg, bool restore);
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 442cd0d..1c2f5f6 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -459,7 +459,7 @@ static int dwc2_driver_probe(struct platform_device *dev)
 * Reset before dwc2_get_hwparams() then it could get power-on real
 * reset value form registers.
 */
-   dwc2_core_reset(hsotg);
+   dwc2_core_reset_and_force_mode(hsotg);
 
/* Detect config values from hardware */
retval = dwc2_get_hwparams(hsotg);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html