[PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
From: Torsten Fleischer to-fleisc...@t-online.de The call of 'kfree(ci-hw_bank.regmap)' in ci_hdrc_remove() sometimes causes a kernel oops when removing the ci_hdrc module. Since there is no separate memory allocated for the ci-hw_bank.regmap array, there is no need to free it. Cc: v3.14+ stable@@vger.kernel.org Signed-off-by: Torsten Fleischer to-fleisc...@t-online.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 3df5005..9bdc6bd 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -742,7 +742,6 @@ static int ci_hdrc_remove(struct platform_device *pdev) ci_role_destroy(ci); ci_hdrc_enter_lpm(ci, true); usb_phy_shutdown(ci-transceiver); - kfree(ci-hw_bank.regmap); return 0; } -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] usb: chipidea: Fix oops when removing the ci_hdrc module
On Fri, Oct 03, 2014 at 11:01:20AM +0200, Torsten Fleischer wrote: The call of 'kfree(ci-hw_bank.regmap)' in ci_hdrc_remove() sometimes causes a kernel oops when removing the ci_hdrc module. Since there is no separate memory allocated for the ci-hw_bank.regmap array, there is no need to free it. Signed-off-by: Torsten Fleischer to-fleisc...@t-online.de --- drivers/usb/chipidea/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 619d13e..4ecb650 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -732,7 +732,6 @@ static int ci_hdrc_remove(struct platform_device *pdev) ci_role_destroy(ci); ci_hdrc_enter_lpm(ci, true); usb_phy_shutdown(ci-transceiver); - kfree(ci-hw_bank.regmap); return 0; } -- 1.8.4.5 Good fix, applied, thanks. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
