Re: [PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-12-06 Thread Jarrad Whitaker 
Hey guys,

Sorry for the very slow reply, I broke my build dir and was in the
middle of exams. Tested successfully (keyboard works after a hotplug)
with 3.18-rc7.

Jarrad

On 6 November 2014 at 07:39, Jiri Kosina jkos...@suse.cz wrote:
 On Mon, 3 Nov 2014, Alan Wu wrote:

 Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from 
 this thread. Both trackpad and keyboard work after compiling my own kernel.
 http://ubuntuforums.org/showthread.php?t=2231207page=2s=44910e0c56047e4f93dfd9fea58121ef

 Also includes Jarrad Whitaker's message which sources
 http://winaero.com/blog/how-to-install-linux-on-surface-pro-3/
 which he says is sourced from a Russian site

 Signed-off-by: Alan Wu alan.c...@gmail.com

 Adding Jarrad to CC so that he can test your patch as well.

 Jarrad, if you could provide your Tested-by: to Alan's patch, I'd
 appreciate it (that would mean that we've reached the right super-position
 of both the patches you guys submitted).

 I don't own the device, so I fully depend on what you guys submit and
 test.

 Thanks.

 ---
  drivers/hid/hid-core.c  | 6 ++
  drivers/hid/hid-ids.h   | 1 +
  drivers/hid/hid-microsoft.c | 2 ++
  drivers/hid/usbhid/hid-quirks.c | 1 +
  4 files changed, 10 insertions(+)

 diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
 index 73bd9e2..e94afcc 100644
 --- a/drivers/hid/hid-core.c
 +++ b/drivers/hid/hid-core.c
 @@ -702,6 +702,11 @@ static void hid_scan_collection(struct hid_parser 
 *parser, unsigned type)
   if (((parser-global.usage_page  16) == HID_UP_SENSOR) 
   type == HID_COLLECTION_PHYSICAL)
   hid-group = HID_GROUP_SENSOR_HUB;
 +
 + if (hid-vendor == USB_VENDOR_ID_MICROSOFT 
 + hid-product == USB_DEVICE_ID_MS_TYPE_COVER_3 
 + hid-group == HID_GROUP_MULTITOUCH)
 + hid-group = HID_GROUP_GENERIC;
  }

  static int hid_scan_main(struct hid_parser *parser, struct hid_item *item)
 @@ -1861,6 +1866,7 @@ static const struct hid_device_id 
 hid_have_special_driver[] = {
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_OFFICE_KB) 
 },
 + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_TYPE_COVER_3) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MSI, 
 USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
   { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, 
 USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) },
 diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
 index e23ab8b..15f32c2 100644
 --- a/drivers/hid/hid-ids.h
 +++ b/drivers/hid/hid-ids.h
 @@ -648,6 +648,7 @@
  #define USB_DEVICE_ID_MS_SURFACE_PRO_2   0x0799
  #define USB_DEVICE_ID_MS_TOUCH_COVER_2   0x07a7
  #define USB_DEVICE_ID_MS_TYPE_COVER_20x07a9
 +#define USB_DEVICE_ID_MS_TYPE_COVER_30x07dc

  #define USB_VENDOR_ID_MOJO   0x8282
  #define USB_DEVICE_ID_RETRO_ADAPTER  0x3201
 diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
 index 8ba17a9..cacda43 100644
 --- a/drivers/hid/hid-microsoft.c
 +++ b/drivers/hid/hid-microsoft.c
 @@ -274,6 +274,8 @@ static const struct hid_device_id ms_devices[] = {
   .driver_data = MS_NOGET },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_COMFORT_MOUSE_4500),
   .driver_data = MS_DUPLICATE_USAGES },
 + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_TYPE_COVER_3),
 + .driver_data = MS_HIDINPUT },

   { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_PRESENTER_8K_BT),
   .driver_data = MS_PRESENTER },
 diff --git a/drivers/hid/usbhid/hid-quirks.c 
 b/drivers/hid/usbhid/hid-quirks.c
 index 5014bb5..cebfaf2 100644
 --- a/drivers/hid/usbhid/hid-quirks.c
 +++ b/drivers/hid/usbhid/hid-quirks.c
 @@ -77,6 +77,7 @@ static const struct hid_blacklist {
   { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, 
 HID_QUIRK_NOGET },
   { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET },
 + { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, 
 HID_QUIRK_NO_INIT_REPORTS },
 --
 2.1.0


 --
 Jiri Kosina
 SUSE Labs
Signed-off-by: Alan Wu alan.c.wu@x
Tested-by: Jarrad Whitaker jarrad.whita...@gmail.com
---
 drivers/hid/hid-core.c  | 6 ++
 drivers/hid/hid-ids.h   | 1 +
 drivers/hid/hid-microsoft.c | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 1 +

Re: [PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-11-11 Thread Jiri Kosina 
On Mon, 3 Nov 2014, Alan Wu wrote:

 Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from this 
 thread. Both trackpad and keyboard work after compiling my own kernel.
 http://ubuntuforums.org/showthread.php?t=2231207page=2s=44910e0c56047e4f93dfd9fea58121ef
 
 Also includes Jarrad Whitaker's message which sources
 http://winaero.com/blog/how-to-install-linux-on-surface-pro-3/
 which he says is sourced from a Russian site
 
 Signed-off-by: Alan Wu alan.c...@gmail.com

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-11-05 Thread Jiri Kosina 
On Mon, 3 Nov 2014, Alan Wu wrote:

 Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from this 
 thread. Both trackpad and keyboard work after compiling my own kernel.
 http://ubuntuforums.org/showthread.php?t=2231207page=2s=44910e0c56047e4f93dfd9fea58121ef
 
 Also includes Jarrad Whitaker's message which sources
 http://winaero.com/blog/how-to-install-linux-on-surface-pro-3/
 which he says is sourced from a Russian site
 
 Signed-off-by: Alan Wu alan.c...@gmail.com

Adding Jarrad to CC so that he can test your patch as well.

Jarrad, if you could provide your Tested-by: to Alan's patch, I'd 
appreciate it (that would mean that we've reached the right super-position 
of both the patches you guys submitted).

I don't own the device, so I fully depend on what you guys submit and 
test.

Thanks.

 ---
  drivers/hid/hid-core.c  | 6 ++
  drivers/hid/hid-ids.h   | 1 +
  drivers/hid/hid-microsoft.c | 2 ++
  drivers/hid/usbhid/hid-quirks.c | 1 +
  4 files changed, 10 insertions(+)
 
 diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
 index 73bd9e2..e94afcc 100644
 --- a/drivers/hid/hid-core.c
 +++ b/drivers/hid/hid-core.c
 @@ -702,6 +702,11 @@ static void hid_scan_collection(struct hid_parser 
 *parser, unsigned type)
   if (((parser-global.usage_page  16) == HID_UP_SENSOR) 
   type == HID_COLLECTION_PHYSICAL)
   hid-group = HID_GROUP_SENSOR_HUB;
 +
 + if (hid-vendor == USB_VENDOR_ID_MICROSOFT 
 + hid-product == USB_DEVICE_ID_MS_TYPE_COVER_3 
 + hid-group == HID_GROUP_MULTITOUCH)
 + hid-group = HID_GROUP_GENERIC;
  }
  
  static int hid_scan_main(struct hid_parser *parser, struct hid_item *item)
 @@ -1861,6 +1866,7 @@ static const struct hid_device_id 
 hid_have_special_driver[] = {
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_OFFICE_KB) },
 + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_TYPE_COVER_3) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
   { HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) 
 },
   { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) 
 },
 diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
 index e23ab8b..15f32c2 100644
 --- a/drivers/hid/hid-ids.h
 +++ b/drivers/hid/hid-ids.h
 @@ -648,6 +648,7 @@
  #define USB_DEVICE_ID_MS_SURFACE_PRO_2   0x0799
  #define USB_DEVICE_ID_MS_TOUCH_COVER_2   0x07a7
  #define USB_DEVICE_ID_MS_TYPE_COVER_20x07a9
 +#define USB_DEVICE_ID_MS_TYPE_COVER_30x07dc
  
  #define USB_VENDOR_ID_MOJO   0x8282
  #define USB_DEVICE_ID_RETRO_ADAPTER  0x3201
 diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
 index 8ba17a9..cacda43 100644
 --- a/drivers/hid/hid-microsoft.c
 +++ b/drivers/hid/hid-microsoft.c
 @@ -274,6 +274,8 @@ static const struct hid_device_id ms_devices[] = {
   .driver_data = MS_NOGET },
   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_COMFORT_MOUSE_4500),
   .driver_data = MS_DUPLICATE_USAGES },
 + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_TYPE_COVER_3),
 + .driver_data = MS_HIDINPUT },
  
   { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, 
 USB_DEVICE_ID_MS_PRESENTER_8K_BT),
   .driver_data = MS_PRESENTER },
 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
 index 5014bb5..cebfaf2 100644
 --- a/drivers/hid/usbhid/hid-quirks.c
 +++ b/drivers/hid/usbhid/hid-quirks.c
 @@ -77,6 +77,7 @@ static const struct hid_blacklist {
   { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, 
 HID_QUIRK_NOGET },
   { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET },
 + { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, 
 HID_QUIRK_NO_INIT_REPORTS },
   { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, 
 HID_QUIRK_NO_INIT_REPORTS },
 -- 
 2.1.0
 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-11-03 Thread Alan Wu 
Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from this 
thread. Both trackpad and keyboard work after compiling my own kernel.
http://ubuntuforums.org/showthread.php?t=2231207page=2s=44910e0c56047e4f93dfd9fea58121ef

Also includes Jarrad Whitaker's message which sources
http://winaero.com/blog/how-to-install-linux-on-surface-pro-3/
which he says is sourced from a Russian site

Signed-off-by: Alan Wu alan.c...@gmail.com
---
 drivers/hid/hid-core.c  | 6 ++
 drivers/hid/hid-ids.h   | 1 +
 drivers/hid/hid-microsoft.c | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 1 +
 4 files changed, 10 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 73bd9e2..e94afcc 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -702,6 +702,11 @@ static void hid_scan_collection(struct hid_parser *parser, 
unsigned type)
if (((parser-global.usage_page  16) == HID_UP_SENSOR) 
type == HID_COLLECTION_PHYSICAL)
hid-group = HID_GROUP_SENSOR_HUB;
+
+   if (hid-vendor == USB_VENDOR_ID_MICROSOFT 
+   hid-product == USB_DEVICE_ID_MS_TYPE_COVER_3 
+   hid-group == HID_GROUP_MULTITOUCH)
+   hid-group = HID_GROUP_GENERIC;
 }
 
 static int hid_scan_main(struct hid_parser *parser, struct hid_item *item)
@@ -1861,6 +1866,7 @@ static const struct hid_device_id 
hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_OFFICE_KB) },
+   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_MS_TYPE_COVER_3) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) 
},
{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) 
},
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index e23ab8b..15f32c2 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -648,6 +648,7 @@
 #define USB_DEVICE_ID_MS_SURFACE_PRO_2   0x0799
 #define USB_DEVICE_ID_MS_TOUCH_COVER_2   0x07a7
 #define USB_DEVICE_ID_MS_TYPE_COVER_20x07a9
+#define USB_DEVICE_ID_MS_TYPE_COVER_30x07dc
 
 #define USB_VENDOR_ID_MOJO 0x8282
 #define USB_DEVICE_ID_RETRO_ADAPTER0x3201
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 8ba17a9..cacda43 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -274,6 +274,8 @@ static const struct hid_device_id ms_devices[] = {
.driver_data = MS_NOGET },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_MS_COMFORT_MOUSE_4500),
.driver_data = MS_DUPLICATE_USAGES },
+   { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_MS_TYPE_COVER_3),
+   .driver_data = MS_HIDINPUT },
 
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, 
USB_DEVICE_ID_MS_PRESENTER_8K_BT),
.driver_data = MS_PRESENTER },
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 5014bb5..cebfaf2 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -77,6 +77,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, 
HID_QUIRK_NOGET },
{ USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET },
+   { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, 
HID_QUIRK_NO_INIT_REPORTS },
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html