Re: [PATCH 1/4] usb: host: ehci.h: cleanup header file

[Greg Kroah-Hartman]

On Wed, Dec 09, 2015 at 04:57:30PM -0300, Geyslan G. Bem wrote:
> This patch silences
>  - A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
>  - All the errors and many warnings shown by checkpatch

"all" is a lot.  Please break down each type of change to a separate
patch.  Then do a patch with the coccinelle warning fixes as well.
That will make these patches a lot smaller and easier to review.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] usb: host: ehci.h: cleanup header file

[Geyslan G. Bem]

2015-12-09 17:09 GMT-03:00 Greg Kroah-Hartman :
> On Wed, Dec 09, 2015 at 04:57:30PM -0300, Geyslan G. Bem wrote:
>> This patch silences
>>  - A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
>>  - All the errors and many warnings shown by checkpatch
>
> "all" is a lot.  Please break down each type of change to a separate
> patch.  Then do a patch with the coccinelle warning fixes as well.
> That will make these patches a lot smaller and easier to review.

Ok. Doing.

>
> thanks,
>
> greg k-h



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] usb: host: ehci.h: cleanup header file

[Geyslan G. Bem]

This patch silences
 - A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
 - All the errors and many warnings shown by checkpatch

Signed-off-by: Geyslan G. Bem 
---
 drivers/usb/host/ehci.h | 89 +
 1 file changed, 45 insertions(+), 44 deletions(-)

diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index ec61aed..a4f5ab5 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -185,10 +185,10 @@ struct ehci_hcd { /* one per controller */
struct ehci_sitd*last_sitd_to_free;
 
/* per root hub port */
-   unsigned long   reset_done [EHCI_MAX_ROOT_PORTS];
+   unsigned long   reset_done[EHCI_MAX_ROOT_PORTS];
 
/* bit vectors (one bit per port) */
-   unsigned long   bus_suspended;  /* which ports were
+   unsigned long   bus_suspended;  /* which ports were
already suspended at the start of a bus suspend */
unsigned long   companion_ports;/* which ports are
dedicated to the companion controller */
@@ -244,9 +244,9 @@ struct ehci_hcd {   /* one per controller */
/* irq statistics */
 #ifdef EHCI_STATS
struct ehci_stats   stats;
-#  define COUNT(x) do { (x)++; } while (0)
+#  define COUNT(x) ((x)++)
 #else
-#  define COUNT(x) do {} while (0)
+#  define COUNT(x) ((void) 0)
 #endif
 
/* debug files */
@@ -268,13 +268,13 @@ struct ehci_hcd { /* one per controller */
 };
 
 /* convert between an HCD pointer and the corresponding EHCI_HCD */
-static inline struct ehci_hcd *hcd_to_ehci (struct usb_hcd *hcd)
+static inline struct ehci_hcd *hcd_to_ehci(struct usb_hcd *hcd)
 {
return (struct ehci_hcd *) (hcd->hcd_priv);
 }
-static inline struct usb_hcd *ehci_to_hcd (struct ehci_hcd *ehci)
+static inline struct usb_hcd *ehci_to_hcd(struct ehci_hcd *ehci)
 {
-   return container_of ((void *) ehci, struct usb_hcd, hcd_priv);
+   return container_of((void *) ehci, struct usb_hcd, hcd_priv);
 }
 
 /*-*/
@@ -316,25 +316,25 @@ struct ehci_qtd {
 #define HALT_BIT(ehci) cpu_to_hc32(ehci, QTD_STS_HALT)
 #define STATUS_BIT(ehci)   cpu_to_hc32(ehci, QTD_STS_STS)
 
-   __hc32  hw_buf [5];/* see EHCI 3.5.4 */
-   __hc32  hw_buf_hi [5];/* Appendix B */
+   __hc32  hw_buf[5];  /* see EHCI 3.5.4 */
+   __hc32  hw_buf_hi[5];   /* Appendix B */
 
/* the rest is HCD-private */
-   dma_addr_t  qtd_dma;/* qtd address */
-   struct list_headqtd_list;   /* sw qtd list */
-   struct urb  *urb;   /* qtd's urb */
-   size_t  length; /* length of buffer */
-} __attribute__ ((aligned (32)));
+   dma_addr_t  qtd_dma;/* qtd address */
+   struct list_headqtd_list;   /* sw qtd list */
+   struct urb  *urb;   /* qtd's urb */
+   size_t  length; /* length of buffer */
+} __aligned(32);
 
 /* mask NakCnt+T in qh->hw_alt_next */
-#define QTD_MASK(ehci) cpu_to_hc32 (ehci, ~0x1f)
+#define QTD_MASK(ehci) (cpu_to_hc32(ehci, ~0x1f))
 
-#define IS_SHORT_READ(token) (QTD_LENGTH (token) != 0 && QTD_PID (token) == 1)
+#define IS_SHORT_READ(token) (QTD_LENGTH(token) != 0 && QTD_PID(token) == 1)
 
 /*-*/
 
 /* type tag from {qh,itd,sitd,fstn}->hw_next */
-#define Q_NEXT_TYPE(ehci,dma)  ((dma) & cpu_to_hc32(ehci, 3 << 1))
+#define Q_NEXT_TYPE(ehci, dma) ((dma) & cpu_to_hc32(ehci, 3 << 1))
 
 /*
  * Now the following defines are not converted using the
@@ -350,7 +350,8 @@ struct ehci_qtd {
 #define Q_TYPE_FSTN(3 << 1)
 
 /* next async queue entry, or pointer to interrupt/periodic QH */
-#define QH_NEXT(ehci,dma)  (cpu_to_hc32(ehci, 
(((u32)dma)&~0x01f)|Q_TYPE_QH))
+#define QH_NEXT(ehci, dma) \
+   (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))
 
 /* for periodic/async schedules and qtd lists, mark end of list */
 #define EHCI_LIST_END(ehci)cpu_to_hc32(ehci, 1) /* "null pointer" to hw */
@@ -405,9 +406,9 @@ struct ehci_qh_hw {
__hc32  hw_qtd_next;
__hc32  hw_alt_next;
__hc32  hw_token;
-   __hc32  hw_buf [5];
-   __hc32  hw_buf_hi [5];
-} __attribute__ ((aligned(32)));
+   __hc32  hw_buf[5];
+   __hc32  hw_buf_hi[5];
+} __aligned(32);
 
 struct ehci_qh {
struct ehci_qh_hw   *hw;/* Must come first */
@@ -462,7 +463,7 @@ struct