From: Guido Kiener <guido.kie...@rohde-schwarz.com>

Kernel memory is allocated twice in new function
usbtmc_ioctl_request and creates a memory leak.
This fix removes the superfluous kmalloc().

Signed-off-by: Guido Kiener <guido.kie...@rohde-schwarz.com>
Fixes: 658f24f4523e ("usb: usbtmc: Add ioctl for generic requests on control")
---
 drivers/usb/class/usbtmc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 0fcb81a1399b..dfbcf418dad7 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -1895,10 +1895,6 @@ static int usbtmc_ioctl_request(struct 
usbtmc_device_data *data,
        if (res)
                return -EFAULT;
 
-       buffer = kmalloc(request.req.wLength, GFP_KERNEL);
-       if (!buffer)
-               return -ENOMEM;
-
        if (request.req.wLength > USBTMC_BUFSIZE)
                return -EMSGSIZE;
 
-- 
2.17.1

Reply via email to