Re: [PATCH 1/5] cdc-acm: reindent log messages

[Oliver Neukum]

On Tue, 2016-11-15 at 12:26 +0100, Ladislav Michl wrote:
> On Tue, Nov 15, 2016 at 11:07:27AM +0100, Greg KH wrote:
> > On Wed, Nov 09, 2016 at 12:53:25PM +0100, Ladislav Michl wrote:
> > > Signed-off-by: Ladislav Michl 
> > > ---
> > >  drivers/usb/class/cdc-acm.c | 35 +--
> > >  1 file changed, 17 insertions(+), 18 deletions(-)
> > 
> > I can't take patches without any changelog text :(
> 
> I'm sorry about that, thought subject is enough in this case.
> 
> > And please cc: Oliver and me if you want us to notice the patches,
> > otherwise they can easily get lost in the noise...
> 
> Will resend. Before that, do you or Oliver have any more
> objec^H^H^H^H^Hsuggestions to this patch serie?

No, go ahead, it looks fine.

Regards
Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] cdc-acm: reindent log messages

[Ladislav Michl]

On Tue, Nov 15, 2016 at 11:07:27AM +0100, Greg KH wrote:
> On Wed, Nov 09, 2016 at 12:53:25PM +0100, Ladislav Michl wrote:
> > Signed-off-by: Ladislav Michl 
> > ---
> >  drivers/usb/class/cdc-acm.c | 35 +--
> >  1 file changed, 17 insertions(+), 18 deletions(-)
> 
> I can't take patches without any changelog text :(

I'm sorry about that, thought subject is enough in this case.

> And please cc: Oliver and me if you want us to notice the patches,
> otherwise they can easily get lost in the noise...

Will resend. Before that, do you or Oliver have any more
objec^H^H^H^H^Hsuggestions to this patch serie?

Thank you,
ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] cdc-acm: reindent log messages

[Ladislav Michl]

Signed-off-by: Ladislav Michl 
---
 drivers/usb/class/cdc-acm.c | 35 +--
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 78f0f85..b511289 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -133,8 +133,8 @@ static int acm_ctrl_msg(struct acm *acm, int request, int 
value,
buf, len, 5000);
 
dev_dbg(>control->dev,
-   "%s - rq 0x%02x, val %#x, len %#x, result %d\n",
-   __func__, request, value, len, retval);
+   "%s - rq 0x%02x, val %#x, len %#x, result %d\n",
+   __func__, request, value, len, retval);
 
usb_autopm_put_interface(acm->control);
 
@@ -291,13 +291,13 @@ static void acm_ctrl_irq(struct urb *urb)
case -ESHUTDOWN:
/* this urb is terminated, clean up */
dev_dbg(>control->dev,
-   "%s - urb shutting down with status: %d\n",
-   __func__, status);
+   "%s - urb shutting down with status: %d\n",
+   __func__, status);
return;
default:
dev_dbg(>control->dev,
-   "%s - nonzero urb status received: %d\n",
-   __func__, status);
+   "%s - nonzero urb status received: %d\n",
+   __func__, status);
goto exit;
}
 
@@ -306,16 +306,16 @@ static void acm_ctrl_irq(struct urb *urb)
data = (unsigned char *)(dr + 1);
switch (dr->bNotificationType) {
case USB_CDC_NOTIFY_NETWORK_CONNECTION:
-   dev_dbg(>control->dev, "%s - network connection: %d\n",
-   __func__, dr->wValue);
+   dev_dbg(>control->dev,
+   "%s - network connection: %d\n", __func__, dr->wValue);
break;
 
case USB_CDC_NOTIFY_SERIAL_STATE:
newctrl = get_unaligned_le16(data);
 
if (!acm->clocal && (acm->ctrlin & ~newctrl & ACM_CTRL_DCD)) {
-   dev_dbg(>control->dev, "%s - calling hangup\n",
-   __func__);
+   dev_dbg(>control->dev,
+   "%s - calling hangup\n", __func__);
tty_port_tty_hangup(>port, false);
}
 
@@ -357,8 +357,8 @@ static void acm_ctrl_irq(struct urb *urb)
 exit:
retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval && retval != -EPERM)
-   dev_err(>control->dev, "%s - usb_submit_urb failed: %d\n",
-   __func__, retval);
+   dev_err(>control->dev,
+   "%s - usb_submit_urb failed: %d\n", __func__, retval);
 }
 
 static int acm_submit_read_urb(struct acm *acm, int index, gfp_t mem_flags)
@@ -372,8 +372,8 @@ static int acm_submit_read_urb(struct acm *acm, int index, 
gfp_t mem_flags)
if (res) {
if (res != -EPERM) {
dev_err(>data->dev,
-   "urb %d failed submission with %d\n",
-   index, res);
+   "urb %d failed submission with %d\n",
+   index, res);
}
set_bit(index, >read_urbs_free);
return res;
@@ -416,8 +416,7 @@ static void acm_read_bulk_callback(struct urb *urb)
int status = urb->status;
 
dev_vdbg(>data->dev, "got urb %d, len %d, status %d\n",
-   rb->index, urb->actual_length,
-   status);
+   rb->index, urb->actual_length, status);
 
if (!acm->dev) {
set_bit(rb->index, >read_urbs_free);
@@ -837,8 +836,8 @@ static int acm_tty_break_ctl(struct tty_struct *tty, int 
state)
 
retval = acm_send_break(acm, state ? 0x : 0);
if (retval < 0)
-   dev_dbg(>control->dev, "%s - send break failed\n",
-   __func__);
+   dev_dbg(>control->dev,
+   "%s - send break failed\n", __func__);
return retval;
 }
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html