Re: [PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-23 Thread Greg KH 
On Fri, Jul 19, 2013 at 11:34:24AM +0200, Matthijs Kooijman wrote:
 There was some code that cleared the dma_mask when dma was disabled in
 the driver. Given that clearing the mask doesn't actually tell the usb
 core we're not using dma, and a previous commit explicitely sets the
 hcd-self.uses_dma value, it seems these values are unneeded and can
 only potentially cause problems (when reloading a module, for example).
 
 Signed-off-by: Matthijs Kooijman matth...@stdin.nl
 Acked-by: Paul Zimmerman paul.zimmer...@synopsys.com
 ---
  drivers/staging/dwc2/hcd.c | 3 ---
  1 file changed, 3 deletions(-)

This patch no longer applies, as I've caught up with Paul's pending
patches.  Please refresh it against the next linux-next release and
resend it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-19 Thread Matthijs Kooijman 
There was some code that cleared the dma_mask when dma was disabled in
the driver. Given that clearing the mask doesn't actually tell the usb
core we're not using dma, and a previous commit explicitely sets the
hcd-self.uses_dma value, it seems these values are unneeded and can
only potentially cause problems (when reloading a module, for example).

Signed-off-by: Matthijs Kooijman matth...@stdin.nl
Acked-by: Paul Zimmerman paul.zimmer...@synopsys.com
---
 drivers/staging/dwc2/hcd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 50a379d..075e53b 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2817,9 +2817,6 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq,
if (dma_set_coherent_mask(hsotg-dev, DMA_BIT_MASK(31))  0)
dev_warn(hsotg-dev,
 can't enable workaround for 2GB RAM\n);
-   } else {
-   dma_set_mask(hsotg-dev, 0);
-   dma_set_coherent_mask(hsotg-dev, 0);
}
 
hcd = usb_create_hcd(dwc2_hc_driver, hsotg-dev, dev_name(hsotg-dev));
-- 
1.8.3.rc1

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-17 Thread Matthijs Kooijman 
There was some code that cleared the dma_mask when dma was disabled in
the driver. Given that clearing the mask doesn't actually tell the usb
core we're not using dma, and a previous commit explicitely sets the
hcd-self.uses_dma value, it seems these values are unneeded and can
only potentially cause problems (when reloading a module, for example).

Signed-off-by: Matthijs Kooijman matth...@stdin.nl
---
 drivers/staging/dwc2/hcd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 22ac24c..74498ef 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2756,9 +2756,6 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq,
if (dma_set_coherent_mask(hsotg-dev, DMA_BIT_MASK(31))  0)
dev_warn(hsotg-dev,
 can't enable workaround for 2GB RAM\n);
-   } else {
-   dma_set_mask(hsotg-dev, 0);
-   dma_set_coherent_mask(hsotg-dev, 0);
}
 
hcd = usb_create_hcd(dwc2_hc_driver, hsotg-dev, dev_name(hsotg-dev));
-- 
1.8.3.rc1

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html