Re: [PATCH usb v3 22/29] host: xhci-plat: remove duplicate check on resource

2014-11-03 Thread Gregory CLEMENT 
Hi Varka,

On 31/10/2014 02:14, Varka Bhadram wrote:
 From: Varka Bhadram varkabhad...@gmail.com
 
 Sanity check on resource happening with devm_ioremap_resource().


Reviewed-by: Gregory CLEMENT gregory.clem...@free-electrons.com


Thanks,

Gregory


 
 Signed-off-by: Varka Bhadram var...@cdac.in
 Acked-by: Alan Stern st...@rowland.harvard.edu
 ---
  drivers/usb/host/xhci-plat.c |   10 --
  1 file changed, 4 insertions(+), 6 deletions(-)
 
 diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
 index 3d78b0c..e68b4ec 100644
 --- a/drivers/usb/host/xhci-plat.c
 +++ b/drivers/usb/host/xhci-plat.c
 @@ -83,9 +83,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
   if (irq  0)
   return -ENODEV;
  
 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 - if (!res)
 - return -ENODEV;
  
   if (of_device_is_compatible(pdev-dev.of_node,
   marvell,armada-375-xhci) ||
 @@ -109,15 +106,16 @@ static int xhci_plat_probe(struct platform_device *pdev)
   if (!hcd)
   return -ENOMEM;
  
 - hcd-rsrc_start = res-start;
 - hcd-rsrc_len = resource_size(res);
 -
 + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   hcd-regs = devm_ioremap_resource(pdev-dev, res);
   if (IS_ERR(hcd-regs)) {
   ret = PTR_ERR(hcd-regs);
   goto put_hcd;
   }
  
 + hcd-rsrc_start = res-start;
 + hcd-rsrc_len = resource_size(res);
 +
   /*
* Not all platforms have a clk so it is not an error if the
* clock does not exists.
 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH usb v3 22/29] host: xhci-plat: remove duplicate check on resource

2014-11-03 Thread Felipe Balbi 
On Fri, Oct 31, 2014 at 06:44:37AM +0530, Varka Bhadram wrote:
 From: Varka Bhadram varkabhad...@gmail.com
 
 Sanity check on resource happening with devm_ioremap_resource().
 
 Signed-off-by: Varka Bhadram var...@cdac.in
 Acked-by: Alan Stern st...@rowland.harvard.edu

Acked-by: Felipe Balbi ba...@ti.com

 ---
  drivers/usb/host/xhci-plat.c |   10 --
  1 file changed, 4 insertions(+), 6 deletions(-)
 
 diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
 index 3d78b0c..e68b4ec 100644
 --- a/drivers/usb/host/xhci-plat.c
 +++ b/drivers/usb/host/xhci-plat.c
 @@ -83,9 +83,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
   if (irq  0)
   return -ENODEV;
  
 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 - if (!res)
 - return -ENODEV;
  
   if (of_device_is_compatible(pdev-dev.of_node,
   marvell,armada-375-xhci) ||
 @@ -109,15 +106,16 @@ static int xhci_plat_probe(struct platform_device *pdev)
   if (!hcd)
   return -ENOMEM;
  
 - hcd-rsrc_start = res-start;
 - hcd-rsrc_len = resource_size(res);
 -
 + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   hcd-regs = devm_ioremap_resource(pdev-dev, res);
   if (IS_ERR(hcd-regs)) {
   ret = PTR_ERR(hcd-regs);
   goto put_hcd;
   }
  
 + hcd-rsrc_start = res-start;
 + hcd-rsrc_len = resource_size(res);
 +
   /*
* Not all platforms have a clk so it is not an error if the
* clock does not exists.
 -- 
 1.7.9.5
 

-- 
balbi


signature.asc
Description: Digital signature

[PATCH usb v3 22/29] host: xhci-plat: remove duplicate check on resource

2014-10-30 Thread Varka Bhadram 
From: Varka Bhadram varkabhad...@gmail.com

Sanity check on resource happening with devm_ioremap_resource().

Signed-off-by: Varka Bhadram var...@cdac.in
Acked-by: Alan Stern st...@rowland.harvard.edu
---
 drivers/usb/host/xhci-plat.c |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 3d78b0c..e68b4ec 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -83,9 +83,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (irq  0)
return -ENODEV;
 
-   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-   if (!res)
-   return -ENODEV;
 
if (of_device_is_compatible(pdev-dev.of_node,
marvell,armada-375-xhci) ||
@@ -109,15 +106,16 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (!hcd)
return -ENOMEM;
 
-   hcd-rsrc_start = res-start;
-   hcd-rsrc_len = resource_size(res);
-
+   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
hcd-regs = devm_ioremap_resource(pdev-dev, res);
if (IS_ERR(hcd-regs)) {
ret = PTR_ERR(hcd-regs);
goto put_hcd;
}
 
+   hcd-rsrc_start = res-start;
+   hcd-rsrc_len = resource_size(res);
+
/*
 * Not all platforms have a clk so it is not an error if the
 * clock does not exists.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html