Re: [PATCH v2 2/9] usbip: vhci-hcd: Add vhci struct

[Shuah Khan]

On 05/18/2017 04:08 AM, Yuyang Du wrote:
> From: Yuyang Du 
> 
> In order to support SuperSpeed devices, a USB3 HCD is added to
> share the USB2 HCD. As a result, a VHCI is composed of two
> vhci_hcds associated with the two HCDs respectively. So we add
> another level of abstraction, vhci, and thus this vhci structure.
> 
> Signed-off-by: Yuyang Du 

Looks good.

Acked-by: Shuah Khan 

thanks,
-- Shuah

> ---
>  drivers/usb/usbip/vhci.h | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/vhci.h b/drivers/usb/usbip/vhci.h
> index bff472f..9959584 100644
> --- a/drivers/usb/usbip/vhci.h
> +++ b/drivers/usb/usbip/vhci.h
> @@ -87,8 +87,17 @@ struct vhci_unlink {
>  
>  #define MAX_STATUS_NAME 16
>  
> -/* for usb_bus.hcpriv */
> +struct vhci {
> + spinlock_t lock;
> +
> + struct vhci_hcd *vhci_hcd_hs;
> + struct vhci_hcd *vhci_hcd_ss;
> +};
> +
> +/* for usb_hcd.hcd_priv[0] */
>  struct vhci_hcd {
> + struct vhci *vhci;
> +
>   spinlock_t lock;
>  
>   u32 port_status[VHCI_HC_PORTS];
> @@ -108,6 +117,7 @@ struct vhci_hcd {
>  
>  extern int vhci_num_controllers;
>  extern struct platform_device **vhci_pdevs;
> +extern struct vhci *vhcis;
>  extern struct attribute_group vhci_attr_group;
>  
>  /* vhci_hcd.c */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/9] usbip: vhci-hcd: Add vhci struct

[Yuyang Du]

From: Yuyang Du 

In order to support SuperSpeed devices, a USB3 HCD is added to
share the USB2 HCD. As a result, a VHCI is composed of two
vhci_hcds associated with the two HCDs respectively. So we add
another level of abstraction, vhci, and thus this vhci structure.

Signed-off-by: Yuyang Du 
---
 drivers/usb/usbip/vhci.h | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/usbip/vhci.h b/drivers/usb/usbip/vhci.h
index bff472f..9959584 100644
--- a/drivers/usb/usbip/vhci.h
+++ b/drivers/usb/usbip/vhci.h
@@ -87,8 +87,17 @@ struct vhci_unlink {
 
 #define MAX_STATUS_NAME 16
 
-/* for usb_bus.hcpriv */
+struct vhci {
+   spinlock_t lock;
+
+   struct vhci_hcd *vhci_hcd_hs;
+   struct vhci_hcd *vhci_hcd_ss;
+};
+
+/* for usb_hcd.hcd_priv[0] */
 struct vhci_hcd {
+   struct vhci *vhci;
+
spinlock_t lock;
 
u32 port_status[VHCI_HC_PORTS];
@@ -108,6 +117,7 @@ struct vhci_hcd {
 
 extern int vhci_num_controllers;
 extern struct platform_device **vhci_pdevs;
+extern struct vhci *vhcis;
 extern struct attribute_group vhci_attr_group;
 
 /* vhci_hcd.c */
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html