Re: [PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's
Hi Arnd, Thanks for reviewing, see my comments below: - > > Changes since v2: > > - Based on Arnd Berghman feedback, split out into 2 devices / drivers > > - Base drivers oh ehci-platform.c & ohci-platform.c with required > > extensions > >to allow possible re-merge in the furture. > > Hi Peter, > > This looks much better than the first version. I have some remaining comments > for > how it could be simplified a bit more. Yes I think I've addressed these now in V4, which I will send in a moment. > > The way that you deal with the 48mhz clock seems like it should fit in well > with the generic driver, just like all the rest (once the usb-st-common > stuff is moved into the ohci/ehci drivers), so the alternative would be > to make it all generic now. Yes I tried to do it in a way which would, however I would prefer not to merge into the generic one for now because: - 1) There are some other subtle changes versus the generic drivers. For example in power_on() and power_off() I put the IP into reset and power down, which isn't done in the generic driver. Also with this IP it needs power signal asserted before reset, otherwise it can hang the chip. 2) I don't have any of the other hardware which uses ehci-platform / ohci-platform to test I haven't broken things. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's
On Wednesday 06 August 2014, Peter Griffin wrote: > This series adds support for the OHCI and EHCI on-chip controllers > found in STi consumer electronics SoC's from STMicroelectronics. > > The series has been re-worked from v2 to split out the ehci and ohci parts > into their own drivers / devices like most other ARM platforms based on > feedback from Arnd Bergmann (see here > http://www.spinics.net/lists/linux-usb/msg24.html. > > The ehci-platform & ohci-platform have been used as a basis for this in case > we > wish to merge the drivers again in the future. > > Changes since v2: > - Based on Arnd Berghman feedback, split out into 2 devices / drivers > - Base drivers oh ehci-platform.c & ohci-platform.c with required extensions >to allow possible re-merge in the furture. Hi Peter, This looks much better than the first version. I have some remaining comments for how it could be simplified a bit more. The way that you deal with the 48mhz clock seems like it should fit in well with the generic driver, just like all the rest (once the usb-st-common stuff is moved into the ohci/ehci drivers), so the alternative would be to make it all generic now. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's
This series adds support for the OHCI and EHCI on-chip controllers found in STi consumer electronics SoC's from STMicroelectronics. The series has been re-worked from v2 to split out the ehci and ohci parts into their own drivers / devices like most other ARM platforms based on feedback from Arnd Bergmann (see here http://www.spinics.net/lists/linux-usb/msg24.html. The ehci-platform & ohci-platform have been used as a basis for this in case we wish to merge the drivers again in the future. Changes since v2: - Based on Arnd Berghman feedback, split out into 2 devices / drivers - Base drivers oh ehci-platform.c & ohci-platform.c with required extensions to allow possible re-merge in the furture. Changes since v1: - Correct s/OCHI/OHCI/ spelling - Improve kconfig help message - Various formating / spelling nits identified by Lee Jones - Make driver depend on OF & remove node checks in code - Use devm_ioremap_resource - Remove unnecessary header files Peter Griffin (6): usb: host: usb-st-common: Add common code required by ohci-st and ehci-st usb: host: ehci-st: Add EHCI support for ST STB devices usb: host: ohci-st: Add OHCI driver support for ST STB devices usb: host: ehci-st: Add ehci-st devicetree bindings documentation usb: host: ohci-st: Add ohci-st devicetree bindings documentation MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture Documentation/devicetree/bindings/usb/ehci-st.txt | 41 +++ Documentation/devicetree/bindings/usb/ohci-st.txt | 40 +++ MAINTAINERS | 3 +- drivers/usb/host/Kconfig | 13 + drivers/usb/host/Makefile | 2 + drivers/usb/host/ehci-st.c| 334 ++ drivers/usb/host/ohci-st.c| 302 +++ drivers/usb/host/usb-st-common.c | 99 +++ drivers/usb/host/usb-st-common.h | 34 +++ 9 files changed, 867 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/usb/ehci-st.txt create mode 100644 Documentation/devicetree/bindings/usb/ohci-st.txt create mode 100644 drivers/usb/host/ehci-st.c create mode 100644 drivers/usb/host/ohci-st.c create mode 100644 drivers/usb/host/usb-st-common.c create mode 100644 drivers/usb/host/usb-st-common.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
