Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

On 16 March 2016 at 19:20, Mark Brown  wrote:
> On Wed, Mar 16, 2016 at 01:05:27PM +0200, Felipe Balbi wrote:
>> Mark Brown  writes:
>> > On Mon, Feb 29, 2016 at 11:22:12PM +0900, Mark Brown wrote:
>> >> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:
>
>> > I see Felipe is no longer at TI so his e-mail was bouncing - let's
>> > resend this with his kernel.org address:
>
>> I don't have the patches on my inbox. Neither on kernel.org nor on my
>
> Right, they were last posted in January before you updated MAINTAINERS
> so they'll have gone to your TI address.
>
>> linux.intel.com account. Care to resend ?
>
> Baolin, can you do that please?

OK. I'd like to do it again.


-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Mark Brown]

On Wed, Mar 16, 2016 at 01:05:27PM +0200, Felipe Balbi wrote:
> Mark Brown  writes:
> > On Mon, Feb 29, 2016 at 11:22:12PM +0900, Mark Brown wrote:
> >> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:

> > I see Felipe is no longer at TI so his e-mail was bouncing - let's
> > resend this with his kernel.org address:

> I don't have the patches on my inbox. Neither on kernel.org nor on my

Right, they were last posted in January before you updated MAINTAINERS
so they'll have gone to your TI address.

> linux.intel.com account. Care to resend ?

Baolin, can you do that please?


signature.asc
Description: PGP signature

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

On 16 March 2016 at 19:48, Felipe Balbi  wrote:
>
> Hi Baolin,
>
> Baolin Wang  writes:
>> [ text/plain ]
>> Currently the Linux kernel does not provide any standard integration of this
>> feature that integrates the USB subsystem with the system power regulation
>> provided by PMICs meaning that either vendors must add this in their kernels
>> or USB gadget devices based on Linux (such as mobile phones) may not behave
>> as they should. Thus provide a standard framework for doing this in kernel.
>>
>> Now introduce one user with wm831x_power to support and test the usb charger,
>> which is pending testing. Moreover there may be other potential users will 
>> use
>> it in future.
>>
>> Changes since v5:
>>  - Remove the notifier chain things from the gadget and introduce one 
>> callback
>>  function to report to the usb charger when the gadget state is changed.
>>  - Flesh out the port type detection which combines the USB negotiation and
>>  PMICs detection.
>>  - Supply the notification mechanism to userspace when charger state is 
>> changed.
>>  - Integrate with the vbus staff in the gadget API.
>>  - Spilt up the functionality for userspace with one file per USB charger 
>> type.
>>  - Rebase on "4.5-rc4".
>>
>> Baolin Wang (4):
>>   gadget: Introduce the usb charger framework
>>   gadget: Support for the usb charger framework
>>   gadget: Integrate with the usb gadget supporting for usb charger
>>   power: wm831x_power: Support USB charger current limit management
>
> Thank you for resending this. I'll review it ASAP (probably tomorrow
> when I get to the office. If I have time, still today)

OK. Thanks:)

>
> --
> balbi



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Felipe Balbi]

Hi,

Mark Brown  writes:
> [ text/plain ]
> On Mon, Feb 29, 2016 at 11:22:12PM +0900, Mark Brown wrote:
>> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:
>
> I see Felipe is no longer at TI so his e-mail was bouncing - let's
> resend this with his kernel.org address:

I don't have the patches on my inbox. Neither on kernel.org nor on my
linux.intel.com account. Care to resend ?

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Mark Brown]

On Mon, Feb 29, 2016 at 11:22:12PM +0900, Mark Brown wrote:
> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:

I see Felipe is no longer at TI so his e-mail was bouncing - let's
resend this with his kernel.org address:

> > Currently the Linux kernel does not provide any standard integration of this
> > feature that integrates the USB subsystem with the system power regulation
> > provided by PMICs meaning that either vendors must add this in their kernels
> > or USB gadget devices based on Linux (such as mobile phones) may not behave
> > as they should. Thus provide a standard framework for doing this in kernel.

> So, the review of this seems to have ground to a bit of a halt - we're
> really not seeing any engagement or comments here, people aren't raising
> any problems or suggesting alternative approaches but this isn't moving
> forwards either.  This means that nothing running mainline that isn't
> totally offloaded to hardware can charge at even 500mA, let alone more,
> which seems like a failure to me.  What do we need to move this
> forwards?

> If there are concerns around ABI we could either make sure it's as basic
> as possible (so that it'll be easy to maintain compatibility if we think
> of something better) or just hide things from userspace so that we just
> have the in kernel implementation.




signature.asc
Description: PGP signature

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Mark Brown]

On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:

> Currently the Linux kernel does not provide any standard integration of this
> feature that integrates the USB subsystem with the system power regulation
> provided by PMICs meaning that either vendors must add this in their kernels
> or USB gadget devices based on Linux (such as mobile phones) may not behave
> as they should. Thus provide a standard framework for doing this in kernel.

So, the review of this seems to have ground to a bit of a halt - we're
really not seeing any engagement or comments here, people aren't raising
any problems or suggesting alternative approaches but this isn't moving
forwards either.  This means that nothing running mainline that isn't
totally offloaded to hardware can charge at even 500mA, let alone more,
which seems like a failure to me.  What do we need to move this
forwards?

If there are concerns around ABI we could either make sure it's as basic
as possible (so that it'll be easy to maintain compatibility if we think
of something better) or just hide things from userspace so that we just
have the in kernel implementation.


signature.asc
Description: PGP signature

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Greg KH]

On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:
> Currently the Linux kernel does not provide any standard integration of this
> feature that integrates the USB subsystem with the system power regulation
> provided by PMICs meaning that either vendors must add this in their kernels
> or USB gadget devices based on Linux (such as mobile phones) may not behave
> as they should. Thus provide a standard framework for doing this in kernel.
> 
> Now introduce one user with wm831x_power to support and test the usb charger,
> which is pending testing. Moreover there may be other potential users will use
> it in future.
> 
> Changes since v5:
>  - Remove the notifier chain things from the gadget and introduce one callback
>  function to report to the usb charger when the gadget state is changed.
>  - Flesh out the port type detection which combines the USB negotiation and
>  PMICs detection.
>  - Supply the notification mechanism to userspace when charger state is 
> changed.
>  - Integrate with the vbus staff in the gadget API.
>  - Spilt up the functionality for userspace with one file per USB charger 
> type.
>  - Rebase on "4.4-rc7". 

You already sent out v7, so this should be v8, right?  What changed
since v7?  Why resend it if nothing changed?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

On 25 January 2016 at 11:44, Greg KH  wrote:
> On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote:
>> Currently the Linux kernel does not provide any standard integration of this
>> feature that integrates the USB subsystem with the system power regulation
>> provided by PMICs meaning that either vendors must add this in their kernels
>> or USB gadget devices based on Linux (such as mobile phones) may not behave
>> as they should. Thus provide a standard framework for doing this in kernel.
>>
>> Now introduce one user with wm831x_power to support and test the usb charger,
>> which is pending testing. Moreover there may be other potential users will 
>> use
>> it in future.
>>
>> Changes since v5:
>>  - Remove the notifier chain things from the gadget and introduce one 
>> callback
>>  function to report to the usb charger when the gadget state is changed.
>>  - Flesh out the port type detection which combines the USB negotiation and
>>  PMICs detection.
>>  - Supply the notification mechanism to userspace when charger state is 
>> changed.
>>  - Integrate with the vbus staff in the gadget API.
>>  - Spilt up the functionality for userspace with one file per USB charger 
>> type.
>>  - Rebase on "4.4-rc7".
>
> You already sent out v7, so this should be v8, right?  What changed
> since v7?  Why resend it if nothing changed?

I'm sorry for confusing, This is v7 without any changing, but I'm not
sure maintainers have seen the big improvements since v5, so I resend
it for catching attentions. Sorry again for confusing.

>
> confused,
>
> greg k-h



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

On 7 January 2016 at 19:25, Alex Shi  wrote:
> Hi, Baolin,
>
> There is similar gadget/charger driver on QC msm tree,
> git://codeaurora.org/quic/la/kernel/msm-3.10 msm-3.10
> You may check that as a reference.
>

OK. Thanks.

-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided by PMICs meaning that either vendors must add this in their kernels
or USB gadget devices based on Linux (such as mobile phones) may not behave
as they should. Thus provide a standard framework for doing this in kernel.

Now introduce one user with wm831x_power to support and test the usb charger,
which is pending testing. Moreover there may be other potential users will use
it in future.

Changes since v5:
 - Remove the notifier chain things from the gadget and introduce one callback
 function to report to the usb charger when the gadget state is changed.
 - Flesh out the port type detection which combines the USB negotiation and
 PMICs detection.
 - Supply the notification mechanism to userspace when charger state is changed.
 - Integrate with the vbus staff in the gadget API.
 - Spilt up the functionality for userspace with one file per USB charger type.
 - Rebase on "4.4-rc7". 

Baolin Wang (4):
  gadget: Introduce the usb charger framework
  gadget: Support for the usb charger framework
  gadget: Integrate with the usb gadget supporting for usb charger
  power: wm831x_power: Support USB charger current limit management

 drivers/power/wm831x_power.c  |   69 
 drivers/usb/gadget/Kconfig|7 +
 drivers/usb/gadget/Makefile   |1 +
 drivers/usb/gadget/charger.c  |  708 +
 drivers/usb/gadget/udc/udc-core.c |   11 +
 include/linux/mfd/wm831x/pdata.h  |3 +
 include/linux/usb/gadget.h|   11 +
 include/linux/usb/usb_charger.h   |  164 +
 8 files changed, 974 insertions(+)
 create mode 100644 drivers/usb/gadget/charger.c
 create mode 100644 include/linux/usb/usb_charger.h

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

[Baolin Wang]

Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided by PMICs meaning that either vendors must add this in their kernels
or USB gadget devices based on Linux (such as mobile phones) may not behave
as they should. Thus provide a standard framework for doing this in kernel.

Now introduce one user with wm831x_power to support and test the usb charger,
which is pending testing. Moreover there may be other potential users will use
it in future.

Changes since v5:
 - Remove the notifier chain things from the gadget and introduce one callback
 function to report to the usb charger when the gadget state is changed.
 - Flesh out the port type detection which combines the USB negotiation and
 PMICs detection.
 - Supply the notification mechanism to userspace when charger state is changed.
 - Integrate with the vbus staff in the gadget API.
 - Spilt up the functionality for userspace with one file per USB charger type.

Baolin Wang (4):
  gadget: Introduce the usb charger framework
  gadget: Support for the usb charger framework
  gadget: Integrate with the usb gadget supporting for usb charger
  power: wm831x_power: Support USB charger current limit management

 drivers/power/wm831x_power.c  |   69 
 drivers/usb/gadget/Kconfig|7 +
 drivers/usb/gadget/Makefile   |1 +
 drivers/usb/gadget/charger.c  |  708 +
 drivers/usb/gadget/udc/udc-core.c |   11 +
 include/linux/mfd/wm831x/pdata.h  |3 +
 include/linux/usb/gadget.h|   11 +
 include/linux/usb/usb_charger.h   |  164 +
 8 files changed, 974 insertions(+)
 create mode 100644 drivers/usb/gadget/charger.c
 create mode 100644 include/linux/usb/usb_charger.h

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html