Re: [RFC PATCH] Fix auto-remount of safely removed or ejected USB-3 devices

2016-11-04 Thread Alan Stern
On Fri, 4 Nov 2016, Mathias Nyman wrote:

> Time to get this thing forward.
> 
> Many USB-3 mass storage devices remount after "eject" or safe removal.
> Windows solves this by setting the device to U3, and we will do the same.
> This same info is all in the patch description.
> 
> I am however touching the pm states of usb devices from usb core in this
> patch, and like to get some more eyes on that part.
> If a connected device is already suspended (U3) with remote wakeup enabled
> then we resume it, and disable remote wakeup before going back to U3.
> 
> I'm not however able to test that part of the code since I don't have a USB-3
> device that would support remote wakeup. I'd like to get some feedback, or an
> ack from Alan about this approach before sending this patch forward.

I'll review the patch after I get back from the Linux Plumbers
conference.

Alan Stern

> Otherwise everything seems to work fine, mass storage devices don't re-appear
> automatically, unless physically disconnected and re-connected.
> 
> -Mathias
> 
> Mathias Nyman (1):
>   usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices
> 
>  drivers/usb/core/hub.c | 68 
> +-
>  1 file changed, 17 insertions(+), 51 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC PATCH] Fix auto-remount of safely removed or ejected USB-3 devices

2016-11-04 Thread Mathias Nyman
Time to get this thing forward.

Many USB-3 mass storage devices remount after "eject" or safe removal.
Windows solves this by setting the device to U3, and we will do the same.
This same info is all in the patch description.

I am however touching the pm states of usb devices from usb core in this
patch, and like to get some more eyes on that part.
If a connected device is already suspended (U3) with remote wakeup enabled
then we resume it, and disable remote wakeup before going back to U3.

I'm not however able to test that part of the code since I don't have a USB-3
device that would support remote wakeup. I'd like to get some feedback, or an
ack from Alan about this approach before sending this patch forward.

Otherwise everything seems to work fine, mass storage devices don't re-appear
automatically, unless physically disconnected and re-connected.

-Mathias

Mathias Nyman (1):
  usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices

 drivers/usb/core/hub.c | 68 +-
 1 file changed, 17 insertions(+), 51 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html