Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Greg KH
On Fri, Feb 03, 2017 at 10:44:05AM +0100, Richard Leitner wrote:
> Hi Greg,
> 
> On 02/03/2017 10:03 AM, Greg KH wrote:
> > On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote:
> >> This patch adds a driver for configuration of the Microchip USB251xB/xBi
> >> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus
> >> configuration interface and two to four USB 2.0 downstream ports.
> >>
> >> Furthermore add myself as a maintainer for this driver.
> >>
> >> The datasheet can be found at the manufacturers website, see [1]. All
> >> device-tree exposed configuration features have been tested on a i.MX6
> >> platform with a USB2512B hub.
> >>
> >> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf
> >>
> >> Signed-off-by: Richard Leitner 
> > 
> > What is "RFC" about this?  If you don't think it's ready to be merged,
> > I'll agree with that and so I've deleted it from my review queue :)
> 
> As it's my first patch which adds a new driver I thought (after reading
> [1]) a "RFC" would be appropriate. Isn't it?
> 
> As stated in the commit message we tested it internally on an i.MX6
> platform. Therefore, from my/our point of view, it works as expected and
> should be ready to be merged (otherwise I wouldn't have submitted it to
> the ML ;-) ).
> 
> So how should I proceed here? Re-send it without "RFC"? Wait for some
> feedback? Something completely different?

resend it without the RFC and I'll be glad to review it for inclusion.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
Hi Greg,

On 02/03/2017 10:03 AM, Greg KH wrote:
> On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote:
>> This patch adds a driver for configuration of the Microchip USB251xB/xBi
>> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus
>> configuration interface and two to four USB 2.0 downstream ports.
>>
>> Furthermore add myself as a maintainer for this driver.
>>
>> The datasheet can be found at the manufacturers website, see [1]. All
>> device-tree exposed configuration features have been tested on a i.MX6
>> platform with a USB2512B hub.
>>
>> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf
>>
>> Signed-off-by: Richard Leitner 
> 
> What is "RFC" about this?  If you don't think it's ready to be merged,
> I'll agree with that and so I've deleted it from my review queue :)

As it's my first patch which adds a new driver I thought (after reading
[1]) a "RFC" would be appropriate. Isn't it?

As stated in the commit message we tested it internally on an i.MX6
platform. Therefore, from my/our point of view, it works as expected and
should be ready to be merged (otherwise I wouldn't have submitted it to
the ML ;-) ).

So how should I proceed here? Re-send it without "RFC"? Wait for some
feedback? Something completely different?

thanks for your feedback/help!

kind regards,
Richard L

[1] https://kernelnewbies.org/PatchTipsAndTricks
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Greg KH
On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote:
> This patch adds a driver for configuration of the Microchip USB251xB/xBi
> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus
> configuration interface and two to four USB 2.0 downstream ports.
> 
> Furthermore add myself as a maintainer for this driver.
> 
> The datasheet can be found at the manufacturers website, see [1]. All
> device-tree exposed configuration features have been tested on a i.MX6
> platform with a USB2512B hub.
> 
> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf
> 
> Signed-off-by: Richard Leitner 

What is "RFC" about this?  If you don't think it's ready to be merged,
I'll agree with that and so I've deleted it from my review queue :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-02 Thread Richard Leitner
This patch adds a driver for configuration of the Microchip USB251xB/xBi
USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus
configuration interface and two to four USB 2.0 downstream ports.

Furthermore add myself as a maintainer for this driver.

The datasheet can be found at the manufacturers website, see [1]. All
device-tree exposed configuration features have been tested on a i.MX6
platform with a USB2512B hub.

[1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf

Signed-off-by: Richard Leitner 
---
 Documentation/devicetree/bindings/usb/usb251xb.txt |  83 +++
 MAINTAINERS|   8 +
 drivers/usb/misc/Kconfig   |   9 +
 drivers/usb/misc/Makefile  |   1 +
 drivers/usb/misc/usb251xb.c| 757 +
 include/linux/platform_data/usb251xb.h |  33 +
 6 files changed, 891 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/usb251xb.txt
 create mode 100644 drivers/usb/misc/usb251xb.c
 create mode 100644 include/linux/platform_data/usb251xb.h

diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt 
b/Documentation/devicetree/bindings/usb/usb251xb.txt
new file mode 100644
index 000..9496b06
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/usb251xb.txt
@@ -0,0 +1,83 @@
+Microchip USB 2.0 Hi-Speed Hub Controller
+
+The device node for the configuration of a Microchip USB251xB/xBi USB 2.0
+Hi-Speed Controller.
+
+Required properties :
+ - compatible : Should be "microchip,usb251xb" or one of the specific types:
+   "microchip,usb2512b", "microchip,usb2512bi", "microchip,usb2513b",
+   "microchip,usb2513bi", "microchip,usb2514b", "microchip,usb2514bi"
+ - hub-reset-gpios : Should specify the gpio for hub reset
+
+Optional properties :
+ - reg : I2C address on the selected bus (default is <0x2C>)
+ - skip-config : Skip Hub configuration, but only send the USB-Attach command
+ - vendor-id : USB Vendor ID of the hub (16 bit, default is 0x0424)
+ - product-id : USB Product ID of the hub (16 bit, default depends on type)
+ - device-id : USB Device ID of the hub (16 bit, default is 0x0bb3)
+ - language-id : USB Language ID (16 bit, default is 0x)
+ - manufacturer : USB Manufacturer string (max 31 characters long)
+ - product : USB Product string (max 31 characters long)
+ - serial : USB Serial string (max 31 characters long)
+ - {bus,self}-powered : selects between self- and bus-powered operation 
(default
+   is self-powered)
+ - disable-hi-speed : disable USB Hi-Speed support
+ - {multi,single}-tt : selects between multi- and single-transaction-translator
+   (default is multi-tt)
+ - disable-eop : disable End of Packet generation in full-speed mode
+ - {ganged,individual}-sensing : select over-current sense type in self-powered
+   mode (default is individual)
+ - {ganged,individual}-port-switching : select port power switching mode
+   (default is individual)
+ - dynamic-power-switching : enable auto-switching from self- to bus-powered
+   operation if the local power source is removed or unavailable
+ - oc-delay-{100us,4ms,8ms,16ms} : set over current timer delay (default is 
8ms)
+ - compound-device : indicated the hub is part of a compound device
+ - port-mapping-mode : enable port mapping mode
+ - string-support : enable string descriptor support (required for 
manufacturer,
+   product and serial string configuration)
+ - non-removable-ports : Should specify the ports which have a non-removable
+   device connected.
+ - sp-disabled-ports : Specifies the ports which will be self-power disabled
+ - bp-disabled-ports : Specifies the ports which will be bus-power disabled
+ - max-sp-power : Specifies the maximum current the hub consumes from an
+   upstream port when operating as self-powered hub including the power
+   consumption of a permanently attached peripheral if the hub is
+   configured as a compound device. The value is given in mA in a 0 - 500
+   range (default is 2).
+ - max-bp-power : Specifies the maximum current the hub consumes from an
+   upstream port when operating as bus-powered hub including the power
+   consumption of a permanently attached peripheral if the hub is
+   configured as a compound device. The value is given in mA in a 0 - 500
+   range (default is 100).
+ - max-sp-power : Specifies the maximum current the hub consumes from an
+   upstream port when operating as self-powered hub EXCLUDING the power
+   consumption of a permanently attached peripheral if the hub is
+   configured as a compound device. The value is given in mA in a 0 - 500
+   range (default is 2).
+ - max-bp-power : Specifies the maximum current the hub consumes from an
+   upstream port when operating as bus-powered hub EXCLUDING the power
+   consumption of a permanently attached peripheral if the hub is
+