Re: [RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Yann Cantin
Le 07/08/2012 00:09, Dmitry Torokhov a écrit :
> On Monday, August 06, 2012 02:44:23 PM Greg KH wrote:
>> On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote:
>>> Hi,
>>>
>>> New USB input driver for eBeam devices.
>>>
>>> Currently, only the Luidia eBeam classic projection model is supported.
>>> Edge model and a NEC interactive video-projector support planned for the
>>> end of the mounth.
>>>
>>> Patch 1 to blacklist the device for hid generic-usb.
>>>
>>> Patch 2 is the actual driver.
>>>
>>> Changes from previous :
>>> - switch to div64_s64 for portable 64/64-bits divisions
> 
> Do you really need this much precision? It will be slower on 32 bits..

Yes. I can give the details if you want (homography computation without
floating point maths).

>>> - some cosmetics in device name
>>> - unused include and def removed
>>> - variables name changes for readability
>>>
>>> Pending issues :
>>>
>>> - sysfs custom files : need to pass 13 parameters for calibration :
>>>   choice is between lots of simply-handled, or few with a big sscanf.
>>
>> sysfs is "one value per file", so use lots of different files please.
> 
> This is kind of a "one value" though - it is a transformation matrix.
> Maybe switch it to binary - 9 s32?

Right, but this somehow obfuscate the api. In the other hand, i doubt
there will be lots of calibration tools other that mine.

Is there any drawback for numerous sysfs custom files ?

-- 
Yann Cantin
A4FEB47F
--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Dmitry Torokhov
On Monday, August 06, 2012 02:44:23 PM Greg KH wrote:
> On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote:
> > Hi,
> > 
> > New USB input driver for eBeam devices.
> > 
> > Currently, only the Luidia eBeam classic projection model is supported.
> > Edge model and a NEC interactive video-projector support planned for the
> > end of the mounth.
> > 
> > Patch 1 to blacklist the device for hid generic-usb.
> > 
> > Patch 2 is the actual driver.
> > 
> > Changes from previous :
> > - switch to div64_s64 for portable 64/64-bits divisions

Do you really need this much precision? It will be slower on 32 bits..

> > - some cosmetics in device name
> > - unused include and def removed
> > - variables name changes for readability
> > 
> > Pending issues :
> > 
> > - sysfs custom files : need to pass 13 parameters for calibration :
> >   choice is between lots of simply-handled, or few with a big sscanf.
> 
> sysfs is "one value per file", so use lots of different files please.

This is kind of a "one value" though - it is a transformation matrix.
Maybe switch it to binary - 9 s32?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Greg KH
On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote:
> Hi,
> 
> New USB input driver for eBeam devices.
> 
> Currently, only the Luidia eBeam classic projection model is supported.
> Edge model and a NEC interactive video-projector support planned for the
> end of the mounth. 
> 
> Patch 1 to blacklist the device for hid generic-usb.
> 
> Patch 2 is the actual driver.
> 
> Changes from previous :
> - switch to div64_s64 for portable 64/64-bits divisions
> - some cosmetics in device name
> - unused include and def removed
> - variables name changes for readability
> 
> Pending issues :
> - sysfs custom files : need to pass 13 parameters for calibration :
>   choice is between lots of simply-handled, or few with a big sscanf.

sysfs is "one value per file", so use lots of different files please.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Yann Cantin
Hi,

New USB input driver for eBeam devices.

Currently, only the Luidia eBeam classic projection model is supported.
Edge model and a NEC interactive video-projector support planned for the
end of the mounth. 

Patch 1 to blacklist the device for hid generic-usb.

Patch 2 is the actual driver.

Changes from previous :
- switch to div64_s64 for portable 64/64-bits divisions
- some cosmetics in device name
- unused include and def removed
- variables name changes for readability

Pending issues :
- sysfs custom files : need to pass 13 parameters for calibration :
  choice is between lots of simply-handled, or few with a big sscanf.
- is div64_s64 safe and available on all plateform ? this is the only
  use of this function i've found in all the kernel tree.

The module run fine with a 3.3.6 and a 3.5.0 kernel, both x86_32 and 64.

Thanks for your help.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html