RE: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-13 Thread fx IWATA NOBUO
> why do this refactoring?  please say so why here.

I will add explanation like below.
---
Refactoring to attach and detach operation to reuse common portion to
application(vhci)-side daemon.

The new application(vhci)-side daemon executes same procedures as attach
and detach. Most of common code to access vhci had been implemented in
VHCI userspace wrapper(libsrc/vhci_driver.c) but left in attach and
detach. With this patch, an accessor of vhci driver and tracking of vhci
connections in attach and detach are moved to the VHCI userspace wrapper.
---
And add what is attach, detach and application(vhci)-side daemon using
a diagram.

Thank you for your comment,

nobuo.iwata
//
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, November 10, 2016 9:11 PM
> To: fx IWATA NOBUO
> Cc: valentina.mane...@gmail.com; shuah...@samsung.com;
> linux-usb@vger.kernel.org; fx MICHIMURA TADAO
> Subject: Re: [PATCH v12 6/9] usbip: exporting devices: modifications to
> attach and detach
> 
> On Thu, Oct 13, 2016 at 12:52:10PM +0900, Nobuo Iwata wrote:
> > Refactoring to attach and detatch operation. Common parts to new
> > application(vhci)-side daemon are moved to libsrc/vhci_driver.c.
> 
> why do this refactoring?  please say so why here.
> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:10PM +0900, Nobuo Iwata wrote:
> Refactoring to attach and detatch operation. Common parts to new 
> application(vhci)-side daemon are moved to libsrc/vhci_driver.c. 

why do this refactoring?  please say so why here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html