RE: [PATCH v2 01/21] usb/gadget: multi: fix error return code in cdc_do_config()
On Thursday, July 25, 2013 7:33 PM Felipe Balbi wrote: On Fri, Jul 19, 2013 at 12:28:13PM +0200, Andrzej Pietrasiewicz wrote: Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 59835a (usb: gadget: multi: use function framework for ACM.) Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com you really don't want to send fixes and new code in the same series. Please split this series properly into two series (even if the fixes series is a single patch), and resend with Michal's ack in place so I can apply. Done. The first 2 of the 21 were actually bugfixes, now sent in a separate series, with ACKs. I've also implemented changes resulting from Michal's comments (thank you, Michal!) but since these are new features meant for 3.12, I will post the three configfs support series (mass_storage, acm_ms, multi) in the beginning of the next week after I've done some testing. Thanks, Andrzej -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 01/21] usb/gadget: multi: fix error return code in cdc_do_config()
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote:
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Introduced by commit 59835a (usb: gadget: multi: use
function framework for ACM.)
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
Having said that, one comment inline:
---
drivers/usb/gadget/multi.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/multi.c b/drivers/usb/gadget/multi.c
index 032b96a..867db32 100644
--- a/drivers/usb/gadget/multi.c
+++ b/drivers/usb/gadget/multi.c
@@ -225,8 +225,10 @@ static __init int cdc_do_config(struct usb_configuration
*c)
/* implicit port_num is zero */
f_acm_multi = usb_get_function(fi_acm);
- if (IS_ERR(f_acm_multi))
+ if (IS_ERR(f_acm_multi)) {
+ ret = PTR_ERR(f_acm_multi);
goto err_func_acm;
+ }
To be honest, I would just remove the err_func_acm label and change this
to:
if (IS_ERR(f_acm_multi))
return ERR_PTR(f_acm_multi);
ret = usb_add_function(c, f_acm_multi);
if (ret)
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz(o o)
ooo +email/xmpp: m...@google.com--ooO--(_)--Ooo--
signature.asc
Description: PGP signature
Re: [PATCH v2 01/21] usb/gadget: multi: fix error return code in cdc_do_config()
On Fri, Jul 19, 2013 at 12:28:13PM +0200, Andrzej Pietrasiewicz wrote: Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 59835a (usb: gadget: multi: use function framework for ACM.) Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com you really don't want to send fixes and new code in the same series. Please split this series properly into two series (even if the fixes series is a single patch), and resend with Michal's ack in place so I can apply. -- balbi signature.asc Description: Digital signature
