RE: linux-next build broken for renesas-usb3?
Hi, > From: John Garry, Sent: Tuesday, August 21, 2018 7:30 PM > > On 20/08/2018 04:15, Yoshihiro Shimoda wrote: > > Hi John, Felipe, > > > >> From: John Garry, Sent: Wednesday, August 15, 2018 9:55 PM > >> > >> On 10/08/2018 07:24, Felipe Balbi wrote: > >>> > >>> Hi Yoshihiro, > >>> > >> > >> I see Arnd is fixing it here: > >> https://lore.kernel.org/patchwork/patch/974025/ > >> > >> I am not on that thread, so will comment here: > >> >tristate 'Renesas USB3.0 Peripheral controller' > >> >depends on ARCH_RENESAS || COMPILE_TEST > >> >depends on EXTCON > >> > + depends on USB || !USB > >> > >> Considering this following comment in the same Makefile, is this ok: > >> NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! > > > > Thank you very much for your reports and sorry for the delayed response. > > # I had a vacation in last week. > > > > I submitted a patch to fix the issue as below: > > https://patchwork.kernel.org/patch/10569847/ > > > > ok, thanks. It would have been better to cc me on that. Thank you for your confirmation! And I'm sorry for missing your email address to cc on that... Best regards, Yoshihiro Shimoda > John > > > I think this patch can resolve the NOTE. > > > > Best regards, > > Yoshihiro Shimoda > > > > > > >
Re: linux-next build broken for renesas-usb3?
On 20/08/2018 04:15, Yoshihiro Shimoda wrote: Hi John, Felipe, From: John Garry, Sent: Wednesday, August 15, 2018 9:55 PM On 10/08/2018 07:24, Felipe Balbi wrote: Hi Yoshihiro, I see Arnd is fixing it here: https://lore.kernel.org/patchwork/patch/974025/ I am not on that thread, so will comment here: > tristate 'Renesas USB3.0 Peripheral controller' > depends on ARCH_RENESAS || COMPILE_TEST > depends on EXTCON > +depends on USB || !USB Considering this following comment in the same Makefile, is this ok: NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! Thank you very much for your reports and sorry for the delayed response. # I had a vacation in last week. I submitted a patch to fix the issue as below: https://patchwork.kernel.org/patch/10569847/ ok, thanks. It would have been better to cc me on that. John I think this patch can resolve the NOTE. Best regards, Yoshihiro Shimoda
RE: linux-next build broken for renesas-usb3?
Hi John, Felipe, > From: John Garry, Sent: Wednesday, August 15, 2018 9:55 PM > > On 10/08/2018 07:24, Felipe Balbi wrote: > > > > Hi Yoshihiro, > > > > I see Arnd is fixing it here: > https://lore.kernel.org/patchwork/patch/974025/ > > I am not on that thread, so will comment here: > > tristate 'Renesas USB3.0 Peripheral controller' > > depends on ARCH_RENESAS || COMPILE_TEST > > depends on EXTCON > > + depends on USB || !USB > > Considering this following comment in the same Makefile, is this ok: > NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! Thank you very much for your reports and sorry for the delayed response. # I had a vacation in last week. I submitted a patch to fix the issue as below: https://patchwork.kernel.org/patch/10569847/ I think this patch can resolve the NOTE. Best regards, Yoshihiro Shimoda
Re: linux-next build broken for renesas-usb3?
On 10/08/2018 07:24, Felipe Balbi wrote: Hi Yoshihiro, I see Arnd is fixing it here: https://lore.kernel.org/patchwork/patch/974025/ I am not on that thread, so will comment here: > tristate 'Renesas USB3.0 Peripheral controller' > depends on ARCH_RENESAS || COMPILE_TEST > depends on EXTCON > + depends on USB || !USB Considering this following comment in the same Makefile, is this ok: NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! Thanks, John John Garry writes: Hi all, I am finding the following build error on today's next build: MODPOST 395 modules ERROR: "usb_of_get_companion_dev" [drivers/usb/gadget/udc/renesas_usb3.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 I was using arm64 defconfig, but disabled some USB-related configs including CONFIG_USB, which I think is my problem (USB options at the bottom). So this patch may be the issue: commit 39facfa01c9fc64f90233d1734882f0a0cafe36a Author: Yoshihiro Shimoda Date: Fri Jul 27 10:50:40 2018 +0900 usb: gadget: udc: renesas_usb3: Add register of usb role switch I do notice this message at the top of the Kconfig associated with this driver: NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! Sorry for the noise if I'm mistaken or already reported. Any ideas? # CONFIG_USB_SWITCH_FSA9480 is not set # Host-side USB support is needed for USB Network Adapter support # CONFIG_MOUSE_SYNAPTICS_USB is not set # CONFIG_TOUCHSCREEN_USB_COMPOSITE is not set CONFIG_PINCTRL_TEGRA_XUSB=y # CONFIG_CHARGER_CROS_USBPD is not set # CONFIG_IR_MCEUSB is not set # CONFIG_IR_IGORPLUGUSB is not set # CONFIG_IR_TTUSBIR is not set CONFIG_USB_OHCI_LITTLE_ENDIAN=y CONFIG_USB_SUPPORT=y CONFIG_USB_COMMON=y CONFIG_USB_ARCH_HAS_HCD=y # CONFIG_USB is not set CONFIG_USB_PCI=y # CONFIG_USB_MTU3 is not set CONFIG_USB_MUSB_HDRC=y CONFIG_USB_MUSB_GADGET=y CONFIG_USB_MUSB_SUNXI=y # MUSB DMA mode # CONFIG_MUSB_PIO_ONLY is not set # CONFIG_USB_DWC3 is not set # CONFIG_USB_DWC2 is not set CONFIG_USB_CHIPIDEA=y CONFIG_USB_CHIPIDEA_OF=y CONFIG_USB_CHIPIDEA_PCI=y CONFIG_USB_CHIPIDEA_UDC=y CONFIG_USB_ISP1760=y CONFIG_USB_ISP1761_UDC=y CONFIG_USB_ISP1760_GADGET_ROLE=y # USB port drivers # USB Physical Layer drivers CONFIG_USB_PHY=y CONFIG_NOP_USB_XCEIV=y # CONFIG_USB_GPIO_VBUS is not set # CONFIG_USB_ISP1301 is not set # CONFIG_USB_TEGRA_PHY is not set CONFIG_USB_ULPI=y CONFIG_USB_ULPI_VIEWPORT=y CONFIG_USB_GADGET=y # CONFIG_USB_GADGET_DEBUG is not set # CONFIG_USB_GADGET_DEBUG_FILES is not set # CONFIG_USB_GADGET_DEBUG_FS is not set CONFIG_USB_GADGET_VBUS_DRAW=2 CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=2 # USB Peripheral Controller # CONFIG_USB_FOTG210_UDC is not set # CONFIG_USB_GR_UDC is not set # CONFIG_USB_R8A66597 is not set CONFIG_USB_RENESAS_USB3=m # CONFIG_USB_PXA27X is not set # CONFIG_USB_MV_UDC is not set # CONFIG_USB_MV_U3D is not set CONFIG_USB_SNP_CORE=y CONFIG_USB_SNP_UDC_PLAT=y # CONFIG_USB_M66592 is not set CONFIG_USB_BDC_UDC=y CONFIG_USB_BDC_PCI=y # CONFIG_USB_AMD5536UDC is not set # CONFIG_USB_NET2272 is not set # CONFIG_USB_NET2280 is not set # CONFIG_USB_GOKU is not set # CONFIG_USB_EG20T is not set # CONFIG_USB_GADGET_XILINX is not set # CONFIG_USB_CONFIGFS is not set # CONFIG_USB_LED_TRIG is not set CONFIG_USB_ULPI_BUS=y CONFIG_USB_ROLE_SWITCH=m # LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM) CONFIG_RENESAS_USB_DMAC=m # CONFIG_CLK_RCAR_USB2_CLOCK_SEL is not set CONFIG_EXTCON_USB_GPIO=y CONFIG_EXTCON_USBC_CROS_EC=y CONFIG_RESET_UNIPHIER_USB3=y CONFIG_PHY_SUN4I_USB=y # CONFIG_PHY_SUN9I_USB is not set CONFIG_PHY_MESON8B_USB2=y CONFIG_PHY_MESON_GXL_USB2=y CONFIG_PHY_MESON_GXL_USB3=y # CONFIG_BCM_KONA_USB2_PHY is not set # CONFIG_PHY_BCM_NS_USB2 is not set # CONFIG_PHY_BCM_NS_USB3 is not set CONFIG_PHY_NS2_USB_DRD=y CONFIG_PHY_BRCM_USB=y CONFIG_PHY_HI6220_USB=y CONFIG_PHY_HISI_INNO_USB2=y # CONFIG_PHY_BERLIN_USB is not set # CONFIG_PHY_PXA_28NM_USB2 is not set # CONFIG_PHY_CPCAP_USB is not set # CONFIG_PHY_QCOM_QUSB2 is not set CONFIG_PHY_QCOM_USB_HS=y # CONFIG_PHY_QCOM_USB_HSIC is not set CONFIG_PHY_RCAR_GEN3_USB2=y CONFIG_PHY_RCAR_GEN3_USB3=m CONFIG_PHY_ROCKCHIP_INNO_USB2=y # CONFIG_PHY_ROCKCHIP_USB is not set CONFIG_PHY_TEGRA_XUSB=y # CONFIG_PHY_TUSB1210 is not set
Re: linux-next build broken for renesas-usb3?
Hi Yoshihiro, John Garry writes: > Hi all, > > I am finding the following build error on today's next build: >MODPOST 395 modules > ERROR: "usb_of_get_companion_dev" > [drivers/usb/gadget/udc/renesas_usb3.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > I was using arm64 defconfig, but disabled some USB-related configs > including CONFIG_USB, which I think is my problem (USB options at the > bottom). > > So this patch may be the issue: > commit 39facfa01c9fc64f90233d1734882f0a0cafe36a > Author: Yoshihiro Shimoda > Date: Fri Jul 27 10:50:40 2018 +0900 > > usb: gadget: udc: renesas_usb3: Add register of usb role switch > > I do notice this message at the top of the Kconfig associated with this > driver: > NOTE: Gadget support ** DOES NOT ** depend on host-side CONFIG_USB !! > > Sorry for the noise if I'm mistaken or already reported. Any ideas? > # CONFIG_USB_SWITCH_FSA9480 is not set > # Host-side USB support is needed for USB Network Adapter support > # CONFIG_MOUSE_SYNAPTICS_USB is not set > # CONFIG_TOUCHSCREEN_USB_COMPOSITE is not set > CONFIG_PINCTRL_TEGRA_XUSB=y > # CONFIG_CHARGER_CROS_USBPD is not set > # CONFIG_IR_MCEUSB is not set > # CONFIG_IR_IGORPLUGUSB is not set > # CONFIG_IR_TTUSBIR is not set > CONFIG_USB_OHCI_LITTLE_ENDIAN=y > CONFIG_USB_SUPPORT=y > CONFIG_USB_COMMON=y > CONFIG_USB_ARCH_HAS_HCD=y > # CONFIG_USB is not set > CONFIG_USB_PCI=y > # CONFIG_USB_MTU3 is not set > CONFIG_USB_MUSB_HDRC=y > CONFIG_USB_MUSB_GADGET=y > CONFIG_USB_MUSB_SUNXI=y > # MUSB DMA mode > # CONFIG_MUSB_PIO_ONLY is not set > # CONFIG_USB_DWC3 is not set > # CONFIG_USB_DWC2 is not set > CONFIG_USB_CHIPIDEA=y > CONFIG_USB_CHIPIDEA_OF=y > CONFIG_USB_CHIPIDEA_PCI=y > CONFIG_USB_CHIPIDEA_UDC=y > CONFIG_USB_ISP1760=y > CONFIG_USB_ISP1761_UDC=y > CONFIG_USB_ISP1760_GADGET_ROLE=y > # USB port drivers > # USB Physical Layer drivers > CONFIG_USB_PHY=y > CONFIG_NOP_USB_XCEIV=y > # CONFIG_USB_GPIO_VBUS is not set > # CONFIG_USB_ISP1301 is not set > # CONFIG_USB_TEGRA_PHY is not set > CONFIG_USB_ULPI=y > CONFIG_USB_ULPI_VIEWPORT=y > CONFIG_USB_GADGET=y > # CONFIG_USB_GADGET_DEBUG is not set > # CONFIG_USB_GADGET_DEBUG_FILES is not set > # CONFIG_USB_GADGET_DEBUG_FS is not set > CONFIG_USB_GADGET_VBUS_DRAW=2 > CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=2 > # USB Peripheral Controller > # CONFIG_USB_FOTG210_UDC is not set > # CONFIG_USB_GR_UDC is not set > # CONFIG_USB_R8A66597 is not set > CONFIG_USB_RENESAS_USB3=m > # CONFIG_USB_PXA27X is not set > # CONFIG_USB_MV_UDC is not set > # CONFIG_USB_MV_U3D is not set > CONFIG_USB_SNP_CORE=y > CONFIG_USB_SNP_UDC_PLAT=y > # CONFIG_USB_M66592 is not set > CONFIG_USB_BDC_UDC=y > CONFIG_USB_BDC_PCI=y > # CONFIG_USB_AMD5536UDC is not set > # CONFIG_USB_NET2272 is not set > # CONFIG_USB_NET2280 is not set > # CONFIG_USB_GOKU is not set > # CONFIG_USB_EG20T is not set > # CONFIG_USB_GADGET_XILINX is not set > # CONFIG_USB_CONFIGFS is not set > # CONFIG_USB_LED_TRIG is not set > CONFIG_USB_ULPI_BUS=y > CONFIG_USB_ROLE_SWITCH=m > # LED driver for blink(1) USB RGB LED is under Special HID drivers > (HID_THINGM) > CONFIG_RENESAS_USB_DMAC=m > # CONFIG_CLK_RCAR_USB2_CLOCK_SEL is not set > CONFIG_EXTCON_USB_GPIO=y > CONFIG_EXTCON_USBC_CROS_EC=y > CONFIG_RESET_UNIPHIER_USB3=y > CONFIG_PHY_SUN4I_USB=y > # CONFIG_PHY_SUN9I_USB is not set > CONFIG_PHY_MESON8B_USB2=y > CONFIG_PHY_MESON_GXL_USB2=y > CONFIG_PHY_MESON_GXL_USB3=y > # CONFIG_BCM_KONA_USB2_PHY is not set > # CONFIG_PHY_BCM_NS_USB2 is not set > # CONFIG_PHY_BCM_NS_USB3 is not set > CONFIG_PHY_NS2_USB_DRD=y > CONFIG_PHY_BRCM_USB=y > CONFIG_PHY_HI6220_USB=y > CONFIG_PHY_HISI_INNO_USB2=y > # CONFIG_PHY_BERLIN_USB is not set > # CONFIG_PHY_PXA_28NM_USB2 is not set > # CONFIG_PHY_CPCAP_USB is not set > # CONFIG_PHY_QCOM_QUSB2 is not set > CONFIG_PHY_QCOM_USB_HS=y > # CONFIG_PHY_QCOM_USB_HSIC is not set > CONFIG_PHY_RCAR_GEN3_USB2=y > CONFIG_PHY_RCAR_GEN3_USB3=m > CONFIG_PHY_ROCKCHIP_INNO_USB2=y > # CONFIG_PHY_ROCKCHIP_USB is not set > CONFIG_PHY_TEGRA_XUSB=y > # CONFIG_PHY_TUSB1210 is not set -- balbi signature.asc Description: PGP signature
