Re: [PATCH] usbnet: fix status interrupt urb handling
Oliver Neukum oli...@neukum.org writes: On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote: Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf sierra_net: keep status interrupt URB active, sierra_net triggers status interrupt polling before the net_device is opened (in order to properly receive the sync message response). To be able to receive further interrupts, the interrupt urb needs to be re-submitted, so this patch removes the bogus check for netif_running(). And what about the other drivers for whom this patch means added traffic? This fix is done with a sledge hammer and cares only about some drivers. usbnet_stop calls usbnet_status_stop which kills the status URB, unless the driver explicitly asked for it not to be killed. And the callback properly returns on status == -ENOENT, before the lines in question. So I think Felix is right. None of the other drivers will ever hit the code he deletes. It only affects sierra_net, and that is unwanted. Bjørn -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usbnet: fix status interrupt urb handling
On Wed, 2013-11-13 at 10:09 +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote: Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf sierra_net: keep status interrupt URB active, sierra_net triggers status interrupt polling before the net_device is opened (in order to properly receive the sync message response). To be able to receive further interrupts, the interrupt urb needs to be re-submitted, so this patch removes the bogus check for netif_running(). And what about the other drivers for whom this patch means added traffic? This fix is done with a sledge hammer and cares only about some drivers. usbnet_stop calls usbnet_status_stop which kills the status URB, unless the driver explicitly asked for it not to be killed. And the callback properly returns on status == -ENOENT, before the lines in question. So I think Felix is right. None of the other drivers will ever hit the code he deletes. It only affects sierra_net, and that is unwanted. True. I take back the objection. Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
