Re: [PATCH 1/1] staging:f81534 Add F81532/534 Driver

2015-06-12 Thread Greg KH 
On Fri, Jun 12, 2015 at 01:38:39PM +0800, Peter Hung wrote:
 Greg KH 於 2015/6/12 下午 12:33 寫道:
 Why not just do the work now to clean up the file and get it merged
 properly?  Why put this in staging at all?
 
 
 I'll clear up the file and resend it to usb-serial subsystem mail list.

Note, the custom ioctls will have to be removed, we can't have them in
a usb-serial driver, sorry.  Use the real GPIO api interface instead.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] staging:f81534 Add F81532/534 Driver

2015-06-11 Thread Peter Hung 

Greg KH 於 2015/6/12 下午 12:33 寫道:

Why not just do the work now to clean up the file and get it merged
properly?  Why put this in staging at all?



I'll clear up the file and resend it to usb-serial subsystem mail list.
Thanks for your advices.

--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] staging:f81534 Add F81532/534 Driver

2015-06-11 Thread Greg KH 
On Fri, Jun 12, 2015 at 11:43:12AM +0800, Peter Hung wrote:
 This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
 
 Features:
   1.  F81534 is 1-to-4  F81532 is 1-to-2 serial ports IC
   2.  Support Baudrate from B50 to B150 (excluding B100).
   3.  The RTS signal can be transformed their behavior with 
 configuration
   for transceiver (for RS232/RS485/RS422)
   4.  There are 4x3 GPIOs to control transceiver. It's can be 
 controlled
   with sysfs
 
 If had any question, Please send email to
 hpeter+linux_ker...@gmail.com
 peter_h...@fintek.com.tw

Why not just do the work now to clean up the file and get it merged
properly?  Why put this in staging at all?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html