Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
Le 04/02/13 20:19, ba...@ti.com a écrit : Hi, On Tue, Apr 02, 2013 at 07:10:22PM +0200, Florian Fainelli wrote: diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 05e5143..ab5a3b9 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -6,7 +6,6 @@ # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller config USB_MUSB_HDRC tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' - depends on USB USB_GADGET shouldn't: depends on USB_GADGET be left here ? Indeed this should be left there. Thanks! -- Florian -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
Le 04/02/13 20:06, Alan Stern a écrit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on config USB item. No functionnal change is introduced. This looks almost right. The only problem I see is in drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, because they can be set if EXPERT is enabled. To avoid these issues, I think the best approach is to move all the USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they should have been all along. Felipe, do you agree? Make sense, I will make this a sixth patch to this serie if this sounds right with you? -- Florian -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
Le 04/03/13 14:15, Felipe Balbi a écrit : On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: Le 04/02/13 20:06, Alan Stern a écrit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on config USB item. No functionnal change is introduced. This looks almost right. The only problem I see is in drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, because they can be set if EXPERT is enabled. To avoid these issues, I think the best approach is to move all the USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they should have been all along. Felipe, do you agree? Make sense, I will make this a sixth patch to this serie if this sounds right with you? Pleae don't. Look at my 'next' branch. I deleted drivers/usb/otg/ completely. OTG should be part of usbcore and I have plans of adding generic (and optional) OTG hooks in there. Ok, then I will leave it as it is now and simply address the comment your made initially, does that fit both you and Alan? Thanks! -- Florian -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
On Wed, Apr 03, 2013 at 02:18:20PM +0200, Florian Fainelli wrote: Le 04/03/13 14:15, Felipe Balbi a écrit : On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: Le 04/02/13 20:06, Alan Stern a écrit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on config USB item. No functionnal change is introduced. This looks almost right. The only problem I see is in drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, because they can be set if EXPERT is enabled. To avoid these issues, I think the best approach is to move all the USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they should have been all along. Felipe, do you agree? Make sense, I will make this a sixth patch to this serie if this sounds right with you? Pleae don't. Look at my 'next' branch. I deleted drivers/usb/otg/ completely. OTG should be part of usbcore and I have plans of adding generic (and optional) OTG hooks in there. Ok, then I will leave it as it is now and simply address the comment your made initially, does that fit both you and Alan? Thanks! Fine by me, if something else needs to go, then we can tackle it during -rc or for v3.11. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
On Wed, 3 Apr 2013, Felipe Balbi wrote: On Wed, Apr 03, 2013 at 02:18:20PM +0200, Florian Fainelli wrote: Le 04/03/13 14:15, Felipe Balbi a �crit : On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: Le 04/02/13 20:06, Alan Stern a �crit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on config USB item. No functionnal change is introduced. This looks almost right. The only problem I see is in drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, because they can be set if EXPERT is enabled. To avoid these issues, I think the best approach is to move all the USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they should have been all along. Felipe, do you agree? Make sense, I will make this a sixth patch to this serie if this sounds right with you? Pleae don't. Look at my 'next' branch. I deleted drivers/usb/otg/ completely. OTG should be part of usbcore and I have plans of adding generic (and optional) OTG hooks in there. Ok, then I will leave it as it is now and simply address the comment your made initially, does that fit both you and Alan? Thanks! Fine by me, if something else needs to go, then we can tackle it during -rc or for v3.11. As long as it's okay with Felipe, it's okay with me. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on config USB item. No functionnal change is introduced. This looks almost right. The only problem I see is in drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, because they can be set if EXPERT is enabled. To avoid these issues, I think the best approach is to move all the USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they should have been all along. Felipe, do you agree? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block
Hi, On Tue, Apr 02, 2013 at 07:10:22PM +0200, Florian Fainelli wrote: diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 05e5143..ab5a3b9 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -6,7 +6,6 @@ # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller config USB_MUSB_HDRC tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' - depends on USB USB_GADGET shouldn't: depends on USB_GADGET be left here ? -- balbi signature.asc Description: Digital signature
