Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
On 02/10/2017 10:51 AM, David Miller wrote: > From: Kalle Valo > Date: Thu, 09 Feb 2017 16:10:06 +0200 > >> Florian Fainelli writes: >> > If not, for something like this it's a must: > > drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ > before ‘bool’ > module_param(disable_ap_sme, bool, 0444); > ^ > drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ > before string constant > MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); > ^ > Like like that file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. >>> >>> Thanks Kalle! >>> >>> David, can you hold on this series until Kalle's pull request gets >>> submitted? Past this error, allmodconfig builds fine with this patch >>> series (just tested). Thanks! >> >> Just submitted the pull request: >> >> https://patchwork.ozlabs.org/patch/726133/ > > I've retried this patch series, and will push it out assuming the build > completes properly. I see it merged in net-next/master, thanks a lot this is going to save a lot of cycles in the future, thanks David! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
From: Kalle Valo
Date: Thu, 09 Feb 2017 16:10:06 +0200
> Florian Fainelli writes:
>
If not, for something like this it's a must:
drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’
before ‘bool’
module_param(disable_ap_sme, bool, 0444);
^
drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’
before string constant
MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
^
Like like that file needs linux/module.h included.
>>>
>>> Johannes already fixed a similar (or same) problem in my tree:
>>>
>>> wil6210: include moduleparam.h
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b
>>>
>>> I'm planning to send you a pull request tomorrow which contains that
>>> one.
>>
>> Thanks Kalle!
>>
>> David, can you hold on this series until Kalle's pull request gets
>> submitted? Past this error, allmodconfig builds fine with this patch
>> series (just tested). Thanks!
>
> Just submitted the pull request:
>
> https://patchwork.ozlabs.org/patch/726133/
I've retried this patch series, and will push it out assuming the build
completes properly.
N§²ζμrΈyϊθΨb²X¬ΆΗ§vΨ^)ήΊ{.nΗ+·₯{±ΊΖβΨ^nr‘φ¦zΛλh¨θΪ&’ψ �G«ιh�(ιέ’j"ϊΆm§�οκδzΉήΰώf£’·h§~m
Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Florian Fainelli writes: >>> If not, for something like this it's a must: >>> >>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ >>> before ‘bool’ >>> module_param(disable_ap_sme, bool, 0444); >>> ^ >>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ >>> before string constant >>> MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); >>> ^ >>> Like like that file needs linux/module.h included. >> >> Johannes already fixed a similar (or same) problem in my tree: >> >> wil6210: include moduleparam.h >> >> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b >> >> I'm planning to send you a pull request tomorrow which contains that >> one. > > Thanks Kalle! > > David, can you hold on this series until Kalle's pull request gets > submitted? Past this error, allmodconfig builds fine with this patch > series (just tested). Thanks! Just submitted the pull request: https://patchwork.ozlabs.org/patch/726133/ -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
On 02/08/2017 08:11 AM, Kalle Valo wrote: > David Miller writes: > >> From: Florian Fainelli >> Date: Tue, 7 Feb 2017 15:02:53 -0800 >> >>> I'm hoping this doesn't conflict with what's already in net-next... >>> >>> David, this should probably go via your tree considering the diffstat. >> >> I think you need one more respin. Are you doing an allmodconfig build? I did not, instead tried to test each driver individually in different configurations... >> If not, for something like this it's a must: >> >> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ >> before ‘bool’ >> module_param(disable_ap_sme, bool, 0444); >> ^ >> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ >> before string constant >> MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); >> ^ >> Like like that file needs linux/module.h included. > > Johannes already fixed a similar (or same) problem in my tree: > > wil6210: include moduleparam.h > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b > > I'm planning to send you a pull request tomorrow which contains that > one. Thanks Kalle! David, can you hold on this series until Kalle's pull request gets submitted? Past this error, allmodconfig builds fine with this patch series (just tested). Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you need one more respin. Are you doing an allmodconfig build? > If not, for something like this it's a must: > > drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before > ‘bool’ > module_param(disable_ap_sme, bool, 0444); > ^ > drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before > string constant > MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); > ^ > Like like that file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
From: Florian Fainelli
Date: Tue, 7 Feb 2017 15:02:53 -0800
> I'm hoping this doesn't conflict with what's already in net-next...
>
> David, this should probably go via your tree considering the diffstat.
I think you need one more respin. Are you doing an allmodconfig build?
If not, for something like this it's a must:
drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before
‘bool’
module_param(disable_ap_sme, bool, 0444);
^
drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before
string constant
MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
^
Like like that file needs linux/module.h included.
Thanks.
N§²ζμrΈyϊθΨb²X¬ΆΗ§vΨ^)ήΊ{.nΗ+·₯{±ΊΖβΨ^nr‘φ¦zΛλh¨θΪ&’ψ �G«ιh�(ιέ’j"ϊΆm§�οκδzΉήΰώf£’·h§~m
